Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-19 Thread Christopher Schultz
All, On 5/9/23 13:38, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.89 release is now available for voting. The notable changes compared to 8.5.88 are: - Many improvements to the JSON access log valve. - Deprecate support for the HTTP Connector settings rejectIllegalHeader    and

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-17 Thread Han Li
> On May 10, 2023, at 01:38, Christopher Schultz > wrote: > > The proposed Apache Tomcat 8.5.89 release is now available for voting. > > The notable changes compared to 8.5.88 are: > > - Many improvements to the JSON access log valve. > > - Deprecate support for the HTTP Connector settings

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-17 Thread Christopher Schultz
Rainer, On 5/17/23 09:19, Rainer Jung wrote: Am 09.05.23 um 19:38 schrieb Christopher Schultz: The proposed Apache Tomcat 8.5.89 release is now available for voting. The notable changes compared to 8.5.88 are: - Many improvements to the JSON access log valve. - Deprecate support for the HTTP

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-17 Thread Rainer Jung
Am 09.05.23 um 19:38 schrieb Christopher Schultz: The proposed Apache Tomcat 8.5.89 release is now available for voting. The notable changes compared to 8.5.88 are: - Many improvements to the JSON access log valve. - Deprecate support for the HTTP Connector settings rejectIllegalHeader    and

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-17 Thread Christopher Schultz
All, I currently only have 2 total votes for this release. Is anyone else able to vote? Thanks, -chris On 5/9/23 13:38, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.89 release is now available for voting. The notable changes compared to 8.5.88 are: - Many improvements to the JS

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-12 Thread Mark Thomas
On 12/05/2023 17:46, Christopher Schultz wrote: I'm getting a unit test failure I don't understand: 10-May-2023 22:15:23.192 INFO [main] org.apache.tomcat.util.net.AbstractEndpoint.logCertificate Connector [https-openssl-apr-127.0.0.1-auto-1], TLS virtual host [_default_], certificate t

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-12 Thread Christopher Schultz
All, On 5/9/23 13:38, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.89 release is now available for voting. The notable changes compared to 8.5.88 are: - Many improvements to the JSON access log valve. - Deprecate support for the HTTP Connector settings rejectIllegalHeader    and

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-11 Thread Igal Sapir
Mark, On Thu, May 11, 2023 at 11:23 AM Mark Thomas wrote: > On 11/05/2023 18:25, Igal Sapir wrote: > > On Thu, May 11, 2023 at 6:15 AM Mark Thomas wrote: > > > >> On 10/05/2023 22:26, Christopher Schultz wrote: > >>> On 5/10/23 17:05, Igal Sapir wrote: > >> > >> > >> > That was a specific

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-11 Thread Mark Thomas
On 11/05/2023 18:25, Igal Sapir wrote: On Thu, May 11, 2023 at 6:15 AM Mark Thomas wrote: On 10/05/2023 22:26, Christopher Schultz wrote: On 5/10/23 17:05, Igal Sapir wrote: That was a specific test case. I have the following entry in build.properties: test.entry=org.apache.catalina.fil

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-11 Thread Igal Sapir
On Thu, May 11, 2023 at 6:15 AM Mark Thomas wrote: > On 10/05/2023 22:26, Christopher Schultz wrote: > > On 5/10/23 17:05, Igal Sapir wrote: > > > > >> That was a specific test case. I have the following entry in > >> build.properties: > >> test.entry=org.apache.catalina.filters.TestMapperWebap

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-11 Thread Mark Thomas
On 10/05/2023 22:26, Christopher Schultz wrote: On 5/10/23 17:05, Igal Sapir wrote: That was a specific test case.  I have the following entry in build.properties: test.entry=org.apache.catalina.filters.TestMapperWebapps Confirmed with the following command: ❯ ant echoproperties | grep ent

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Christopher Schultz
Igal, On 5/10/23 17:05, Igal Sapir wrote: Chris, On Wed, May 10, 2023 at 12:28 PM Christopher Schultz < ch...@christopherschultz.net> wrote: Igal, On 5/10/23 14:16, Igal Sapir wrote: The error that I see on Java 8 is: Testsuite: org.apache.catalina.filters.TestMapperWebapps Tests run: 1, F

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Igal Sapir
Chris, On Wed, May 10, 2023 at 12:28 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > Igal, > > On 5/10/23 14:16, Igal Sapir wrote: > >>> The error that I see on Java 8 is: > >>> > >>> Testsuite: org.apache.catalina.filters.TestMapperWebapps > >>> Tests run: 1, Failures: 0, Errors:

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Christopher Schultz
Igal, On 5/10/23 14:16, Igal Sapir wrote: The error that I see on Java 8 is: Testsuite: org.apache.catalina.filters.TestMapperWebapps Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec Testcase: null took 0.001 sec Caused an ERROR Forked Java VM exited abnormally.

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Igal Sapir
Chris, On Wed, May 10, 2023 at 11:08 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > Igal, > > On 5/10/23 13:49, Igal Sapir wrote: > > Chris, > > > > On Wed, May 10, 2023 at 9:58 AM Christopher Schultz < > > ch...@christopherschultz.net> wrote: > > > >> Igal, > >> > >> On 5/10/23

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Christopher Schultz
Igal, On 5/10/23 13:49, Igal Sapir wrote: Chris, On Wed, May 10, 2023 at 9:58 AM Christopher Schultz < ch...@christopherschultz.net> wrote: Igal, On 5/10/23 12:12, Igal Sapir wrote: Chris, On Wed, May 10, 2023 at 8:13 AM Christopher Schultz < ch...@christopherschultz.net> wrote: Igal, O

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Igal Sapir
Chris, On Wed, May 10, 2023 at 9:58 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > Igal, > > On 5/10/23 12:12, Igal Sapir wrote: > > Chris, > > > > On Wed, May 10, 2023 at 8:13 AM Christopher Schultz < > > ch...@christopherschultz.net> wrote: > > > >> Igal, > >> > >> On 5/10/23 0

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Christopher Schultz
Igal, On 5/10/23 12:12, Igal Sapir wrote: Chris, On Wed, May 10, 2023 at 8:13 AM Christopher Schultz < ch...@christopherschultz.net> wrote: Igal, On 5/10/23 08:48, Igal Sapir wrote: Mark, On Wed, May 10, 2023 at 12:43 AM Mark Thomas wrote: On 09/05/2023 23:28, Igal Sapir wrote: ch...@c

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Igal Sapir
Chris, On Wed, May 10, 2023 at 8:13 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > Igal, > > On 5/10/23 08:48, Igal Sapir wrote: > > Mark, > > > > On Wed, May 10, 2023 at 12:43 AM Mark Thomas wrote: > > > >> On 09/05/2023 23:28, Igal Sapir wrote: > >>> ch...@christopherschultz.n

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Christopher Schultz
Igal, On 5/10/23 08:48, Igal Sapir wrote: Mark, On Wed, May 10, 2023 at 12:43 AM Mark Thomas wrote: On 09/05/2023 23:28, Igal Sapir wrote: ch...@christopherschultz.net> wrote: The proposed 8.5.89 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.5.88 (stabl

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Dimitris Soumis
I can verify the same errors as Igal both when running with Java 17 and 8 on Fedora 36 with Apache Ant 1.10.12. Kind regards, Dimitris On Wed, May 10, 2023 at 4:01 PM Igal Sapir wrote: > Mark, > > On Wed, May 10, 2023 at 12:43 AM Mark Thomas wrote: > > > On 09/05/2023 23:28, Igal Sapir wrote:

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Igal Sapir
Mark, On Wed, May 10, 2023 at 12:43 AM Mark Thomas wrote: > On 09/05/2023 23:28, Igal Sapir wrote: > > ch...@christopherschultz.net> wrote: > > > > >> The proposed 8.5.89 release is: > >> [ ] Broken - do not release > >> [ ] Stable - go ahead and release as 8.5.88 (stable) > >> > >> > > I get F

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-10 Thread Mark Thomas
On 09/05/2023 23:28, Igal Sapir wrote: ch...@christopherschultz.net> wrote: The proposed 8.5.89 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.5.88 (stable) I get FAILED test for org.apache.catalina.mapper.TestMapperWebapps FWIW I got that error before so

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-09 Thread Igal Sapir
On Tue, May 9, 2023 at 10:58 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > The proposed Apache Tomcat 8.5.89 release is now available for voting. > > The notable changes compared to 8.5.88 are: > > - Many improvements to the JSON access log valve. > > - Deprecate support for the

Re: [VOTE] Release Apache Tomcat 8.5.89

2023-05-09 Thread Mark Thomas
On 09/05/2023 18:38, Christopher Schultz wrote: The proposed 8.5.89 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.88 (stable) Same issue with the RateLimitFilter tests as the 10.1.x vote. Same fix addressed it. All other tests pass on Linux Windows and Mac

[VOTE] Release Apache Tomcat 8.5.89

2023-05-09 Thread Christopher Schultz
The proposed Apache Tomcat 8.5.89 release is now available for voting. The notable changes compared to 8.5.88 are: - Many improvements to the JSON access log valve. - Deprecate support for the HTTP Connector settings rejectIllegalHeader and allowHostHeaderMismatch and reject HTTP headers wit