Re: Bug 37794 - Parameters, chunked requests and maxPostSize

2009-06-16 Thread Josh Gooding
Good point Tim, and I've been searching the docs for maxPostSize, but I haven't dug really deep into it. I wasn't looking in the right area. Looks like I need to back pedal a bit here. Sorry for not checking into the docs more thoroughly. - Josh On Tue, Jun 16, 2009 at 7:44 AM, Tim Funk wrote

Re: Bug 37794 - Parameters, chunked requests and maxPostSize

2009-06-16 Thread Tim Funk
"infinite" size for POST is bad as a default. It would make it trivial to DOS the site. -Tim Josh Gooding wrote: Gentlemen, Let me ask this. What is the maxPostSize in Tomcat?I'm ok with "a" but I'm trying to think ahead in how to make an extremely large POST acceptable maybe for 7. I h

Re: Bug 37794 - Parameters, chunked requests and maxPostSize

2009-06-16 Thread Mark Thomas
Josh Gooding wrote: > Gentlemen, > > Let me ask this. What is the maxPostSize in Tomcat? Did you look at the docs? http://tomcat.apache.org/tomcat-6.0-doc/config/http.html >I'm ok with "a" but > I'm trying to think ahead in how to make an extremely large POST acceptable > maybe for 7. I ha

Re: Bug 37794 - Parameters, chunked requests and maxPostSize

2009-06-16 Thread Josh Gooding
Gentlemen, Let me ask this. What is the maxPostSize in Tomcat?I'm ok with "a" but I'm trying to think ahead in how to make an extremely large POST acceptable maybe for 7. I have not hit the maxPostSize at all, and I have uploaded some large (+20MB) files with tomcat. Let me see if I can suc

Re: Bug 37794 - Parameters, chunked requests and maxPostSize

2009-06-15 Thread Tim Funk
Yes chunked requests on POST are OK. I like option a too. -Tim Mark Thomas wrote: For chunked request bodies, the content length is unknown. We can track how many bytes we have read. If we read more the maxPostSize, what do we do? a) Throw an exception that leads to a 500 response? b) Drop what

Bug 37794 - Parameters, chunked requests and maxPostSize

2009-06-15 Thread Mark Thomas
Folks, I have been looking at bug 37794 [1] My reading of RFC2616 is that chunked requests with POST are OK. I have a patch that will handle chunked requests. In a similar manner to non-chunked requests, it reads the data into a buffer and then processes it. The question is what to do if we rea