Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-04 Thread Mark Thomas
Costin Manolache wrote: Sorry, I didn't mean for 5.5.x or 6.0.x, but for whatever is next. API breaking development is in http://svn.apache.org/repos/asf/tomcat/trunk/ (not that there is that much of it yet). Nearly all patches to that branch (CTR) are proposed for back porting to 6.0.x, som

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Costin Manolache
On 3/3/08, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > Costin Manolache wrote: > > On 3/3/08, Remy Maucherat <[EMAIL PROTECTED]> wrote: > > > >> On Mon, 2008-03-03 at 15:58 -0700, Filip Hanik - Dev Lists wrote: > >> > >> > >>> Remy Maucherat wrote: > >>> > This problem is a sm

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Filip Hanik - Dev Lists
Costin Manolache wrote: On 3/3/08, Remy Maucherat <[EMAIL PROTECTED]> wrote: On Mon, 2008-03-03 at 15:58 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: This problem is a small detail. Much more should be done if you want to do a refactoring: both th

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Mon, 2008-03-03 at 15:58 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: This problem is a small detail. Much more should be done if you want to do a refactoring: both the mark functionality and readLine need to have direct access to the buffer to be

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Costin Manolache
On 3/3/08, Remy Maucherat <[EMAIL PROTECTED]> wrote: > > On Mon, 2008-03-03 at 15:58 -0700, Filip Hanik - Dev Lists wrote: > > > Remy Maucherat wrote: > > > This problem is a small detail. Much more should be done if you want > to > > > do a refactoring: both the mark functionality and readLine nee

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Remy Maucherat
On Mon, 2008-03-03 at 15:58 -0700, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > > This problem is a small detail. Much more should be done if you want to > > do a refactoring: both the mark functionality and readLine need to have > > direct access to the buffer to be able to be coded in

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Mon, 2008-03-03 at 21:13 +, Mark Thomas wrote: Filip Hanik - Dev Lists wrote: Mark Thomas wrote: Remy Maucherat wrote: On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: Index: java/org/apache/catalina/connector/InputBuffe

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: Mark Thomas wrote: Remy Maucherat wrote: On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: Index: java/org/apache/catalina/connector/InputBuffer.java === ---java/org/apache

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Remy Maucherat
On Mon, 2008-03-03 at 21:13 +, Mark Thomas wrote: > Filip Hanik - Dev Lists wrote: > > Mark Thomas wrote: > >> Remy Maucherat wrote: > >>> On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: > Index: java/org/apache/catalina/connector/InputBuffer.java > >

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: Mark Thomas wrote: Remy Maucherat wrote: On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: Index: java/org/apache/catalina/connector/InputBuffer.java === ---java/org/apache/catalina/connector/

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-28 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-02-27 at 18:25 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: On Wed, 2008-02-27 at 17:08 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: This makes me think there's a straight issue in CharChunk (I su

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-28 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Remy Maucherat wrote: On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: Index: java/org/apache/catalina/connector/InputBuffer.java === ---java/org/apache/catalina/connector/InputBuffer.java(revision 6

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-28 Thread Mark Thomas
Remy Maucherat wrote: On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: Index: java/org/apache/catalina/connector/InputBuffer.java === ---java/org/apache/catalina/connector/InputBuffer.java (revision 630535) +++java/org/apac

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-28 Thread Remy Maucherat
On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: > Index: java/org/apache/catalina/connector/InputBuffer.java > === > ---java/org/apache/catalina/connector/InputBuffer.java(revision > 630535) > +++java/org/apache/catal

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-28 Thread Remy Maucherat
On Wed, 2008-02-27 at 18:25 -0700, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > > On Wed, 2008-02-27 at 17:08 -0700, Filip Hanik - Dev Lists wrote: > > > >> Remy Maucherat wrote: > >> > >>> This makes me think there's a straight issue in CharChunk (I suppose the > >>> problem is

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-02-27 at 17:08 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: This makes me think there's a straight issue in CharChunk (I suppose the problem is that realReadChars gets called with len = 0; if it handled that scenario, things should be fi

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Remy Maucherat
On Wed, 2008-02-27 at 17:08 -0700, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > > This makes me think there's a straight issue in CharChunk (I suppose the > > problem is that realReadChars gets called with len = 0; if it handled > > that scenario, things should be fine). > > > the ol

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-02-27 at 16:04 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: unfortunately, the "elegant" solution caused a regression :( http://issues.apache.org/bugzilla/show_bug.cgi?id=44494 I tested this with the inelegant (original proposed) patch a

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Remy Maucherat
On Wed, 2008-02-27 at 16:04 -0700, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > >> unfortunately, the "elegant" solution caused a regression :( > >> http://issues.apache.org/bugzilla/show_bug.cgi?id=44494 > >> I tested this with the inelegant (original proposed) patch and it > >> worked

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-02-27 at 12:51 -0700, Filip Hanik - Dev Lists wrote: Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Filip Hanik - Dev Lists wrote: Test Case and 5.5.x patch can be found here. h

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-02-27 at 12:51 -0700, Filip Hanik - Dev Lists wrote: Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Filip Hanik - Dev Lists wrote: Test Case and 5.5.x patch can be found here. h

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Remy Maucherat
On Wed, 2008-02-27 at 12:51 -0700, Filip Hanik - Dev Lists wrote: > Bill Barker wrote: > > "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message > > news:[EMAIL PROTECTED] > > > >> Filip Hanik - Dev Lists wrote: > >> > >>> Test Case and 5.5.x patch can be found here. > >>> http://people.ap

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Filip Hanik - Dev Lists
Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Filip Hanik - Dev Lists wrote: Test Case and 5.5.x patch can be found here. http://people.apache.org/~fhanik/tomcat/b2c/ This is what is happening int cnt=conv.read( result, 0, BUFFER_SIZE

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-26 Thread Bill Barker
"Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Bill Barker wrote: >> "Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message >> news:[EMAIL PROTECTED] >> >>> Bill Barker wrote: >>> "Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-26 Thread Filip Hanik - Dev Lists
Bill Barker wrote: "Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Bill Barker wrote: "Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Bill Barker wrote: "Filip Hanik - Dev Lists" <[EMAIL PROT

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-25 Thread Bill Barker
"Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Bill Barker wrote: >> "Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message >> news:[EMAIL PROTECTED] >> >>> Bill Barker wrote: >>> "Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-24 Thread Filip Hanik - Dev Lists
Bill Barker wrote: "Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Bill Barker wrote: "Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> w

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-23 Thread Bill Barker
"Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Bill Barker wrote: >> "Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message >> news:[EMAIL PROTECTED] >> >>> Bill Barker wrote: >>> "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message ne

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-23 Thread Filip Hanik - Dev Lists
Bill Barker wrote: "Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Filip Hanik - Dev Lists wrote: Test Case and 5.5.x patch can be f

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-22 Thread Bill Barker
"Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Bill Barker wrote: >> "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message >> news:[EMAIL PROTECTED] >> >>> Filip Hanik - Dev Lists wrote: >>> Test Case and 5.5.x patch can be found here. http://pe

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-22 Thread Filip Hanik - Dev Lists
Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Filip Hanik - Dev Lists wrote: Test Case and 5.5.x patch can be found here. http://people.apache.org/~fhanik/tomcat/b2c/ This is what is happening int cnt=conv.read( result, 0, BUFFER_SIZE

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-22 Thread Jim Jagielski
On Aug 22, 2007, at 9:32 AM, Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: and so the pissing contest begins, just in a different area. ok, the so the only thing required for the fix is 1. available() call on the intermediate stream 2. make sure the B2CConverter uses while(available) in

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: and so the pissing contest begins, just in a different area. ok, the so the only thing required for the fix is 1. available() call on the intermediate stream 2. make sure the B2CConverter uses while(available) instead of while(true) here is

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: and so the pissing contest begins, just in a different area. ok, the so the only thing required for the fix is 1. available() call on the intermediate stream 2. make sure the B2CConverter uses while(available) instead of while(true) here is the 5.5 patch (had you a

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-22 Thread Filip Hanik - Dev Lists
Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Filip Hanik - Dev Lists wrote: Test Case and 5.5.x patch can be found here. http://people.apache.org/~fhanik/tomcat/b2c/ This is what is happening int cnt=conv.read( result, 0, BUFFER_SIZE

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-21 Thread Bill Barker
"Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Filip Hanik - Dev Lists wrote: >> Test Case and 5.5.x patch can be found here. >> http://people.apache.org/~fhanik/tomcat/b2c/ >> >> This is what is happening >> >> int cnt=conv.read( result, 0, BUFFER_SIZE ); >> is ca

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-21 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Test Case and 5.5.x patch can be found here. http://people.apache.org/~fhanik/tomcat/b2c/ This is what is happening int cnt=conv.read( result, 0, BUFFER_SIZE ); is called with a "while (true)" statement, When the IntermediateInputStream.rea

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-21 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Test Case and 5.5.x patch can be found here. http://people.apache.org/~fhanik/tomcat/b2c/ This is what is happening int cnt=conv.read( result, 0, BUFFER_SIZE ); is called with a "while (true)" statement, When the IntermediateInputStream.read returns -1, the above

Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2007-08-21 Thread Filip Hanik - Dev Lists
Test Case and 5.5.x patch can be found here. http://people.apache.org/~fhanik/tomcat/b2c/ This is what is happening int cnt=conv.read( result, 0, BUFFER_SIZE ); is called with a "while (true)" statement, When the IntermediateInputStream.read returns -1, the above statement returns cnt==1. So t