This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new cbe9c72 Code style
cbe9c72 is described below
2013/8/14 Mark Thomas ma...@apache.org:
Summarising the response to this thread so far:
There is a preference for not strictly enforcing whatever limit is
selected. Rules need exceptions and committers can exercise judgement.
It does create a grey area but the majority is OK with that.
On 14 August 2013 20:41, Mark Thomas ma...@apache.org wrote:
Summarising the response to this thread so far:
There is a preference for not strictly enforcing whatever limit is
selected. Rules need exceptions and committers can exercise judgement.
It does create a grey area but the majority is
On 14.08.2013 12:41, Mark Thomas wrote:
Summarising the response to this thread so far:
There is a preference for not strictly enforcing whatever limit is
selected. Rules need exceptions and committers can exercise judgement.
It does create a grey area but the majority is OK with that.
Mark,
On 8/14/13 6:41 AM, Mark Thomas wrote:
Summarising the response to this thread so far:
There is a preference for not strictly enforcing whatever limit is
selected. Rules need exceptions and committers can exercise judgement.
It does create a grey area but the majority is OK with that.
2013/8/14 Mark Thomas wrote:
Summarising the response to this thread so far:
There is a preference for not strictly enforcing whatever limit is
selected. Rules need exceptions and committers can exercise judgement.
It does create a grey area but the majority is OK with that.
There is a mix
Summarising the response to this thread so far:
There is a preference for not strictly enforcing whatever limit is
selected. Rules need exceptions and committers can exercise judgement.
It does create a grey area but the majority is OK with that.
There is a mix of views on line length but there
On Aug 14, 2013, at 3:41 AM, Mark Thomas ma...@apache.org wrote:
Summarising the response to this thread so far:
There is a preference for not strictly enforcing whatever limit is
selected. Rules need exceptions and committers can exercise judgement.
It does create a grey area but the
My opinion only (since I've been pretty inactive lately ... only enough
time to lurk)
I'm a big fan of long method/class names and 80 character width drives me
nuts - unless your IDE is a phone - 80 is not very wide.
100 many times is just enough extra space to limit a lot of wrapping.
Currently, Tomcat has an 'guide' of a maximum of 80 characters for line
length. It has been a while since we reviewed this and as we are looking
at style rules...
As a starting point what do folks think of the following options:
Line length:
80 - the current
100 -
120 -
Strictness
Informal -
On Aug 8, 2013, at 12:50 PM, Mark Thomas wrote:
Currently, Tomcat has an 'guide' of a maximum of 80 characters for line
length. It has been a while since we reviewed this and as we are looking
at style rules...
As a starting point what do folks think of the following options:
Line
2013/8/8 Mark Thomas ma...@apache.org:
Currently, Tomcat has an 'guide' of a maximum of 80 characters for line
length. It has been a while since we reviewed this and as we are looking
at style rules...
Changing @SuppressWarnings had its technical reasons. I do not see
much reasons to
Mark,
On 8/8/13 1:50 PM, Mark Thomas wrote:
Currently, Tomcat has an 'guide' of a maximum of 80 characters for line
length. It has been a while since we reviewed this and as we are looking
at style rules...
As a starting point what do folks think of the following options:
Line length:
On Aug 8, 2013, at 10:50 AM, Mark Thomas ma...@apache.org wrote:
Currently, Tomcat has an 'guide' of a maximum of 80 characters for line
length. It has been a while since we reviewed this and as we are looking
at style rules...
As a starting point what do folks think of the following
Mark,
On 9/20/2010 6:58 PM, Mark Thomas wrote:
On 20/09/2010 15:04, Wesley Acheson wrote:
I think some documentation should be created on code style. Actually a
bit more than that I think some documentation should be written
saying.
http://tomcat.apache.org/getinvolved.html
As always
2. Coding conventions seem to be applied ... inconsistently. Is there a
code style guide that I can actually follow so my code looks right, or
should I just look at what's already there in the files I'm modifying
and take my best guess at what's appropriate?
Yep. Go with the current style
On 20/09/2010 15:04, Wesley Acheson wrote:
2. Coding conventions seem to be applied ... inconsistently. Is there a
code style guide that I can actually follow so my code looks right, or
should I just look at what's already there in the files I'm modifying
and take my best guess at what's
...@apache.org wrote:
On 20/09/2010 15:04, Wesley Acheson wrote:
2. Coding conventions seem to be applied ... inconsistently. Is there a
code style guide that I can actually follow so my code looks right, or
should I just look at what's already there in the files I'm modifying
and take my best
On 20/09/2010 16:09, Wesley Acheson wrote:
Sorry missed that. Somehow though I think I may have seen it just not
when I was last looking for it. The fact that I named it such seems
like I had it in my subconsious. Sorry
np. There is plenty of scope to improve that along the lines you
suggest.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49268
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Status|NEW |RESOLVED
https://issues.apache.org/bugzilla/show_bug.cgi?id=49268
--- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com 2010-07-10
20:23:02 EDT ---
Thank you for the effort.
I won't comment on the project policies - that is to be discussed and decided
on d...@.
Several comments on the patch
https://issues.apache.org/bugzilla/show_bug.cgi?id=49268
--- Comment #1 from Marc Guillemot mguille...@yahoo.fr 2010-05-21 09:30:31
EDT ---
What about applying this patch to have style conventions verified without
discussion?
Commits here and there again with comments like:
Tabs to spaces. No
https://issues.apache.org/bugzilla/show_bug.cgi?id=49268
Summary: Use checkstyle to enforce common code style
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: Linux
Status: NEW
Severity: enhancement
23 matches
Mail list logo
