Re: Compat versions

2020-12-18 Thread Rémy Maucherat
On Fri, Dec 18, 2020 at 2:56 PM Romain Manni-Bucau wrote: > Hmm, a few thoughts on this topic: > > 1. there is no reason to use reflection in jrecompat (all the java > build > time version) impl can be generated in ant build using asm or bcel > 2. all JreCompat are kind of hardcoded SPI, if this

Re: Compat versions

2020-12-18 Thread Romain Manni-Bucau
Hmm, a few thoughts on this topic: 1. there is no reason to use reflection in jrecompat (all the java > build time version) impl can be generated in ant build using asm or bcel 2. all JreCompat are kind of hardcoded SPI, if this API gets a "ordinal" - priority - and a "matches(int javaMajor)"

Re: Compat versions

2020-12-18 Thread Christopher Schultz
Rémy, On 12/18/20 08:20, Rémy Maucherat wrote: On Fri, Dec 18, 2020 at 12:19 PM Martin Grigorov wrote: On Fri, Dec 18, 2020 at 11:12 AM Rémy Maucherat wrote: Hi, I'd like to refactor the compat classes to align with the LTS versions: - Move Jre9Compat to Jre11Compat - I'll probably

Re: Compat versions

2020-12-18 Thread Rémy Maucherat
On Fri, Dec 18, 2020 at 12:19 PM Martin Grigorov wrote: > On Fri, Dec 18, 2020 at 11:12 AM Rémy Maucherat wrote: > > > Hi, > > > > I'd like to refactor the compat classes to align with the LTS versions: > > - Move Jre9Compat to Jre11Compat > > - I'll probably refactor out GraalCompat > > - For

Re: Compat versions

2020-12-18 Thread Martin Grigorov
On Fri, Dec 18, 2020 at 11:12 AM Rémy Maucherat wrote: > Hi, > > I'd like to refactor the compat classes to align with the LTS versions: > - Move Jre9Compat to Jre11Compat > - I'll probably refactor out GraalCompat > - For the upcoming Java 12+ features, they will all go to a new Jre17Compat >

Compat versions

2020-12-18 Thread Rémy Maucherat
Hi, I'd like to refactor the compat classes to align with the LTS versions: - Move Jre9Compat to Jre11Compat - I'll probably refactor out GraalCompat - For the upcoming Java 12+ features, they will all go to a new Jre17Compat class, which will actually be useable in the meantime by the latest