Re: Improving CGIServlet - path and args to the executable

2011-01-18 Thread Mark Thomas
On 18/01/2011 16:19, Konstantin Kolinko wrote: > So I think of the following: > 1. Allow empty value of "executable" init-param +1. We can just drop that element from the String[] > 2. Introduce additional init-params to explicitly specify additional > arguments: > "executable-arg-1" > "executab

Re: Improving CGIServlet - path and args to the executable

2011-01-18 Thread sebb
On 18 January 2011 19:48, Konstantin Kolinko wrote: > 2011/1/18 sebb : >> >> The empty string is assumed to be "perl", according to: >> > > No. Absence of this init-param is what will be "perl". > > Setting it explicitly overwrites the default. > >        if (getServletConfig().getInitParameter("e

Re: Improving CGIServlet - path and args to the executable

2011-01-18 Thread Konstantin Kolinko
2011/1/18 sebb : > > The empty string is assumed to be "perl", according to: > No. Absence of this init-param is what will be "perl". Setting it explicitly overwrites the default. if (getServletConfig().getInitParameter("executable") != null) { cgiExecutable = getServletConfi

Re: Improving CGIServlet - path and args to the executable

2011-01-18 Thread sebb
On 18 January 2011 16:19, Konstantin Kolinko wrote: > Hi! > > In 6.0.30 to fix BZ 49657 we changed the way how cgi command is built > in CGI Servlet: > http://svn.apache.org/viewvc?view=revision&revision=1004424 > > Earlier implementation used to build the command as a single string, > wrapping pa

Improving CGIServlet - path and args to the executable

2011-01-18 Thread Konstantin Kolinko
Hi! In 6.0.30 to fix BZ 49657 we changed the way how cgi command is built in CGI Servlet: http://svn.apache.org/viewvc?view=revision&revision=1004424 Earlier implementation used to build the command as a single string, wrapping parts of it in double quotes. The new implementation uses Runtime.exe