RE: svn propchange: r1588102 - svn:log

2014-04-23 Thread Konstantin Preißer
Hi, -Original Message- From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] Sent: Tuesday, April 22, 2014 10:50 PM 2014-04-23 0:43 GMT+04:00 Mark Thomas ma...@apache.org: (snip) No objection to the final being restored, it is good practice to use final when possible.

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Christopher Schultz
Mark/Konstantin, On 4/18/14, 11:29 AM, kkoli...@apache.org wrote: Author: kkolinko Revision: 1588102 Modified property: svn:log Modified: svn:log at Fri Apr 18 15:29:06 2014 -- --- svn:log (original) +++ svn:log

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22/04/2014 20:53, Christopher Schultz wrote: Mark/Konstantin, On 4/18/14, 11:29 AM, kkoli...@apache.org wrote: Author: kkolinko Revision: 1588102 Modified property: svn:log Modified: svn:log at Fri Apr 18 15:29:06 2014

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Konstantin Kolinko
2014-04-22 23:53 GMT+04:00 Christopher Schultz ch...@christopherschultz.net: Mark/Konstantin, On 4/18/14, 11:29 AM, kkoli...@apache.org wrote: Author: kkolinko Revision: 1588102 Modified property: svn:log Modified: svn:log at Fri Apr 18 15:29:06 2014

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Christopher Schultz
Mark, On 4/22/14, 3:58 PM, Mark Thomas wrote: On 22/04/2014 20:53, Christopher Schultz wrote: Mark/Konstantin, On 4/18/14, 11:29 AM, kkoli...@apache.org wrote: Author: kkolinko Revision: 1588102 Modified property: svn:log Modified: svn:log at Fri Apr 18 15:29:06 2014

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22/04/2014 21:15, Christopher Schultz wrote: Mark, On 4/22/14, 3:58 PM, Mark Thomas wrote: On 22/04/2014 20:53, Christopher Schultz wrote: Mark/Konstantin, On 4/18/14, 11:29 AM, kkoli...@apache.org wrote: Author: kkolinko Revision:

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Christopher Schultz
Mark, On 4/22/14, 4:18 PM, Mark Thomas wrote: On 22/04/2014 21:15, Christopher Schultz wrote: Mark, On 4/22/14, 3:58 PM, Mark Thomas wrote: On 22/04/2014 20:53, Christopher Schultz wrote: Mark/Konstantin, On 4/18/14, 11:29 AM, kkoli...@apache.org wrote: Author: kkolinko Revision:

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Mark Thomas
On 22/04/2014 21:21, Christopher Schultz wrote: Before posting, I checked just so I wouldn't embarrass myself. It worked just fine. My guess is that you changed the implementation to throw an exception after removing the 'final' which then makes the 'final' legal again. I don't see any

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Konstantin Kolinko
2014-04-23 0:30 GMT+04:00 Mark Thomas ma...@apache.org: On 22/04/2014 21:21, Christopher Schultz wrote: Before posting, I checked just so I wouldn't embarrass myself. It worked just fine. My guess is that you changed the implementation to throw an exception after removing the 'final' which

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Christopher Schultz
Mark, On 4/22/14, 4:30 PM, Mark Thomas wrote: On 22/04/2014 21:21, Christopher Schultz wrote: Before posting, I checked just so I wouldn't embarrass myself. It worked just fine. My guess is that you changed the implementation to throw an exception after removing the 'final' which then makes

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Mark Thomas
On 22/04/2014 21:35, Konstantin Kolinko wrote: 2014-04-23 0:30 GMT+04:00 Mark Thomas ma...@apache.org: On 22/04/2014 21:21, Christopher Schultz wrote: Before posting, I checked just so I wouldn't embarrass myself. It worked just fine. My guess is that you changed the implementation to throw

Re: svn propchange: r1588102 - svn:log

2014-04-22 Thread Konstantin Kolinko
2014-04-23 0:43 GMT+04:00 Mark Thomas ma...@apache.org: On 22/04/2014 21:35, Konstantin Kolinko wrote: 2014-04-23 0:30 GMT+04:00 Mark Thomas ma...@apache.org: On 22/04/2014 21:21, Christopher Schultz wrote: Before posting, I checked just so I wouldn't embarrass myself. It worked just fine.