michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1774954495
Merged into all branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
michael-o closed pull request #672: BZ 66670: Add
SSLHostConfig#certificateKeyPasswordFile and
SSLHostConfig#certificateKeystorePasswordFile
URL: https://github.com/apache/tomcat/pull/672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1772689379
Ok, and I'll update the new OpenSSLContext to do things properly
(eventually) since it would be better to use a memory BIO rather than a file
BIO.
--
This is an automated message from
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1772580776
I'd like to merge this weekend unless there will be objections after my
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1770353017
The Java code is a lot simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1769101843
Guys, I have now changed the code by reading the password file for OpenSSL
in Java, instead of C. Please have a look again.
--
This is an automated message from the Apache Git Service.
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762134403
> > I'm a -0 on loading the password from native code. I would support
"consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in
libtcnative if we wanted to go for
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762132365
> I'm a -0 on loading the password from native code. I would support
"consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in
libtcnative if we wanted to go for that.
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762123047
> I'm a -0 on loading the password from native code. I would support
"consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in
libtcnative if we wanted to go for
ChristopherSchultz commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762120662
I'm a -0 on loading the password from native code. I would support
"consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in
libtcnative if we wanted to go
michael-o commented on code in PR #672:
URL: https://github.com/apache/tomcat/pull/672#discussion_r1358038098
##
java/org/apache/tomcat/util/net/SSLHostConfig.java:
##
@@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws
FileNotFoundExceptio
rmaucher commented on code in PR #672:
URL: https://github.com/apache/tomcat/pull/672#discussion_r1358035893
##
java/org/apache/tomcat/util/net/SSLHostConfig.java:
##
@@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws
FileNotFoundExceptio
michael-o commented on code in PR #672:
URL: https://github.com/apache/tomcat/pull/672#discussion_r1358027078
##
java/org/apache/tomcat/util/net/SSLHostConfig.java:
##
@@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws
FileNotFoundExceptio
michael-o commented on code in PR #672:
URL: https://github.com/apache/tomcat/pull/672#discussion_r1358027078
##
java/org/apache/tomcat/util/net/SSLHostConfig.java:
##
@@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws
FileNotFoundExceptio
rmaucher commented on code in PR #672:
URL: https://github.com/apache/tomcat/pull/672#discussion_r1358020057
##
java/org/apache/tomcat/util/net/SSLHostConfig.java:
##
@@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws
FileNotFoundExceptio
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761201586
> For certificate (key) file, there's an attempt to always use PEMFile. When
that fails, it uses the code path where it simply passes the file name, since
that's what the native API has
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761197570
For certificate (key) file, there's an attempt to always use PEMFile. When
that fails, it uses the code path where it simply passes the file name, since
that's what the native API has had
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761175235
> Ok trying again. So the code addition in tomcat-native simply uses a file
BIO to load the contents of the file and use it as a password. So overall, I do
not understand the benefit of
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761170846
Ok trying again. So the code addition in tomcat-native simply uses a file
BIO to load the contents of the file and use it as a password. So overall, I do
not understand the benefit of the
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761153823
> I don't get it overall. Since that's what ultimately happens (the
tomcat-native patch simply does that), I think the content of the files should
simply be loaded as the password in the
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761136665
I don't get it overall. Since that's what ultimately happens (the
tomcat-native patch simply does that), I think the content of the files should
simply be loaded as the password in the
21 matches
Mail list logo
