Re: Refactoring class loader access to resources

2013-09-25 Thread Romain Manni-Bucau
worse than it, we download the artifact then new File(...).toURI().toURL() :) *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/* *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github: h

Re: Refactoring class loader access to resources

2013-09-25 Thread Mark Thomas
On 24/09/2013 06:44, Romain Manni-Bucau wrote: > Hi > > about the expanding, tomee forces it so an option can work. I agree with > you "theorically" components shouldn't do it but in practises they have to > (there is no real solutions on this side. That's why all APIs about > scanning ends with a

Re: Refactoring class loader access to resources

2013-09-24 Thread Romain Manni-Bucau
Hi about the expanding, tomee forces it so an option can work. I agree with you "theorically" components shouldn't do it but in practises they have to (there is no real solutions on this side. That's why all APIs about scanning ends with a SPI :(). About addURL I think you are right too and addUR

Re: Refactoring class loader access to resources

2013-09-24 Thread Mark Thomas
On 24/09/2013 05:05, Romain Manni-Bucau wrote: > Hi > > about the handler: a lot of container (i particularly know tomee but not > only) use string representation of URL to find file to then work on the > file (either during scanning or sometimes for some more advanced "hack"). > If you introduce

Re: Refactoring class loader access to resources

2013-09-24 Thread Romain Manni-Bucau
Hi about the handler: a lot of container (i particularly know tomee but not only) use string representation of URL to find file to then work on the file (either during scanning or sometimes for some more advanced "hack"). If you introduce something not known by these framework it will just fail. T

Re: Refactoring class loader access to resources

2013-09-24 Thread Mark Thomas
On 23/09/2013 21:52, Romain Manni-Bucau wrote: > I already explained how t8 loader and WebResource breaks libs based on std > URLClassLoader I've looked back through the dev list archives and can't find any specific information that describes the problem in any detail. I'm fairly confident that wh

Re: Refactoring class loader access to resources

2013-09-23 Thread Romain Manni-Bucau
I already explained how t8 loader and WebResource breaks libs based on std URLClassLoader Here is the class in xbean http://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-finder/src/main/java/org/apache/xbean/finder/ClassLoaders.java I know we can workaround it but then we miss classes in th

Re: Refactoring class loader access to resources

2013-09-23 Thread Mark Thomas
On 23/09/2013 13:29, Romain Manni-Bucau wrote: > Xbean (so openwebbeans), groovy (so spring lang, groovy etc...) That doesn't help. It needs to be of the form "With Tomcat 7 we got... but with Tomcat 8 we get...". It might also need a "and it doesn't work because..." depending on how obvious

Re: Refactoring class loader access to resources

2013-09-23 Thread Romain Manni-Bucau
Xbean (so openwebbeans), groovy (so spring lang, groovy etc...) Le 23 sept. 2013 22:27, "Mark Thomas" a écrit : > On 23/09/2013 13:21, Romain Manni-Bucau wrote: > > The main issue of t8 is it breaks some scanning features when relying on > > URLClassLoader (getURLs()), not perfect but common

Re: Refactoring class loader access to resources

2013-09-23 Thread Mark Thomas
On 23/09/2013 13:21, Romain Manni-Bucau wrote: > The main issue of t8 is it breaks some scanning features when relying on > URLClassLoader (getURLs()), not perfect but common in libs... Example(s) please. Mark - To unsubscribe,

Re: Refactoring class loader access to resources

2013-09-23 Thread Romain Manni-Bucau
The main issue of t8 is it breaks some scanning features when relying on URLClassLoader (getURLs()), not perfect but common in libs... Le 23 sept. 2013 19:00, "Mark Thomas" a écrit : > On 23/09/2013 09:08, Rainer Jung wrote: > > On 23.09.2013 17:27, Mark Thomas wrote: > >> I've mentioned on a cou

Re: Refactoring class loader access to resources

2013-09-23 Thread Mark Thomas
On 23/09/2013 09:08, Rainer Jung wrote: > On 23.09.2013 17:27, Mark Thomas wrote: >> I've mentioned on a couple of different threads that refactoring how the >> class loader accesses resources was on my TODO list. I haven't done any >> implementation yet but I have some ideas that I wanted to get s

Re: Refactoring class loader access to resources

2013-09-23 Thread Rainer Jung
On 23.09.2013 17:27, Mark Thomas wrote: > I've mentioned on a couple of different threads that refactoring how the > class loader accesses resources was on my TODO list. I haven't done any > implementation yet but I have some ideas that I wanted to get some > feedback on before I start work. > > T

Refactoring class loader access to resources

2013-09-23 Thread Mark Thomas
I've mentioned on a couple of different threads that refactoring how the class loader accesses resources was on my TODO list. I haven't done any implementation yet but I have some ideas that I wanted to get some feedback on before I start work. The things I have in mind at this point are: - Extrac