Re: Use 'length' when swallowing attributes in BCEL

2014-09-12 Thread Konstantin Kolinko
2014-09-12 13:20 GMT+04:00 Mark Thomas : > On 12/09/2014 10:08, Mark Thomas wrote: >> On 12/09/2014 09:36, Konstantin Kolinko wrote: >>> Hi! >>> >>> Reviewing BCEL method Utility.swallowUnknownAttribute(...), I think >>> the same approach can be used for all other attributes that we ignore, >>> ig

Re: Use 'length' when swallowing attributes in BCEL

2014-09-12 Thread Mark Thomas
On 12/09/2014 10:08, Mark Thomas wrote: > On 12/09/2014 09:36, Konstantin Kolinko wrote: >> Hi! >> >> Reviewing BCEL method Utility.swallowUnknownAttribute(...), I think >> the same approach can be used for all other attributes that we ignore, >> ignoring their internal structure. >> >> That is: w

Re: Use 'length' when swallowing attributes in BCEL

2014-09-12 Thread Mark Thomas
On 12/09/2014 09:36, Konstantin Kolinko wrote: > Hi! > > Reviewing BCEL method Utility.swallowUnknownAttribute(...), I think > the same approach can be used for all other attributes that we ignore, > ignoring their internal structure. > > That is: we know length of their data. In Attribute.readA

Use 'length' when swallowing attributes in BCEL

2014-09-12 Thread Konstantin Kolinko
Hi! Reviewing BCEL method Utility.swallowUnknownAttribute(...), I think the same approach can be used for all other attributes that we ignore, ignoring their internal structure. That is: we know length of their data. In Attribute.readAttribute(): // Length of data in bytes lengt