jaasrealm regression

2013-08-05 Thread Romain Manni-Bucau
Hi it seems we can now configure jaasrealm to use a jaas config file from the webapp. That's great but it would need to fallback to old behavior (jaas system property to find its location) by default otherwise apps using an older tomcat are broken. wdyt? *Romain Manni-Bucau* *Twitter: @rmannibuc

Re: jaasrealm regression

2013-08-07 Thread Mark Thomas
On 06/08/2013 08:51, Romain Manni-Bucau wrote: > Hi > > it seems we can now configure jaasrealm to use a jaas config file from the > webapp. That's great but it would need to fallback to old behavior (jaas > system property to find its location) by default otherwise apps using an > older tomcat ar

Re: jaasrealm regression

2013-08-07 Thread Romain Manni-Bucau
well maybe it does (surely since that's the LoginContext behavior) but error is not obvious at all. I didn't got time to dig deeper into it but i think you are right and the main issue is the error message which should be more explicit saying configFile was not set and system property is missing o

Re: jaasrealm regression

2013-08-07 Thread Mark Thomas
On 07/08/2013 10:21, Romain Manni-Bucau wrote: > well maybe it does (surely since that's the LoginContext behavior) but > error is not obvious at all. > > I didn't got time to dig deeper into it but i think you are right and the > main issue is the error message which should be more explicit sayin

Re: jaasrealm regression

2013-08-07 Thread Romain Manni-Bucau
ok, sorry i basically just set up a simple war sample using tomee maven plugin (but for the part we speak about only tomcat is relevant). This sample was using JAASRealm with the default LoginModule of tomee (properties one if you care). IIRC before when the setup was wrong you get an error messa

Re: jaasrealm regression

2013-08-07 Thread Mark Thomas
On 07/08/2013 10:33, Romain Manni-Bucau wrote: > ok, sorry > > i basically just set up a simple war sample using tomee maven plugin (but > for the part we speak about only tomcat is relevant). This sample was using > JAASRealm with the default LoginModule of tomee (properties one if you > care). >

Re: jaasrealm regression

2013-08-07 Thread Romain Manni-Bucau
you are probably right but having the check "the path you specified doesn't exist" is quite easy and would be a nice enhancement (it is common to think the config is right when it is wrong). *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau