Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-03 Thread Mladen Turk
On 12/03/2010 08:21 AM, Mladen Turk wrote: On 12/03/2010 07:43 AM, Konstantin Kolinko wrote: So, binding to port 80 should be performed during initialization while we have the root privileges, and not during startup. Does binding to port 80 still work with Tomcat 7? Didn't test, but

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-03 Thread Mladen Turk
On 12/03/2010 07:43 AM, Konstantin Kolinko wrote: So, binding to port 80 should be performed during initialization while we have the root privileges, and not during startup. Does binding to port 80 still work with Tomcat 7? Created BZ50406. IMO the entire r1041120 should be reverted and

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-03 Thread Mark Thomas
On 03/12/2010 08:49, Mladen Turk wrote: On 12/03/2010 07:43 AM, Konstantin Kolinko wrote: So, binding to port 80 should be performed during initialization while we have the root privileges, and not during startup. Does binding to port 80 still work with Tomcat 7? Created BZ50406. IMO the

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-03 Thread Mark Thomas
On 03/12/2010 05:45, Mladen Turk wrote: We would need that back or even better axe running and paused and creating an state enum. For example the connector will report as running on start() even if missconfigured cause it is set before Acceptor or Pollers are created. So internally both

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-03 Thread Mladen Turk
On 12/03/2010 06:58 PM, Mark Thomas wrote: Think that single eg. EndpointState enum will cover all the states during start(),pause(),resume(),stop() replacing multiple booleans (at least running and paused) with a single enum. WDTYT? What we really need is the Lifecycle stuff that is in

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-02 Thread Mladen Turk
On 12/01/2010 07:37 PM, ma...@apache.org wrote: Author: markt Date: Wed Dec 1 18:37:29 2010 New Revision: 1041120 URL: http://svn.apache.org/viewvc?rev=1041120view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Bind/release socket on start()/stop() Register/deregister

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-02 Thread Konstantin Kolinko
2010/12/3 Mladen Turk mt...@apache.org: On 12/01/2010 07:37 PM, ma...@apache.org wrote: Author: markt Date: Wed Dec  1 18:37:29 2010 New Revision: 1041120 URL: http://svn.apache.org/viewvc?rev=1041120view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Bind/release

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-02 Thread Mladen Turk
On 12/03/2010 07:43 AM, Konstantin Kolinko wrote: 2010/12/3 Mladen Turkmt...@apache.org: Think that single eg. EndpointState enum will cover all the states during start(),pause(),resume(),stop() replacing multiple booleans (at least running and paused) with a single enum. WDTYT? It makes