Re: svn commit: r596747 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-11-20 Thread Rainer Jung
Mladen Turk wrote: Mladen Turk wrote: Rainer Jung wrote: But I'm open. If we remove the const, we also need to remove it for the log_fmt (got as compiler warning also there, but don't have the line number at hand). Which would you prefer? Do you see a problem with the const, like wrong co

Re: svn commit: r596747 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-11-20 Thread Mladen Turk
Mladen Turk wrote: Rainer Jung wrote: But I'm open. If we remove the const, we also need to remove it for the log_fmt (got as compiler warning also there, but don't have the line number at hand). Which would you prefer? Do you see a problem with the const, like wrong compiler optimization

Re: svn commit: r596747 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-11-20 Thread Mladen Turk
Rainer Jung wrote: But I'm open. If we remove the const, we also need to remove it for the log_fmt (got as compiler warning also there, but don't have the line number at hand). Which would you prefer? Do you see a problem with the const, like wrong compiler optimization or so? Yes, that

Re: svn commit: r596747 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-11-20 Thread Rainer Jung
Mladen Turk wrote: [EMAIL PROTECTED] wrote: Author: rjung Date: Tue Nov 20 09:29:26 2007 New Revision: 596747 URL: http://svn.apache.org/viewvc?rev=596747&view=rev Log: Add comments to explain timestamp formatting for sub seconds resolution. Furthermore increased the accepted format length a b

Re: svn commit: r596747 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-11-20 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Author: rjung Date: Tue Nov 20 09:29:26 2007 New Revision: 596747 URL: http://svn.apache.org/viewvc?rev=596747&view=rev Log: Add comments to explain timestamp formatting for sub seconds resolution. Furthermore increased the accepted format length a bit. Before we accept

svn commit: r596747 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-11-20 Thread rjung
Author: rjung Date: Tue Nov 20 09:29:26 2007 New Revision: 596747 URL: http://svn.apache.org/viewvc?rev=596747&view=rev Log: Add comments to explain timestamp formatting for sub seconds resolution. Furthermore increased the accepted format length a bit. Before we accepted JK_TIME_MAX_SIZE=64 byte