Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-13 Thread David Jencks
I thought this proposal was that at digester-configuration-time, trying to add the same rule twice would raise an exception. IIUC you are talking about digester-runtime behavior which I think everyone thinks is now fine. I'm not really familiar with digester but wondered how practical is

Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-12 Thread Tim Funk
In that case - that would revert the functionality which caused the issue to arrive in the first place. The original bug had a problem because they had the same listener class declared multiple times and it was only being fired once. The fix was to log a duplicate listener message on the user

Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-12 Thread jean-frederic clere
Tim Funk wrote: Not sure if I understand the question, the problem is our use of digester. We had 2 listener rules being created and each called addListener. So when an a was found - it was being processed twice. Yes. My idea was to prevent add twice the same rule in Digester additionally

Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-12 Thread Peter Rossbach
Hi Tim, +1 WebRuleSet LL 250 digester.addCallMethod(prefix + "web-app/listener/listener- class", "addApplicationListener", 0); digester.addRule(prefix + "web-app/jsp-config", jspConfig); digester.addCallMetho

Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-12 Thread Tim Funk
Not sure if I understand the question, the problem is our use of digester. We had 2 listener rules being created and each called addListener. So when an a was found - it was being processed twice. (Or was I missing something?) -Tim jean-frederic clere wrote: [EMAIL PROTECTED] wrote: Aut

Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-12 Thread jean-frederic clere
[EMAIL PROTECTED] wrote: Author: funkman Date: Tue Feb 12 08:27:45 2008 New Revision: 620848 URL: http://svn.apache.org/viewvc?rev=620848&view=rev Log: addition of dupl listener removal and a vote Won't it be possible to prevent the addition in the Digester instead? Cheers Jean-Frederic

svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-12 Thread funkman
Author: funkman Date: Tue Feb 12 08:27:45 2008 New Revision: 620848 URL: http://svn.apache.org/viewvc?rev=620848&view=rev Log: addition of dupl listener removal and a vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/