Re: svn commit: r944511 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2010-05-15 Thread Rainer Jung
On 15.05.2010 22:17, Mark Thomas wrote: On 15/05/2010 00:14, rj...@apache.org wrote: Author: rjung Date: Fri May 14 23:14:51 2010 New Revision: 944511 URL: http://svn.apache.org/viewvc?rev=944511view=rev Log: Check whether context is null. -1 on this change. I'll be reverting it shortly. 1.

Re: Draft of first blog post announcing TC7

2010-05-17 Thread Rainer Jung
Looks good to me! On 17.05.2010 16:41, Mark Thomas wrote: I have drafted an announcement of the upcoming TC7 release for our first blog post. It can be previewed here: http://blogs.apache.org/preview/tomcat/?previewEntry=apache_tomcat_7_released Suggestions for improvements welcome. Note the

Re: About to tag Tomcat 7.0.0-RC2

2010-05-17 Thread Rainer Jung
On 17.05.2010 19:56, Konstantin Kolinko wrote: 2010/5/17 Mark Thomasma...@apache.org: I've just completed testing of trunk. Unit tests - pass They also pass for me, but Gump fails at TestCoyoteAdaptor:

Re: svn commit: r945271 - in /tomcat/trunk/test/org/apache/catalina/startup: DuplicateMappingParamFilter.java DuplicateMappingParamServlet.java NoMappingParamServlet.java ParamServlet.java TestContex

2010-05-17 Thread Rainer Jung
On 17.05.2010 19:50, Konstantin Kolinko wrote: 2010/5/17ma...@apache.org: Author: markt Date: Mon May 17 17:45:53 2010 New Revision: 945271 URL: http://svn.apache.org/viewvc?rev=945271view=rev Log: Fix Eclipse warnings. Reduce line length. @@ -243,14 +253,9 @@ public class

Re: About to tag Tomcat 7.0.0-RC2

2010-05-17 Thread Rainer Jung
On 17.05.2010 19:56, Konstantin Kolinko wrote: 2010/5/17 Mark Thomasma...@apache.org: I've just completed testing of trunk. Unit tests - pass They also pass for me, but Gump fails at TestCoyoteAdaptor:

Re: Release plans for 6.0.27 - ?

2010-06-06 Thread Rainer Jung
On 06.06.2010 17:41, jean-frederic clere wrote: On 06/04/2010 09:57 PM, Konstantin Kolinko wrote: Hi! When can we make 6.0.27? There were a couple of important fixes since 6.0.26, like BZ 48903 (classloader deadlock). I think it is about time to make 6.0.27. +1 I will start to prepare the

Re: svn commit: r952724 - /httpd/httpd/trunk/server/log.c

2010-06-08 Thread Rainer Jung
On 08.06.2010 22:08, William A. Rowe Jr. wrote: On 6/8/2010 1:19 PM, William A. Rowe Jr. wrote: -1 veto. This is not the appropriate test for a threaded MPM. We have ap_mpm_query for this very purpose, please don't continue to propagate this broken meme!!! I'm sorry - I didn't read this

Re: svn commit: r952724 - /httpd/httpd/trunk/server/log.c

2010-06-08 Thread Rainer Jung
Sorry for the noise, wrong list and language ... On 08.06.2010 22:20, Rainer Jung wrote: On 08.06.2010 22:08, William A. Rowe Jr. wrote: On 6/8/2010 1:19 PM, William A. Rowe Jr. wrote: -1 veto. This is not the appropriate test for a threaded MPM. We have ap_mpm_query for this very purpose

Re: JIKESPATH in setclasspath.sh

2010-06-09 Thread Rainer Jung
On 09.06.2010 04:58, Konstantin Kolinko wrote: JIKESPATH environment variable is used to provide path to the standard library files of JRE (rt.jar etc.), because the standard javac compiler knows where those are, but jikes does not. I found the explanation in its FAQ, [1]. [1]

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0-RC4

2010-06-09 Thread Rainer Jung
On 09.06.2010 03:55, nisen wrote: ecj-3.5.1.jar should be change to jasper-jdt.jar in tomcat-7.0-doc/class-loader-howto.html and tomcat-7.0-doc/RELEASE-NOTES.txt --- jasper-jdt.jar - Eclipse JDT 3.2 Java compiler. --- but it's bin\apache-tomcat-7.0.0-RC4.zip\lib\ecj-3.5.1.jar maybe we

Re: svn commit: r952919 - in /tomcat/trunk: RELEASE-NOTES build.xml res/INSTALLLICENSE res/License.rtf webapps/docs/class-loader-howto.xml webapps/docs/jasper-howto.xml

2010-06-09 Thread Rainer Jung
On 09.06.2010 12:25, Mark Thomas wrote: On 09/06/2010 10:22, rj...@apache.org wrote: Author: rjung Date: Wed Jun 9 09:22:32 2010 New Revision: 952919 URL: http://svn.apache.org/viewvc?rev=952919view=rev Log: Cleanup JDT vs. ECJ: - Replace jasper-jdt.jar component with Eclipse JDT Java

Re: ISAPI Redirector issue | Building |

2010-06-09 Thread Rainer Jung
On 09.06.2010 17:17, vini mr wrote: Hi Team, For the IIS tomcat configuration, i need to customize the 503 error message which is present in *'isapi_redirect.dll'*. *DLL file which i am using :*

Re: ISAPI Redirector issue | Building |

2010-06-09 Thread Rainer Jung
On 09.06.2010 17:39, vini mr wrote: I am building .dll file of 32 Bit and i am using IIS of 32Bit Version. and my IIS 6.0 is running on Windows 2003 Server ( 32 Bit ). Hmm, I'm somewhat out of ideas. Never built on VS 2008. Maybe Mladen or Tim have an idea. Rainer On Wed, Jun 9, 2010

Uses of tool wrapper, sourcong setenv

2010-06-09 Thread Rainer Jung
After updating the tool wrapper script I noticed, that it sources setenv and that this might not be adequate. Actually I don't know the common or possible use cases of the script and searching didn't reveal much. Users typically set JVM size in setenv and at least for the digest feature it

Re: tag 6.0.27 on Monday

2010-06-10 Thread Rainer Jung
On 10.06.2010 07:59, jean-frederic clere wrote: Hi, I plan to tag 6.0.27 on Monday (European morning) and start the release process. Comments? +1, thanks! Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: svn commit: r953272 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2010-06-10 Thread Rainer Jung
On 10.06.2010 12:32, jfcl...@apache.org wrote: Author: jfclere Date: Thu Jun 10 10:32:38 2010 New Revision: 953272 URL: http://svn.apache.org/viewvc?rev=953272view=rev Log: Update the status of the Tomcat track: Ready :D Modified: tomcat/site/trunk/docs/index.html

Re: [VOTE] Release Apache Tomcat 7.0.0 as beta

2010-06-20 Thread Rainer Jung
Here we go ... On 14.06.2010 00:15, Mark Thomas wrote: The propsoed 7.0.0 release is [ ] Broken - do not release [ ] Alpha - go ahead and release as 7.0.0 Alpha [X] Beta - go ahead and release as 7.0.0 Beta - To

Re: [VOTE] Release build 6.0.27

2010-06-20 Thread Rainer Jung
On 15.06.2010 10:24, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.27/ According to the release process, the 6.0.27 build corresponding to the tag TOMCAT_6_0_27 is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable

Re: Proposal: Some todo's at AsyncContext detected...

2010-07-01 Thread Rainer Jung
On 01.07.2010 17:20, Marc Guillemot wrote: jean-frederic clere wrote: ... I run a daily test and just looked to what breaks it and complain. Now I am looking to Peter's application to find what is broken. so you're the continuous integration server ;-) Can you publish break information or

Re: svn commit: r960283 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java test/org/apache/catalina/core/TestAsyncContextImpl.java webapps/docs/changelog.xml

2010-07-03 Thread Rainer Jung
Hi Peter, On 04.07.2010 00:48, p...@apache.org wrote: Author: pero Date: Sat Jul 3 22:48:16 2010 New Revision: 960283 URL: http://svn.apache.org/viewvc?rev=960283view=rev Log: Fix Bug 49528 - HttpServletRequest.isAsyncStarted() returns false when a Runnable is started Add isDebugEnabled

RTF and fixcrlf during build

2010-07-04 Thread Rainer Jung
The fixcrlf handling of RTF files when packed into the source distribution has changed as a side effect of http://svn.apache.org/viewvc?view=revisionrevision=893572 It was don't change before and fix after. It seems the RTF spec is at least unclear about correct line endings with a tendency

Re: Proposal: Some todo's at AsyncContext detected...

2010-07-04 Thread Rainer Jung
On 01.07.2010 18:42, Rainer Jung wrote: On 01.07.2010 17:20, Marc Guillemot wrote: jean-frederic clere wrote: ... I run a daily test and just looked to what breaks it and complain. Now I am looking to Peter's application to find what is broken. so you're the continuous integration server

Re: Proposal: Some todo's at AsyncContext detected...

2010-07-05 Thread Rainer Jung
On 04.07.2010 22:11, Peter Roßbach wrote: Hmm, Spec says: public boolean isAsyncStarted() - Returns true if async processing has started on this request, and false otherwise. If this request has been dispatched using one of the AsyncContext.dispatch methods since it was put in asynchronous

Re: [VOTE] Release build 6.0.28

2010-07-07 Thread Rainer Jung
On 29.06.2010 17:17, jean-frederic clere wrote: According to the release process, the 6.0.28 build corresponding to the tag TOMCAT_6_0_28 is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable +++ Comments? - MD5 OK - signatures OK - as Konstantin noted: it would be nice if you added your key to the

Re: [VOTE] Release Tomcat 5.5.30 Build

2010-07-07 Thread Rainer Jung
On 01.07.2010 18:11, Jim Jagielski wrote: According to the release process, the 5.5.30 build corresponding to the tag TOMCAT_5_5_30 [1] is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable - MD5 OK - Signatures OK - Mostly expected differences between tag and src archives, except: - Did you include

Re: [VOTE] Release build 6.0.28

2010-07-07 Thread Rainer Jung
On 07.07.2010 21:00, sebb wrote: On 7 July 2010 10:47, Rainer Jungrainer.j...@kippdata.de wrote: On 29.06.2010 17:17, jean-frederic clere wrote: - build.properties: it would be nice, if you did the release changes to the file before tagging (and undo after) like Mark does for TC 7

Re: [VOTE] Release build 6.0.28

2010-07-08 Thread Rainer Jung
On 08.07.2010 01:14, sebb wrote: On 7 July 2010 21:19, Rainer Jungrainer.j...@kippdata.de wrote: On 07.07.2010 21:00, sebb wrote: On 7 July 2010 10:47, Rainer Jungrainer.j...@kippdata.dewrote: On 29.06.2010 17:17, jean-frederic clere wrote: - build.properties: it would be nice, if

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-08 Thread Rainer Jung
On 08.07.2010 10:30, Marc Guillemot wrote: Mark Thomas wrote: ... JavadocType (versionFormat) - currently 539 failures Not sure what exactly you are proposing here. Could you clarify? I mean the format of the @Version JavaDoc tag what Konstantin Kolinko has started to fix:

Re: svn commit: r962531 [2/2] - in /tomcat/jk/trunk: native/apache-1.3/ native/apache-2.0/ native/iis/ native/iis/pcre/ native/jni/ native/netscape/ native/nt_service/ xdocs/miscellaneous/

2010-07-10 Thread Rainer Jung
On 09.07.2010 17:14, Mladen Turk wrote: On 07/09/2010 03:56 PM, rj...@apache.org wrote: Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=962531r1=962530r2=962531view=diff

Using svn bugtraq?

2010-07-13 Thread Rainer Jung
I had a look at BZ46451. It suggests adding subversion properties to enable the use of subversion bugtraq. This allows a better integration of BZ into subversion commit messages and retrieval when looking at svn logs. There is a blog here

Re: Using svn bugtraq?

2010-07-14 Thread Rainer Jung
On 13.07.2010 22:11, Mark Thomas wrote: On 13/07/2010 19:57, Rainer Jung wrote: I had a look at BZ46451. It suggests adding subversion properties to enable the use of subversion bugtraq. This allows a better integration of BZ into subversion commit messages and retrieval when looking at svn

Re: [PROPOSAL] Change the name of the default host in server.xml

2010-07-15 Thread Rainer Jung
On 15.07.2010 15:34, Konstantin Kolinko wrote: 2010/7/15 Mark Thomasma...@apache.org: I'm teaching a Tomcat course today and tomorrow and one of the students raised the question why is the default host called localhost? The implied relationship to 127.0.0.1 was causing confusion. That got me

Re: Heads up - might need 6.0.29 soon

2010-07-16 Thread Rainer Jung
On 16.07.2010 12:30, Mark Thomas wrote: On 16/07/2010 08:20, jean-frederic clere wrote: On 07/15/2010 11:10 PM, Mark Thomas wrote: Folks, It looks like we have a regression in the cookie handling. Invalidating the session and then requesting a new session results in a mal-formed header (in

Re: Using svn bugtraq?

2010-07-16 Thread Rainer Jung
On 14.07.2010 19:14, Rainer Jung wrote: On 13.07.2010 22:11, Mark Thomas wrote: On 13/07/2010 19:57, Rainer Jung wrote: I had a look at BZ46451. It suggests adding subversion properties to enable the use of subversion bugtraq. This allows a better integration of BZ into subversion commit

Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2010-07-18 Thread Rainer Jung
On 18.07.2010 02:02, Mark Thomas wrote: On 18/07/2010 00:57, ma...@apache.org wrote: Author: markt Date: Sat Jul 17 23:57:23 2010 New Revision: 965150 URL: http://svn.apache.org/viewvc?rev=965150view=rev Log: Restore pero's timeout fix for the BIO connector. Add configuration of the timeout.

Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2010-07-20 Thread Rainer Jung
On 20.07.2010 08:35, jean-frederic clere wrote: On 07/19/2010 07:16 PM, Mark Thomas wrote: On 18/07/2010 23:50, Rainer Jung wrote: On 18.07.2010 02:02, Mark Thomas wrote: On 18/07/2010 00:57, ma...@apache.org wrote: Author: markt Date: Sat Jul 17 23:57:23 2010 New Revision: 965150 URL: http

Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2010-07-21 Thread Rainer Jung
On 21.07.2010 09:40, Mark Thomas wrote: On 20/07/2010 11:14, Rainer Jung wrote: So: the default we use is 1, but if the timeout were=0 then I think the condition in the AsyncTimeout runnable would fail. Agreed. That matches with what I was observing. I have no idea if a default timeout

Re: DO NOT REPLY [Bug 49637] request for AJP command line client

2010-07-22 Thread Rainer Jung
On 22.07.2010 15:49, Mark Thomas wrote: On 22/07/2010 14:44, Rainer Jung wrote: This is a SPAM issue. Is there a way to remove it and possibly block the user? A second SPAM issue by the same reporter is https://issues.apache.org/bugzilla/show_bug.cgi?id=49487 No other issues reported

Re: DO NOT REPLY [Bug 49637] request for AJP command line client

2010-07-22 Thread Rainer Jung
On 22.07.2010 15:49, Henri Gomez wrote: An AJP command line 'client', could be a somewhat good idea :) Sure, this is already tracked via issue https://issues.apache.org/bugzilla/show_bug.cgi?id=47242 The one I referred to had pure Spam content, apart from the title of the issue. Regards,

Re: svn commit: r966613 - in /tomcat/trunk: build.xml test/org/apache/catalina/startup/TestTomcatSSL.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml

2010-07-28 Thread Rainer Jung
On 28.07.2010 07:44, Mladen Turk wrote: On 07/27/2010 08:00 PM, Mark Thomas wrote: What happens if you disable the terminateAPR call? Thanks. That was it. I changed the point where that was called and that fixed it although it did then highlight a huge delay (~30s) to shutdown the connector.

Re: [PROPOSAL] Definition of active sessions

2010-07-29 Thread Rainer Jung
On 29.07.2010 15:02, Mark Thomas wrote: The current Manager implementations have slightly different definitions of 'active session' that I would like to make consistent in 7.0.x (and maybe backport to 6.0.x) Ignoring expired and invalidated sessions: - in the StandardManager, all sessions are

Re: More sources of Tomcat memory leaks

2010-07-29 Thread Rainer Jung
On 29.07.2010 17:00, Arjen Knibbe wrote: I searched for an upgrading to Tomcat 7 manual in the Tomcat documentation to check if the new JreMemoryLeakPreventionListener is mentioned, but I could not find any guidelines for upgrading... There is some info about major version differences at

Re: svn commit: r980535 - in /tomcat/trunk: java/org/apache/catalina/session/ManagerBase.java java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java webapps/docs/changelog.xml

2010-07-30 Thread Rainer Jung
On 29.07.2010 21:22, Mark Thomas wrote: On 29/07/2010 19:32, ma...@apache.org wrote: Author: markt Date: Thu Jul 29 18:32:58 2010 New Revision: 980535 URL: http://svn.apache.org/viewvc?rev=980535view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49407 Make BackupManager and

Re: svn commit: r829196 - /tomcat/tc5.5.x/trunk/STATUS.txt

2009-10-23 Thread Rainer Jung
On 23.10.2009 22:00, rj...@apache.org wrote: +* Loading tcnative is broken since r795039. + https://issues.apache.org/bugzilla/show_bug.cgi?id=47712 + https://issues.apache.org/bugzilla/attachment.cgi?id=24411 + +1: rjung + -1: Just a short note: this is a regression from TC 5.5.27.

Re: SSL Tomcat

2009-11-08 Thread Rainer Jung
On 07.11.2009 17:59, Mark Thomas wrote: All, I was thinking about this on my way back from ApacheCon and we probably need to get some advice out to users early next week. My current understanding is that the MITM attack is triggered by a renegotiation. Yes, client side initiated (AFAIK

Re: SSL Tomcat

2009-11-09 Thread Rainer Jung
On 09.11.2009 11:56, Mark Thomas wrote: Summarising the information gathered so far from various channels (thanks to Bill B., Bill W. Rainer who have done most of the actual work to find the info below). BIO/NIO connectors using JSSE. Vulnerable when renegotiation is triggered by the

Re: SSL Tomcat

2009-11-09 Thread Rainer Jung
On 09.11.2009 17:16, Mark Thomas wrote: Konstantin Kolinko wrote: 2009/11/9 Mark Thomas ma...@apache.org: Summarising the information gathered so far from various channels (thanks to Bill B., Bill W. Rainer who have done most of the actual work to find the info below). BIO/NIO connectors

Re: SSL Tomcat

2009-11-10 Thread Rainer Jung
On 10.11.2009 01:17, Mark Thomas wrote: Costin Manolache wrote: Unless someone has a better solution - I'll submit the fix ( tonight ), will disable re-negotiation for Jsse-mode. I added a system property to allow people how don't care about this, IMO by default it should be on. Sounds

Re: svn commit: r834289 - /tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java

2009-11-10 Thread Rainer Jung
On 10.11.2009 05:36, Costin Manolache wrote: The request will not be executed - how can he continue the attack ? I don't get that as well. As far as I understand the attack, there is no information disclosure. The only thing an attacker can do is mixing his request with a user supplied one,

Re: svn commit: r834477 - in /tomcat/trunk: java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java test/org/apache/catalina/startup/TestTomcatSSL.java

2009-11-10 Thread Rainer Jung
On 10.11.2009 15:26, ma...@apache.org wrote: @@ -105,6 +102,7 @@ protected String clientAuth = false; protected SSLServerSocketFactory sslProxy = null; protected String[] enabledCiphers; +protected boolean enableMitmVulnerability = false; /** * Flag to state

Re: svn commit: r834477 - in /tomcat/trunk: java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java test/org/apache/catalina/startup/TestTomcatSSL.java

2009-11-10 Thread Rainer Jung
On 10.11.2009 16:32, Ian Darwin wrote: Isn't the naming a bit harsh? OpenSSl names it legacy renegotiation (to make it differ from the future renegotiation with TLS extension). So maybe enableLegacyRenegotiation would be better? Of course it wouldn't keep people from activating as much as

Re: SVN logs lost

2009-11-10 Thread Rainer Jung
On 10.11.2009 22:36, Mladen Turk wrote: On 10/11/09 22:11, Mark Thomas wrote: Are there any changes to bring old logs back in, or are they lost for good? They are still there. Tell your client not to stop on copy/move.

Re: SVN logs lost

2009-11-10 Thread Rainer Jung
On 10.11.2009 22:53, Mladen Turk wrote: On 10/11/09 22:43, Rainer Jung wrote: That's a viewvc annoyance. Since the page shows it's revision 802231, type 802230 into the Sticky Revision field and click Set. That will move you to the previous place. Again that one was a short lived copy

Re: APR Connector renegotiation fix

2009-11-12 Thread Rainer Jung
On 12.11.2009 17:39, Mladen Turk wrote: Well even OpenSSL folks admitted that 0.9.8l wrongly approached dealing to that issue. They even removed the SSL3_FLAGS_ALLOW_UNSAFE_LEGACY_RENEGOTIATION flag from the 0.9.8 branch and now they use SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION using

Re: Problem with mod_jk 1.2.28 - Can not render up the page on browser after a long wait

2009-11-12 Thread Rainer Jung
Thomas, please do not cross-post. The discussion is pretty well going on on your post on the users list. See the latest answers you got on your posted test case and logs, which show that for this specific test your request to JBoss didn't return a PDF document, but instead an html snippet.

Re: APR Connector renegotiation fix

2009-11-12 Thread Rainer Jung
On 12.11.2009 21:31, Mladen Turk wrote: On 12/11/09 21:17, Rainer Jung wrote: On 12.11.2009 17:39, Mladen Turk wrote: Well even OpenSSL folks admitted that 0.9.8l wrongly approached dealing to that issue. They even removed the SSL3_FLAGS_ALLOW_UNSAFE_LEGACY_RENEGOTIATION flag from the 0.9.8

Re: Sharing the same $CATALINA_BASE

2009-11-17 Thread Rainer Jung
On 17.11.2009 07:51, Mladen Turk wrote: Hi, Anyone knows what might be the pitfalls of sharing the CATALINA_BASE among multiple TC instances? Presume you have a way to bind multiple instance's Connectors to the same ports what might be other problems? For example app management

Re: SSL MITM status update

2009-11-20 Thread Rainer Jung
Sounds good to me, thanks! Info not yet ready for users@: On d...@httpd there is discusion, whether to fix request splicing attacks by dropping the buffer, therefore effectively not allowing to combine a partial request before reneg with the request coming after the reneg. Although we don't know

Re: svn commit: r890738 - /tomcat/jk/trunk/native/common/jk_util.c

2009-12-15 Thread Rainer Jung
Hi Mladen, On 15.12.2009 11:14, mt...@apache.org wrote: Author: mturk Date: Tue Dec 15 10:14:28 2009 New Revision: 890738 URL: http://svn.apache.org/viewvc?rev=890738view=rev Log: Use better thread id logic. Use 4/8 byte alignment Modified: tomcat/jk/trunk/native/common/jk_util.c

Re: [PROPOSAL] Log rotation in Tomcat Connector

2009-12-18 Thread Rainer Jung
Hi Tim, On 18.12.2009 03:26, Tim Whittington wrote: Hi all We're experiencing issues with the Tomcat Connector log in some IIS production sites where the log file grows to a very large size (8GB on one site). This is almost entirely due to connection errors between the front end and back end

Re: svn commit: r892554 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/changelog.xml webapps/docs/config/realm.xml

2009-12-20 Thread Rainer Jung
Hi Mark, Konstantin and everyone else, On 20.12.2009 03:37, ma...@apache.org wrote: Add support for a connectionTimeout attribute to the JNDIRealm I know I voted fror it, but when going through the commits again I wondered whether we should call is connectTimeout instead of

Re: svn commit: r892834 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-12-21 Thread Rainer Jung
On 21.12.2009 17:16, Mark Thomas wrote: On 21/12/2009 15:59, Konstantin Kolinko wrote: 2009/12/21ma...@apache.org: Author: markt Date: Mon Dec 21 14:30:46 2009 New Revision: 892834 URL: http://svn.apache.org/viewvc?rev=892834view=rev Log: Proposal + +* Fix

Re: svn commit: r892905 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-12-21 Thread Rainer Jung
On 21.12.2009 19:01, Konstantin Kolinko wrote: 2009/12/21rj...@apache.org: Author: rjung Date: Mon Dec 21 17:52:10 2009 New Revision: 892905 URL: http://svn.apache.org/viewvc?rev=892905view=rev Log: Vote. Modified: tomcat/tc6.0.x/trunk/STATUS.txt @@ -335,5 +335,7 @@

Re: svn commit: r892787 - in /tomcat/jk/trunk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2009-12-21 Thread Rainer Jung
On 21.12.2009 13:02, mt...@apache.org wrote: Author: mturk Date: Mon Dec 21 12:02:54 2009 New Revision: 892787 URL: http://svn.apache.org/viewvc?rev=892787view=rev Log: Fix #47224 by invalidating endoint cache on address change Modified: tomcat/jk/trunk/native/common/jk_ajp_common.c

Re: svn commit: r892803 - in /tomcat/jk/trunk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2009-12-21 Thread Rainer Jung
On 21.12.2009 13:55, mt...@apache.org wrote: Author: mturk Date: Mon Dec 21 12:55:02 2009 New Revision: 892803 URL: http://svn.apache.org/viewvc?rev=892803view=rev Log: Fix #48276. Just like with setting port to 0, if the resolve fails, mark the worker as disabled Modified:

Re: svn commit: r893253 - in /tomcat/jk/trunk/native/common: jk_ajp_common.c jk_shm.h jk_status.c

2009-12-22 Thread Rainer Jung
On 22.12.2009 19:09, mt...@apache.org wrote: Something missing and hard to guess. The total number of currently opened connection per worker Cool! - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: svn commit: r893253 - in /tomcat/jk/trunk/native/common: jk_ajp_common.c jk_shm.h jk_status.c

2009-12-22 Thread Rainer Jung
On 22.12.2009 20:05, Mladen Turk wrote: On 12/22/2009 07:18 PM, Rainer Jung wrote: On 22.12.2009 19:09, mt...@apache.org wrote: Something missing and hard to guess. The total number of currently opened connection per worker Cool! Even more cool option would be the mechanism to close all

Re: [VOTE] Release build 6.0.21 (try 2)

2009-12-22 Thread Rainer Jung
On 23.12.2009 00:45, Konstantin Kolinko wrote: 2009/12/22 Mark Thomasma...@apache.org: (...) Since we are going to have to re-tag anyway, it would be good if the patches required to fix the various niggles above were applied before the tag. Mark +1 to re-tag. And I would like the fix to

Re: [VOTE] Release build 6.0.21 (try 2)

2009-12-23 Thread Rainer Jung
On 23.12.2009 10:33, Konstantin Kolinko wrote: 2009/12/23 Mladen Turkmt...@apache.org: On 12/23/2009 02:12 AM, Rainer Jung wrote: release candidates (marking the files with rcX or dev or whatever) the only safe thing would be to burn version number 6.0.21 and go for 6.0.22. +1 Let's make

Re: svn commit: r893479 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-12-23 Thread Rainer Jung
On 23.12.2009 13:10, Mark Thomas wrote: On 23/12/2009 11:39, rj...@apache.org wrote: + One question before going +1: where does '*' as a filename prefix + come from? man mdssum Thanks! I thought it came from simulating some alternative ant way of doing things. As you said,

Re: TR Tomcat Native 1.1.19

2010-01-04 Thread Rainer Jung
On 04.01.2010 14:10, Henri Gomez wrote: It's not the case in the OS/X version Henri: are you able to build a dylib for MacOS wit statically linked in APR and OpenSSL libs? 2010/1/4 Mladen Turkmt...@apache.org: Hi, Version 1.1.18 wasn't properly tagged, so it carries the 1.1.16 version in

Re: TR Tomcat Native 1.1.19

2010-01-04 Thread Rainer Jung
On 04.01.2010 15:53, Mladen Turk wrote: On 01/04/2010 02:10 PM, Henri Gomez wrote: It's not the case in the OS/X version Nope. the windows .rc file wasn't updated before 1.1.18 tag, so when you compile a .dll and check it's resource version, it reports 1.1.16 This can be a problem with some

[tcnative] slight apr and openssl version confusion

2010-01-04 Thread Rainer Jung
What is the use of the file native/srclib/VERSIONS in tcnative? Ib the 1.1.x branch it contains the info: = Use the following version of the libraries - APR 1.2.8, http://apr.apache.org - OpenSSL 0.9.8e, http://www.openssl.org

Re: svn commit: r895700 - /tomcat/native/trunk/native/build/tcnative.m4

2010-01-05 Thread Rainer Jung
On 05.01.2010 08:59, jean-frederic clere wrote: On 01/04/2010 08:50 PM, Konstantin Kolinko wrote: 2010/1/4rj...@apache.org: Author: rjung Date: Mon Jan 4 16:58:04 2010 New Revision: 895700 URL: http://svn.apache.org/viewvc?rev=895700view=rev Log: Fix apr version test i tcnative trunk.

Re: [tcnative] slight apr and openssl version confusion

2010-01-05 Thread Rainer Jung
On 05.01.2010 10:04, Mladen Turk wrote: On 01/05/2010 09:11 AM, jean-frederic clere wrote: I think the file native/srclib/VERSIONS should be created by configure and doesn't need to be in repository. This file is more like a README. It says which version is recommended/required for the

Re: svn commit: r895998 - /tomcat/native/branches/1.1.x/jnirelease.sh

2010-01-05 Thread Rainer Jung
Hi Mladen, I seem to remember that the fix line ends perl script is part of the tcnative repos. Regards, Rainer On 05.01.2010 12:39, mt...@apache.org wrote: Author: mturk Date: Tue Jan 5 11:39:27 2010 New Revision: 895998 URL: http://svn.apache.org/viewvc?rev=895998view=rev Log: Fix

JK 1.2.29 Plan

2010-01-06 Thread Rainer Jung
Any objections to the following plan about JK 1.2.29? - 15.01.2009 make snapshot available for testing feedback like we did for nearly all previous releases - ~22.01.2009 tag 1.2.29 (exact date depending whether there's bug feedback) Regards, Rainer

Re: Tomcat-Lite update

2010-01-10 Thread Rainer Jung
On 08.01.2010 23:10, Yoav Shapira wrote: On Thu, Jan 7, 2010 at 8:29 AM, Konstantin Kolinko knst.koli...@gmail.com wrote: 2010/1/6 Mark Thomasma...@apache.org: On 06/01/2010 00:27, Costin Manolache wrote: Also, I would like to know if other comitters are OK with (temporarily - i.e. until the

[ANN] New committer: Tim Whittington

2010-01-10 Thread Rainer Jung
On behalf of the Tomcat committers I am pleased to announce that Tim Whittington has been voted in as a new Tomcat committer. Please join me in welcoming him. Regards, Rainer - To unsubscribe, e-mail:

Re: With a view to 6.0.23

2010-01-13 Thread Rainer Jung
On 12.01.2010 19:35, Mark Thomas wrote: On 12/01/2010 18:24, Konstantin Kolinko wrote: 2010/1/12 Mark Thomasma...@apache.org: Thank you for vote. I would very like to see the JULI FileHandler buffering patch in 6.0.23. A third vote is required. Done. I think we need to get 6.0.23 out asap.

Re: tagging 6.0.23

2010-01-13 Thread Rainer Jung
On 13.01.2010 10:09, jean-frederic clere wrote: Hi, I plan to tag 6.0.23 tomorrow lunch time (~13h00 my time). +1 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

Please update your build.properties for TC6 builds

2010-01-14 Thread Rainer Jung
In r899134 property version=6.0-snapshot has been removed from build.properties.default and property version.suffix=-dev has been added. The full version is now automatically combined from the individual parts defined in build.properties(.default). Please remove version from your individual

Removing @VERSION@ filtering from top level text files

2010-01-14 Thread Rainer Jung
Konstantin gave some arguments, why the use of @VERSION@ and similar ant tags in top level text files (and filtering them) instead of directly using explicit version numbers like 7 or 7.0 might not be good. The files are - RELEASE-NOTES - RUNNING.txt - BUILDING.txt and

Re: JSP 2.2 EL 2.2 implementation complete

2010-01-14 Thread Rainer Jung
On 14.01.2010 23:47, Mark Thomas wrote: The subject says it all really. Still no sign of the TCK so there are probably some bugs in my understanding/interpretation of the spec. Great Job! - To unsubscribe, e-mail:

Re: [VOTE] Release build 6.0.23

2010-01-14 Thread Rainer Jung
On 15.01.2010 08:22, jean-frederic clere wrote: On 01/14/2010 10:45 PM, Filip Hanik - Dev Lists wrote: if all we find wrong is line endings, then I would suggest 1. fix the packaging script 2. Add the fix to the tag 3. rerun the script 4. post the new binaries We have to fix the TCK

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

2010-01-15 Thread Rainer Jung
On 14.01.2010 21:21, ma...@apache.org wrote: Author: markt Date: Thu Jan 14 20:21:23 2010 New Revision: 899395 URL: http://svn.apache.org/viewvc?rev=899395view=rev Log: zip is for non-windows platforms Hmmm, really? Until recently we didn't have the individual binary release zips for

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

2010-01-15 Thread Rainer Jung
On 15.01.2010 16:06, Mladen Turk wrote: Although some platforms have broken(limited) default tar. Dunno if we are using very long paths that would break tar on Solaris (eg. +100 character path names) Yes, src, bin and fulldocs tarballs include longer path names then 100 chars. OTOH even the

Re: native-doc part of Tomcat site: outdated?

2010-01-19 Thread Rainer Jung
On 19.01.2010 01:59, Konstantin Kolinko wrote: Is http://tomcat.apache.org/native-doc/ generated from /native/trunk, or from /native/branches/1.1.x/ ? Apparently the site for 1.1.18 was generated from trunk, but the one for 1.1.19 from the 1.1.x branch. I'd say should be generated from

Re: JK 1.2.29 Plan

2010-02-07 Thread Rainer Jung
AM GMT +12:00 New Zealand Subject: Re: JK 1.2.29 Plan +1 I've done majority of planned fixes. Let's tag and then play with IIS rotatelogs. BTW, the IIS logging should be fixed now (compiling with commode.obj that forces a real flush on fflush) On 01/06/2010 11:07 AM, Rainer Jung wrote: Any

Re: Enable RAW headers by default in IIS Tomcat connector

2010-02-08 Thread Rainer Jung
On 08.02.2010 08:46, Mladen Turk wrote: On 02/08/2010 08:38 AM, Tim Whittington wrote: There's a USE_RAW_HEADERS define that will force the use of the raw HTTP headers and avoid this problem, so I'd propose that we make that behaviour the default. I agree with having it default, but is it

Re: JK 1.2.29-dev Available for testing

2010-02-17 Thread Rainer Jung
Hi Mladen, On 17.02.2010 13:23, Mladen Turk wrote: On 02/11/2010 12:15 PM, Mladen Turk wrote: Test snapshot for 1.2.29 is available at http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/ So far no comments, so I suppose everything works like a charm. Since we have postponed this

Re: Tagging 1.2.29

2010-02-22 Thread Rainer Jung
- silence from me - (but I still plan to review the changes later today) On 22.02.2010 14:39, Mladen Turk wrote: Hi, I plan to tag 1.2.29 tomorrow around 12:00 GMT and later propose a vote. We had few release snapshots that had no show-stoppers reported beside one bug and one regression that

Re: Tagging 1.2.29

2010-02-22 Thread Rainer Jung
Hi Mladen, On 22.02.2010 14:39, Mladen Turk wrote: Hi, I plan to tag 1.2.29 tomorrow around 12:00 GMT and later propose a vote. We had few release snapshots that had no show-stoppers reported beside one bug and one regression that are already solved. In case someone has a serious reason why I

Re: svn commit: r915603 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/manager/ webapps/docs/ webapps/manager/WEB-INF/

2010-02-24 Thread Rainer Jung
On 24.02.2010 01:07, ma...@apache.org wrote: Author: markt Date: Wed Feb 24 00:07:06 2010 New Revision: 915603 URL: http://svn.apache.org/viewvc?rev=915603view=rev Log: Add basic memory leak detection for JMX and manager (kkolinko/markt) Modified:

Re: svn commit: r915603 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/manager/ webapps/docs/ webapps/manager/WEB-INF/

2010-02-24 Thread Rainer Jung
On 24.02.2010 11:47, Mark Thomas wrote: On 24/02/2010 10:18, Rainer Jung wrote: On 24.02.2010 01:07, ma...@apache.org wrote: Author: markt Date: Wed Feb 24 00:07:06 2010 New Revision: 915603 URL: http://svn.apache.org/viewvc?rev=915603view=rev Log: Add basic memory leak detection for JMX

Re: [VOTE] Withdraw Tomcat Connectors 1.2.29 (was: svn commit: r916938)

2010-02-27 Thread Rainer Jung
On 27.02.2010 13:02, Konstantin Kolinko wrote: 2010/2/27mt...@apache.org: Author: mturk Date: Sat Feb 27 10:16:14 2010 New Revision: 916938 URL: http://svn.apache.org/viewvc?rev=916938view=rev Log: Revert withdrawal notice. Seems this requires a vote If withdrawing needs a vote, here is my

Re: [VOTE] Withdraw Tomcat Connectors 1.2.29 (was: svn commit: r916938)

2010-02-27 Thread Rainer Jung
On 27.02.2010 15:16, Mladen Turk wrote: On 02/27/2010 02:28 PM, Konstantin Kolinko wrote: 2010/2/27 Mladen Turkmt...@apache.org: +1 If withdrawing needs a vote, here is my +1. It does. Same as for release. It's been only a day since announced, so as soon we remove it and release 1.2.30

Re: [VOTE] Withdraw Tomcat Connectors 1.2.29 (was: svn commit: r916938)

2010-02-27 Thread Rainer Jung
On 27.02.2010 15:54, Mladen Turk wrote: On 02/27/2010 03:24 PM, Rainer Jung wrote: I just made an notice on tomcat index.html Should be enough thought. I'll also add the same notice to README.html files inside binaries/ Shouldn't we also remove the 29 files form dist and archive? Once

Re: [VOTE] Release Tomcat Connectors 1.2.30

2010-02-28 Thread Rainer Jung
On 27.02.2010 12:14, Mladen Turk wrote: Apache Tomcat Connectors 1.2.30 is: [X] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are Thanks for RMing and producing the Windows

Re: [VOTE] Release Tomcat Connectors 1.2.30

2010-02-28 Thread Rainer Jung
On 28.02.2010 23:18, Rainer Jung wrote: 1) Logging Performance on ISAPI/Windows The logging changes for Windows seem to dramatically slow down log performance. That's not a problem when having only occasional info etc., but when switching to debug or trace log operation ow gets really slow. E.g

<    2   3   4   5   6   7   8   9   10   11   >