Re: [PR] Bump org.apache.tomcat:tomcat-catalina from 10.1.15 to 10.1.16 in /modules/owb [tomcat]

2024-01-16 Thread via GitHub
dependabot[bot] commented on PR #680: URL: https://github.com/apache/tomcat/pull/680#issuecomment-1893441318 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[PR] Update README.md [tomcat-tck]

2024-01-16 Thread via GitHub
fhanik opened a new pull request, #1: URL: https://github.com/apache/tomcat-tck/pull/1 Fix header typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Update README.md [tomcat-tck]

2024-01-16 Thread via GitHub
markt-asf merged PR #1: URL: https://github.com/apache/tomcat-tck/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898765701 No evidence provided to support claim of a leak. No leak observed when testing with profiler. No obvious reason that proposed patch would impact `UpgradeProcessor` instances (or anyth

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf closed pull request #683: Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread URL: https://github.com/apache/tomcat/pull/683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
imario42 commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898787616 @markt-asf : He described his findings in that tomcat-user post [https://lists.apache.org/thread/vyog0dyxwq3hlpjgt2vb1wkrxw6x2h1k](url) However, I do not know if his patch works.

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898853883 Thanks. The reference to the description on the users list helps. I'll look at this again. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-189414 The description of the problem and the analysis of the root cause (the BZ 66508 fix) is correct but the proposed fix is not. It will probably work the majority of the time but there is a t

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf closed pull request #683: Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread URL: https://github.com/apache/tomcat/pull/683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1899074074 Fixed and back-ported. Will be in the February releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Fix HTTP/2 support wording in HTTP docs [tomcat]

2024-01-18 Thread via GitHub
markt-asf merged PR #682: URL: https://github.com/apache/tomcat/pull/682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [PR] Fix HTTP/2 support wording in HTTP docs [tomcat]

2024-01-18 Thread via GitHub
markt-asf commented on PR #682: URL: https://github.com/apache/tomcat/pull/682#issuecomment-1899075283 Tx. I'll back-port this fix shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
imario42 commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1899854047 Thanks a lot @markt-asf for tackling and fixing it and @lbliangbin for the analysis. 👍😎 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] Update to use JakartaExpressionLanguage osgi.contract [tomcat]

2024-01-19 Thread via GitHub
pnicolucci opened a new pull request, #685: URL: https://github.com/apache/tomcat/pull/685 I opened: https://bz.apache.org/bugzilla/show_bug.cgi?id=66834 last year and upon looking at the latest M16 release of Expression Language 6.0 here: https://repo1.maven.org/maven2/org/apache/tomcat/to

[PR] native/common/jk_global.h: fix compilation on musl [tomcat-connectors]

2024-01-23 Thread via GitHub
ConiKost opened a new pull request, #8: URL: https://github.com/apache/tomcat-connectors/pull/8 On musl, sys/socketvar.h does not exist, so we need to make sure, not to use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Update to use JakartaExpressionLanguage osgi.contract [tomcat]

2024-01-25 Thread via GitHub
markt-asf commented on PR #685: URL: https://github.com/apache/tomcat/pull/685#issuecomment-1910670058 Thanks for reporting this. Looks like most of the embedded JARs got missed but EL was updated for embedded but not the standalone JAR in BZ 66834. I have a fix I'll push shortly that fi

Re: [PR] Update to use JakartaExpressionLanguage osgi.contract [tomcat]

2024-01-25 Thread via GitHub
markt-asf commented on PR #685: URL: https://github.com/apache/tomcat/pull/685#issuecomment-1910685730 Broader fix applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Update to use JakartaExpressionLanguage osgi.contract [tomcat]

2024-01-25 Thread via GitHub
markt-asf closed pull request #685: Update to use JakartaExpressionLanguage osgi.contract URL: https://github.com/apache/tomcat/pull/685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Workaround for JDK-8303866 makes migrated jar incompatible with latest JDK releases [tomcat-jakartaee-migration]

2024-01-28 Thread via GitHub
DanielThomas commented on issue #48: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/48#issuecomment-1913758414 Some improvements got made to this mitigation in later JDK releases, due to false positives in the detection, so I think this has been addressed upstream. -- T

Re: [PR] Csrf filter improvements [tomcat]

2024-02-01 Thread via GitHub
ChristopherSchultz merged PR #681: URL: https://github.com/apache/tomcat/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-02-01 Thread via GitHub
chenbiaoit commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1923029828 > Fixed and back-ported. Will be in the February releases. Hi @markt-asf,What channel can I use to know that this problem has been fixed? Thank you very much. -- This is an

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-02-02 Thread via GitHub
ChristopherSchultz commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1924044806 > > Fixed and back-ported. Will be in the February releases. > > Hi @markt-asf,What channel can I use to know that this problem has been fixed? Thank you very much. A

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-06 Thread via GitHub
Hakky54 commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1929460593 Hi team, is there any progress on this topic. Is there something what I can do on my side? Like backporting to other branches or anything else maybe? -- This is an automated message from t

Re: [PR] Add a fallback when people use Parameters class concurrently, to avoid lost params [tomcat]

2024-02-07 Thread via GitHub
markt-asf closed pull request #686: Add a fallback when people use Parameters class concurrently, to avoid lost params URL: https://github.com/apache/tomcat/pull/686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add a fallback when people use Parameters class concurrently, to avoid lost params [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #686: URL: https://github.com/apache/tomcat/pull/686#issuecomment-1931626326 WONTFIX - As per section 2.3.3.4 applications are responsible for accessing the request in a thread safe manner. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
markt-asf closed pull request #673: Added option to use custom SSLContext URL: https://github.com/apache/tomcat/pull/673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931686883 I was tempted to merge this but having reviewed the Tomcat code I think this is going to create problems - the main one being that Tomcat clears the SSLContext on Connector.stop() when `bi

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
Hakky54 commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931967568 Ah that is pity, I was looking forward to it. You have a better overview of the issues which it can cause to other functionalities. I was not aware of the lifecycle management and only focus

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931990842 I have some ideas on how to address this. I might have a fix for this soon that takes account of the lifecycle issues. -- This is an automated message from the Apache Git Service. To res

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1932089608 OK, it is in main. I'll back-port as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
Hakky54 commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1932206483 Thank you mate, I really appreciate this! Big kudos! 🥳 I am looking forward to the new release! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
Woellchen opened a new pull request, #687: URL: https://github.com/apache/tomcat/pull/687 URIs must be at least decoded in order to process sub-delims as defined in RFC 3986, because slashes and their encoded counterparts are equivalent when processing paths. Normalization before the proces

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
rmaucher closed pull request #687: Decode and normalize URIs before processing them URL: https://github.com/apache/tomcat/pull/687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
rmaucher commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932491567 URL processing and mapping has to follow a lot of rules from specifications to avoid inconsistencies which would be security issues. So this is one of them. Indeed creative encoding can c

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
Woellchen commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932522774 Could you please elaborate how a URI is not user input and how it can be prevented that a user calls a URI on a web application? I can't follow you. Relative paths are explicitly allowed

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932635647 Nope. Read the RFC again. Specifically 6.2.2.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
Woellchen commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932841669 Thanks for checking back! The section you are referring to does not really negate my statement however. If I get you right you are talking about this specific thing? > These URIs sh

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932891346 Nope, `%2F` is NOT equivalent to `/` in a URI as explained in section 2.2 of RFC 3986. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
Woellchen commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932961663 Alright, I guess I got this wrong then, thanks for your detailed explanations. In case others are wondering about the same issue I found two bugs for reference on prominent software pro

[GitHub] [tomcat] pbodnar commented on pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2023-05-13 Thread via GitHub
pbodnar commented on PR #354: URL: https://github.com/apache/tomcat/pull/354#issuecomment-1546656729 > Will this be backported to version 9 ? Actually, it seems like this was merged right into the version 9 branch - see 101476c3536ac09a105d0b603b2c51dd0f3770e9. So it is available sinc

[GitHub] [tomcat] pbodnar commented on pull request #22: [Bug 58242] Scanning jars in classpath to get annotations in parallel instead of synchronously

2023-05-13 Thread via GitHub
pbodnar commented on PR #22: URL: https://github.com/apache/tomcat/pull/22#issuecomment-1546657736 For anyone searching for this feature, this was implemented by #354 in the end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [tomcat] neo-ytx opened a new pull request, #617: #MessageBytes toString rollback

2023-05-18 Thread via GitHub
neo-ytx opened a new pull request, #617: URL: https://github.com/apache/tomcat/pull/617 1. I think toString method should not change the object's status. Because this method is used for return a String. Most people think they can get object's stringValue from this method, and will not chang

[GitHub] [tomcat] Chaohua95 opened a new pull request, #618: Update MERGE.txt

2023-05-18 Thread via GitHub
Chaohua95 opened a new pull request, #618: URL: https://github.com/apache/tomcat/pull/618 test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-u

[GitHub] [tomcat] Chaohua95 closed pull request #618: Update MERGE.txt

2023-05-18 Thread via GitHub
Chaohua95 closed pull request #618: Update MERGE.txt URL: https://github.com/apache/tomcat/pull/618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

[GitHub] [tomcat] aooohan commented on pull request #615: Add a reset method to release reference

2023-05-18 Thread via GitHub
aooohan commented on PR #615: URL: https://github.com/apache/tomcat/pull/615#issuecomment-1553931455 I've look at this, I think this change is a bit complicated. Resetting the channel while closing it is ok. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [tomcat] aooohan commented on pull request #615: Add a reset method to release reference

2023-05-18 Thread via GitHub
aooohan commented on PR #615: URL: https://github.com/apache/tomcat/pull/615#issuecomment-1553948162 I've done this and also cleared up reference elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] aooohan closed pull request #615: Add a reset method to release reference

2023-05-18 Thread via GitHub
aooohan closed pull request #615: Add a reset method to release reference URL: https://github.com/apache/tomcat/pull/615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [tomcat] aooohan commented on pull request #617: #MessageBytes toString rollback

2023-05-18 Thread via GitHub
aooohan commented on PR #617: URL: https://github.com/apache/tomcat/pull/617#issuecomment-1553952940 Hmm. A similar issue has been raised by other user before, look this https://lists.apache.org/list?us...@tomcat.apache.org:2023-3:openTelemetry Hope this helps. -- This is an automa

[GitHub] [tomcat] ledefe opened a new pull request, #619: Fix Bug 66602: not sending WINDOW_UPDATE when dataLength is ZERO on call SwallowedDataFramePayload

2023-05-18 Thread via GitHub
ledefe opened a new pull request, #619: URL: https://github.com/apache/tomcat/pull/619 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] aooohan commented on a diff in pull request #619: Fix Bug 66602: not sending WINDOW_UPDATE when dataLength is ZERO on call SwallowedDataFramePayload

2023-05-18 Thread via GitHub
aooohan commented on code in PR #619: URL: https://github.com/apache/tomcat/pull/619#discussion_r1198570360 ## webapps/docs/changelog.xml: ## @@ -125,6 +125,9 @@ defined in RFC 9218 rather than the one defined in RFC 7540. (markt) + +66602

[GitHub] [tomcat] aooohan commented on a diff in pull request #619: Fix Bug 66602: not sending WINDOW_UPDATE when dataLength is ZERO on call SwallowedDataFramePayload

2023-05-18 Thread via GitHub
aooohan commented on code in PR #619: URL: https://github.com/apache/tomcat/pull/619#discussion_r1198570360 ## webapps/docs/changelog.xml: ## @@ -125,6 +125,9 @@ defined in RFC 9218 rather than the one defined in RFC 7540. (markt) + +66602

[GitHub] [tomcat] aooohan closed pull request #619: Fix Bug 66602: not sending WINDOW_UPDATE when dataLength is ZERO on call SwallowedDataFramePayload

2023-05-18 Thread via GitHub
aooohan closed pull request #619: Fix Bug 66602: not sending WINDOW_UPDATE when dataLength is ZERO on call SwallowedDataFramePayload URL: https://github.com/apache/tomcat/pull/619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [tomcat] neo-ytx commented on pull request #617: #MessageBytes toString rollback

2023-05-19 Thread via GitHub
neo-ytx commented on PR #617: URL: https://github.com/apache/tomcat/pull/617#issuecomment-1554184173 Thanks a lot~. And I still have one question: Is the toString method changing object status a good behavior? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] DanielR-spec opened a new pull request, #620: Update ci.yml

2023-05-21 Thread via GitHub
DanielR-spec opened a new pull request, #620: URL: https://github.com/apache/tomcat/pull/620 update description file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [tomcat] markt-asf commented on pull request #620: Update ci.yml

2023-05-21 Thread via GitHub
markt-asf commented on PR #620: URL: https://github.com/apache/tomcat/pull/620#issuecomment-1556291534 Proposed change not correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [tomcat] markt-asf closed pull request #620: Update ci.yml

2023-05-21 Thread via GitHub
markt-asf closed pull request #620: Update ci.yml URL: https://github.com/apache/tomcat/pull/620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-uns

[GitHub] [tomcat] aooohan commented on pull request #617: #MessageBytes toString rollback

2023-05-21 Thread via GitHub
aooohan commented on PR #617: URL: https://github.com/apache/tomcat/pull/617#issuecomment-1556434703 > Thanks a lot~. And I still have one question: Is the toString method changing object status a good behavior? No, not a good behavior. This Class has been refactored before to solve s

[GitHub] [tomcat] aooohan closed pull request #617: #MessageBytes toString rollback

2023-05-21 Thread via GitHub
aooohan closed pull request #617: #MessageBytes toString rollback URL: https://github.com/apache/tomcat/pull/617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tomcat] alexkachanov opened a new pull request, #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-23 Thread via GitHub
alexkachanov opened a new pull request, #621: URL: https://github.com/apache/tomcat/pull/621 * fix and junit test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [tomcat] alexkachanov commented on a diff in pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-23 Thread via GitHub
alexkachanov commented on code in PR #621: URL: https://github.com/apache/tomcat/pull/621#discussion_r1203192504 ## java/org/apache/catalina/util/URLEncoder.java: ## @@ -40,6 +40,7 @@ public final class URLEncoder implements Cloneable { public static final URLEncoder DEFA

[GitHub] [tomcat] alexkachanov commented on a diff in pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-23 Thread via GitHub
alexkachanov commented on code in PR #621: URL: https://github.com/apache/tomcat/pull/621#discussion_r1203192773 ## java/org/apache/catalina/util/URLEncoder.java: ## @@ -95,6 +96,8 @@ public final class URLEncoder implements Cloneable { QUERY.addSafeCharacter('_');

[GitHub] [tomcat] alexkachanov commented on a diff in pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-23 Thread via GitHub
alexkachanov commented on code in PR #621: URL: https://github.com/apache/tomcat/pull/621#discussion_r1203195493 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1650,7 +1654,7 @@ protected InputStream renderXml(HttpServletRequest request, String contextPath,

[GitHub] [tomcat] alexkachanov commented on a diff in pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-23 Thread via GitHub
alexkachanov commented on code in PR #621: URL: https://github.com/apache/tomcat/pull/621#discussion_r1203195738 ## test/org/apache/catalina/servlets/TestDefaultServlet.java: ## @@ -578,6 +578,44 @@ public void testBug57601() throws Exception { tomcat.stop(); } +

[GitHub] [tomcat] markt-asf commented on pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-24 Thread via GitHub
markt-asf commented on PR #621: URL: https://github.com/apache/tomcat/pull/621#issuecomment-1560920115 (Ab)using the URLEncoder for this seems wrong. Tomcat has a class specifically for escaping values in content - `org.apache.tomcat.util.security.Escape`. The fix should use this. Fu

[GitHub] [tomcat] alexkachanov commented on pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-24 Thread via GitHub
alexkachanov commented on PR #621: URL: https://github.com/apache/tomcat/pull/621#issuecomment-1560963105 I was using URLEncoder class because it was used in original rewriteUrl method. So I wanted to keep it consistent and keep the changes it to minimum. I see that Escape.xml(String conten

[GitHub] [tomcat] alexkachanov commented on a diff in pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-24 Thread via GitHub
alexkachanov commented on code in PR #621: URL: https://github.com/apache/tomcat/pull/621#discussion_r1203991514 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1650,7 +1650,7 @@ protected InputStream renderXml(HttpServletRequest request, String contextPath,

[GitHub] [tomcat] markt-asf commented on pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-24 Thread via GitHub
markt-asf commented on PR #621: URL: https://github.com/apache/tomcat/pull/621#issuecomment-1561136901 Thanks for the PR. Applied manually with a few tweaks (e.g. CheckStyle config). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [tomcat] markt-asf closed pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-24 Thread via GitHub
markt-asf closed pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'" URL: https://github.com/apache/tomcat/pull/621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [tomcat] alexkachanov opened a new pull request, #622: Bug 66618: add longDate attribute to XML in directory listing

2023-05-28 Thread via GitHub
alexkachanov opened a new pull request, #622: URL: https://github.com/apache/tomcat/pull/622 * implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [tomcat] markt-asf opened a new pull request, #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-30 Thread via GitHub
markt-asf opened a new pull request, #623: URL: https://github.com/apache/tomcat/pull/623 This is untested. If accepted, this will need some documentation updates. The purpose of this draft is to obtain early feedback on the approach. -- This is an automated message from the

[GitHub] [tomcat] rmaucher commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-30 Thread via GitHub
rmaucher commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1568565624 That seems like the better way to do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomcat] rmannibucau commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-30 Thread via GitHub
rmannibucau commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1568571457 * Is there a plan for the map eviction? background thread? * How does it work in a cluster since counter is local, should it be a cluster event? -- This is an automated message from

[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-30 Thread via GitHub
markt-asf commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1568591682 Map eviction is handled in the finally block. That we can only make this work on a single node is why Rémy is proposing that we remove/deprecate this Valve. -- This is an automate

[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-31 Thread via GitHub
markt-asf commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570461148 I haven't deprecated this yet. I'm waiting on input from the OP of BZ 66513 and/or @jfclere as the original author of the Valve in case there is a use case I have missed. -- This is an

[GitHub] [tomcat] rmaucher commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-31 Thread via GitHub
rmaucher commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570477734 Very clean overall, esp the javadoc update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [tomcat] markt-asf merged pull request #622: Bug 66618: add longDate attribute to XML in directory listing

2023-05-31 Thread via GitHub
markt-asf merged PR #622: URL: https://github.com/apache/tomcat/pull/622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] jfclere commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-31 Thread via GitHub
jfclere commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570527918 @markt-asf that looks better that what was there ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-31 Thread via GitHub
markt-asf commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570534844 > @markt-asf that looks better that what was there ;-) Thanks. Can you recall if there was a use case for this Valve on a single node? Or was it always intended for use behind

[GitHub] [tomcat] jfclere commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-31 Thread via GitHub
jfclere commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570546656 trying to remember... I guess I wrote to save and restore session information for a SINGLE tomcat node. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [tomcat] markt-asf merged pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-06-01 Thread via GitHub
markt-asf merged PR #623: URL: https://github.com/apache/tomcat/pull/623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] michael-o opened a new pull request, #624: Add ContextNamingInfoListener

2023-06-09 Thread via GitHub
michael-o opened a new pull request, #624: URL: https://github.com/apache/tomcat/pull/624 A listener which creates context naming information environment entries. This is something which I have been using for years at work. It suited for all components which dot not have access to Tom

[GitHub] [tomcat] rmaucher commented on pull request #624: Add ContextNamingInfoListener

2023-06-09 Thread via GitHub
rmaucher commented on PR #624: URL: https://github.com/apache/tomcat/pull/624#issuecomment-1584598111 I think I saw this feature before in the past. No problem, although emptyOnRoot may not be very useful, so I'm not sure why this is a good idea to change things from the actual values by de

[GitHub] [tomcat] michael-o commented on pull request #624: Add ContextNamingInfoListener

2023-06-09 Thread via GitHub
michael-o commented on PR #624: URL: https://github.com/apache/tomcat/pull/624#issuecomment-1584626395 > I think I saw this feature before in the past. No problem, although emptyOnRoot may not be very useful, so I'm not sure why this is a good idea to change things from the actual values by

[GitHub] [tomcat] michael-o commented on pull request #624: Add ContextNamingInfoListener

2023-06-12 Thread via GitHub
michael-o commented on PR #624: URL: https://github.com/apache/tomcat/pull/624#issuecomment-1587322206 @rmaucher I have now applied the default context behavior. Please have a look again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [tomcat] rmaucher commented on pull request #624: Add ContextNamingInfoListener

2023-06-12 Thread via GitHub
rmaucher commented on PR #624: URL: https://github.com/apache/tomcat/pull/624#issuecomment-1587415361 No problem. I don't really mind the default value, it could go either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [tomcat] bekionel opened a new pull request, #625: Remove transport.bio from catalina-tribes.jar.tmp.bnd

2023-06-12 Thread via GitHub
bekionel opened a new pull request, #625: URL: https://github.com/apache/tomcat/pull/625 Since package org.apache.catalina.tribes.transport.bio was deprecated in tomcat 10, https://tomcat.apache.org/tomcat-9.0-doc/api/org/apache/catalina/tribes/transport/bio/package-summary.html , referenc

[GitHub] [tomcat] bekionel opened a new pull request, #626: Remove transport.bio from catalina-tribes.jar.tmp.bnd

2023-06-12 Thread via GitHub
bekionel opened a new pull request, #626: URL: https://github.com/apache/tomcat/pull/626 Since package org.apache.catalina.tribes.transport.bio was deprecated in tomcat 10, https://tomcat.apache.org/tomcat-9.0-doc/api/org/apache/catalina/tribes/transport/bio/package-summary.html , referenc

[GitHub] [tomcat] bekionel opened a new pull request, #627: Remove transport.bio from catalina-tribes.jar.tmp.bnd

2023-06-12 Thread via GitHub
bekionel opened a new pull request, #627: URL: https://github.com/apache/tomcat/pull/627 Since package org.apache.catalina.tribes.transport.bio was deprecated in tomcat 10, https://tomcat.apache.org/tomcat-9.0-doc/api/org/apache/catalina/tribes/transport/bio/package-summary.html , referenc

[GitHub] [tomcat] michael-o commented on pull request #624: Add ContextNamingInfoListener

2023-06-12 Thread via GitHub
michael-o commented on PR #624: URL: https://github.com/apache/tomcat/pull/624#issuecomment-1588662647 > No problem. I don't really mind the default value, it could go either way. Great, if there aren't any objections I will happily merge later this day. -- This is an automated mess

[GitHub] [tomcat] markt-asf commented on pull request #624: Add ContextNamingInfoListener

2023-06-13 Thread via GitHub
markt-asf commented on PR #624: URL: https://github.com/apache/tomcat/pull/624#issuecomment-1588774994 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tomcat] michael-o merged pull request #624: Add ContextNamingInfoListener

2023-06-13 Thread via GitHub
michael-o merged PR #624: URL: https://github.com/apache/tomcat/pull/624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] sheikhoo opened a new pull request, #628: Change style

2023-06-13 Thread via GitHub
sheikhoo opened a new pull request, #628: URL: https://github.com/apache/tomcat/pull/628 Just change some CSS style ![image](https://github.com/apache/tomcat/assets/11958698/44311e25-49b2-428d-89e4-5c0ace907d95) -- This is an automated message from the Apache Git Service. To re

[GitHub] [tomcat] markt-asf commented on a diff in pull request #628: Change style

2023-06-13 Thread via GitHub
markt-asf commented on code in PR #628: URL: https://github.com/apache/tomcat/pull/628#discussion_r1228412571 ## webapps/host-manager/css/manager.css: ## @@ -15,7 +15,7 @@ * limitations under the License. */ -body { + body { font-family: Tahoma, Arial, sans-serif; Re

[GitHub] [tomcat] markt-asf commented on pull request #626: Remove transport.bio from catalina-tribes.jar.tmp.bnd

2023-06-13 Thread via GitHub
markt-asf commented on PR #626: URL: https://github.com/apache/tomcat/pull/626#issuecomment-1589658187 Redundant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [tomcat] markt-asf closed pull request #626: Remove transport.bio from catalina-tribes.jar.tmp.bnd

2023-06-13 Thread via GitHub
markt-asf closed pull request #626: Remove transport.bio from catalina-tribes.jar.tmp.bnd URL: https://github.com/apache/tomcat/pull/626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] markt-asf closed pull request #627: Remove transport.bio from catalina-tribes.jar.tmp.bnd

2023-06-13 Thread via GitHub
markt-asf closed pull request #627: Remove transport.bio from catalina-tribes.jar.tmp.bnd URL: https://github.com/apache/tomcat/pull/627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] markt-asf commented on pull request #627: Remove transport.bio from catalina-tribes.jar.tmp.bnd

2023-06-13 Thread via GitHub
markt-asf commented on PR #627: URL: https://github.com/apache/tomcat/pull/627#issuecomment-1589658475 Redundant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [tomcat] markt-asf merged pull request #625: Remove transport.bio from catalina-tribes.jar.tmp.bnd

2023-06-13 Thread via GitHub
markt-asf merged PR #625: URL: https://github.com/apache/tomcat/pull/625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] markt-asf commented on pull request #625: Remove transport.bio from catalina-tribes.jar.tmp.bnd

2023-06-13 Thread via GitHub
markt-asf commented on PR #625: URL: https://github.com/apache/tomcat/pull/625#issuecomment-1589667642 Back-ported to 10.1.x as the package was removed in 10.1.x. Not back-ported further as the package is still present in 9.0.x and earlier. -- This is an automated message from the Apache

[GitHub] [tomcat] sheikhoo commented on pull request #628: Change style

2023-06-13 Thread via GitHub
sheikhoo commented on PR #628: URL: https://github.com/apache/tomcat/pull/628#issuecomment-1590358538 I removed any unnecessary spaces and utilized 4 spaces instead of 1 tab. Additionally, I updated the style of the buttons. -- This is an automated message from the Apache Git Service. To

<    4   5   6   7   8   9   10   11   12   13   >