Re: [2/3] tomee git commit: EOL commit

2015-11-18 Thread Romain Manni-Bucau
got the same, no idea why - I am configured for unix eol. Just wanted to push a commit without logic change before pushing actual logic. Andy started a thread on infra about that, not yet sure the outcome to be honest. Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber 2015

Re: [2/3] tomee git commit: EOL commit

2015-11-18 Thread Daniel Cunha
I've the same problem here. On Wed, Nov 18, 2015 at 10:21 PM, Thiago Veronezi wrote: > Hey Romain, > > What is this commit about? Removing windows line endings? > Now when I pull the source code, my local git says I have changed files > that I never touched. Am I missing a config locally? > > []

Re: [2/3] tomee git commit: EOL commit

2015-11-18 Thread Thiago Veronezi
Hey Romain, What is this commit about? Removing windows line endings? Now when I pull the source code, my local git says I have changed files that I never touched. Am I missing a config locally? []s, Thiago On Wed, Nov 18, 2015 at 3:18 PM, wrote: > http://git-wip-us.apache.org/repos/asf/tomee/

Re: ActiveMQ connection wrapper

2015-11-18 Thread Romain Manni-Bucau
well pushed few enhancements all around this thing on master but it was really around so would be great to first know if it helps and then validate the leaking thread is due to AMQ missing a catch ( https://issues.apache.org/jira/browse/AMQ-6051 ) If that is the case we will just fix and upgrade A

Re: ActiveMQ connection wrapper

2015-11-18 Thread agumbrecht
The current commit would need more work to complete. However, I feel a revert coming on. Is there something we can actually do without requiring a new AMQ version? The current wrapper seems to resolve the issue on testing the dangling thread shutdown, but needs more work to cope with Topic and Que

Re: ActiveMQ connection wrapper

2015-11-18 Thread Romain Manni-Bucau
Geronimo connector already does that with its connections proxying. There is a phantom tracker IIRC. Do you know in which case we would leak connections? Last time I checked it was only possible if missing a close which is a programming miss. Is that the case we want to deal with? Le 18 nov. 2015

Re: Setting Realm name for Tomee application

2015-11-18 Thread Romain Manni-Bucau
Hmm Let step back Realm#getName is the realm instance name. It is a name for tomcat. You get https://github.com/apache/tomee/blob/master/tomee/tomee-catalina/src/main/java/org/apache/tomee/catalina/TomcatWebAppBuilder.java#L395 The realm name feom web.xml is the LoginConfig one https://github.co

Re: Setting Realm name for Tomee application

2015-11-18 Thread ereshgorantla
Thanks Romain I tried to get realmName from StandardContext and got the realm name as /tomee which is not my project name . I am in an assumption that Tomee will create application's web context as its realm name . Correct me If I am wrong . If it is correct . I has to get realm name as / not /tome

Re: ActiveMQ connection wrapper

2015-11-18 Thread agumbrecht
This seems to be the best candidate location to wrap the ConnectionFactory: org/apache/openejb/InjectionProcessor.java:243 Adding if(ConnectionFactory.class.isInstance(value)){value = ..wrapper..} would work here. However, is there a way to 'event' the wrapping without too much overhead? - I'm t

ActiveMQ connection wrapper

2015-11-18 Thread Andy Gumbrecht
Looking for suggestions as to where and how it could be best to wrap any connections from AMQ. We need to do this in order to ensure we can kill connections on a server shutdown. Basically anywhere this gets injected there needs to be a wrapper returned in it's place. public interface Connec