Re: Mass cleanup

2016-03-12 Thread Jean-Louis Monteiro
+1 let's have the analysis tool set and have a base line. Then as Mark mentioned work on the rule set and fix. Intellij warnings are sometimes totally irrelevant. Or just I don't like the code style. Obviously totally personal but just to mention that I'm not convinced by a massive changes. Le 1

Re: Mass cleanup

2016-03-12 Thread Romain Manni-Bucau
+0 if anything is justified and motivated. -1 to only run after making tools green Le 12 mars 2016 20:56, "Raquel Pau Fernández" a écrit : > Hi, > > In case of using Sonar, walkmod (walkmod.com - an open source tool) could > help you to automatically fix some sonar violations. The Github url of t

Re: Mass cleanup

2016-03-12 Thread Raquel Pau Fernández
Hi, In case of using Sonar, walkmod (walkmod.com - an open source tool) could help you to automatically fix some sonar violations. The Github url of the sonar plugin is https://github.com/walkmod/walkmod-sonar-plugin Raquel 2016-03-12 20:49 GMT+01:00 Mark Struberg : > yes, fear so as well. > Wh

Re: Mass cleanup

2016-03-12 Thread Mark Struberg
yes, fear so as well. What _would_ help is to enable sonar for TomEE? https://analysis.apache.org/dashboard/index/12686 And then go through the rules which make the most sense and clean that parts up? LieGrue, strub > Am 11.03.2016 um 19:44 schrieb Romain Manni-Bucau : > > Then -1 for code "

Fwd: svn commit: r1734638 - /tomee/javaee-api/trunk/pom.xml

2016-03-12 Thread Romain Manni-Bucau
Hi Andy Can you give us some inputs about this change please? -- Message transféré -- De : Date : 11 mars 2016 23:20 Objet : svn commit: r1734638 - /tomee/javaee-api/trunk/pom.xml À : Cc : Author: andygumbrecht Date: Fri Mar 11 22:20:16 2016 New Revision: 1734638 URL: http://sv