Re: [Discuss] Review-than-commit 3 month trial

The main issue here is that both new and existing developers on the project need breathing space in order to thrive and grow. The period between releases is for everyone and not just the few. It is only 99.99% OK for one or two individuals. Everyone else seems to be suffering behind closed doors o

Re: Site and "documentation" usage

Ok, saw Andy did a similar comment on github so probably let's reverse the question. Anyone feeling like me it is a passthrough? (if not under 1 day think we can "close it" and just push it in prod) Romain Manni-Bucau @rmannibucau | Blog

RE: Site and "documentation" usage

For me the Documentation menu item is very good; it shows at the top level that the TomEE project has documentation. Also like the content of the Documentation page, it hits 'How to Configure', 'IDEs' and 'Testing' upfront & early which should give a good impression on people considering upta

Re: Building a Static Discovery Cluster

looks like docker dns is not working that well and registration fails - or the startup is not ordered properly but result lead to the same. Often saw docker-compose having a small bash loop to wait for the host/port being accessible. Maybe that's what you need (yes it is ugly) Romain Manni-Bucau

Re: Building a Static Discovery Cluster

I've got the log and put here: https://www.dropbox.com/s/yxt3ym1ucv1hwb3/catalina.2017-07-05.log?dl=0 Twitter: @elderjava Blog: http://eldermoraes.com 2017-07-05 18:56 GMT-03:00 Romain Manni-Bucau : > interesting, would be great to have debug log of that clust

Re: Building a Static Discovery Cluster

interesting, would be great to have debug log of that clustering part (something like org.apache.catalina.tribes.level = FINE), think the static members are actually excluded of the cluster reading this error Romain Manni-Bucau @rmannibucau | Blog

Re: Building a Static Discovery Cluster

Hmm, why not the tcpfailuredetector as a root (/>) instead of wrapping the static membership one? Done e got this error: 05-Jul-2017 21:51:32.845 WARNING [GroupChannel-Heartbeat[Catalina-Channel]-1] sun.reflect.NativeMethodAccessorImpl.invoke Unable to perform heartbeat on the TcpFailureDetector.

Re: Building a Static Discovery Cluster

Hmm, why not the tcpfailuredetector as a root (/>) instead of wrapping the static membership one? Also did you manage to get debug log of tomcat cluster? it helps a lot in general Romain Manni-Bucau @rmannibucau | Blog | O

Re: Building a Static Discovery Cluster

Did it. No errors found. If you want to have a look at the server.xml. Also I've undone the changes I've made before. https://www.dropbox.com/s/p3iknyku2rb3f3w/server.xml?dl=0 Twitter: @elderjava Blog: http://eldermoraes.com 2017-07-05 17:08 GMT-03:00 Romain Ma

Re: Site and "documentation" usage

yep, the usage of adoc was kind of not random and to prepare an all in one bundle we can easily add in the current build pipeline. Thinking to my issue with that "doc" word I start to think we could compute a small search engine (offline/client only) at build time and just have an input box on the

Re: Site and "documentation" usage

Thanks for the link. I would like to specifically encourage Ivan as a new contributor to present his changes here, and receive feedback directly from the community rather than via a proxy. I think that will enable him to grow as a contributor, and hopefully some day, potential committer. I know he'

Re: Site and "documentation" usage

very close http://people.apache.org/~rmannibucau/ivan/ can be used (think Ivan did some minor adjustments after but overall idea is here if I'm not mistaken) Romain Manni-Bucau @rmannibucau | Blog | Old Blog

Re: Site and "documentation" usage

Ivan - did you have some luck getting that staged somewhere? I'd love to take a look and give some feedback. Cheers Jon On Wed, Jul 5, 2017 at 10:01 PM, Romain Manni-Bucau wrote: > Hi guys > > With Ivan's work I d like to get your feeling on "Documentation" as an > entry menu. > > Personally I

Re: [Discuss] Review-than-commit 3 month trial

Are you referring to the changes in the "Suffocating development environment" thread, or something else? In my view, the patch Andy applied last week had very limited review (1 person), and the revert had no review. We've seen contributions come in through GitHub PRs (which is great), but also appl

Site and "documentation" usage

Hi guys With Ivan's work I d like to get your feeling on "Documentation" as an entry menu. Personally I feel it weird since almost all is supposed to be doc (like having "Website") but wonder if it is a language/habit thing or if you share it too. Any thoughts?

Re: Building a Static Discovery Cluster

Gmail formatting doesnt help much but think it can miss some closing tags. Autoformat it in an ide, it should show it. Le 5 juil. 2017 21:28, "Elder Moraes" a écrit : > Actually I can't... :-( > > But if you could point me where I should look, maybe I can figure it out. > > Is that code that I'v

Re: [Discuss] Review-than-commit 3 month trial

I brought up RTC a few months ago as a way to get more dev list discussion, more people aware of the code going in and higher participation overall. The commit/revert ping-pong we had last week seemed to revive the topic. I haven’t seen us properly applying RTC, which requires 3 +1s and no -1s.

Re: Building a Static Discovery Cluster

Actually I can't... :-( But if you could point me where I should look, maybe I can figure it out. Is that code that I've sent here correct? No issue? Did I put the StaticMembershipInterceptor at right place? Twitter: @elderjava Blog: http://eldermoraes.com 20

Re: Building a Static Discovery Cluster

Do you think you can do a setup without docker? Would be easier to check but sounds like a config issue. Le 5 juil. 2017 21:18, "Elder Moraes" a écrit : > If you are talking about removing the McastService, I've already done and > didn't work. The cluster still works as a dynamic one. > > > Twit

Re: Building a Static Discovery Cluster

If you are talking about removing the McastService, I've already done and didn't work. The cluster still works as a dynamic one. Twitter: @elderjava Blog: http://eldermoraes.com 2017-07-05 16:08 GMT-03:00 Romain Manni-Bucau : > Think you ask to find node with th

Re: Building a Static Discovery Cluster

Think you ask to find node with this service so it behaves as configured. Remove it for static clusters. Le 5 juil. 2017 20:43, "Elder Moraes" a écrit : Sorry, I don't get it... Twitter: @elderjava Blog: http://eldermoraes.com 2017-07-05 15:38 GMT-03:00 Romai

PMD

I note there's a couple of PMD issues on the 1.7.x. build - I'm on it. Jon

Re: Building a Static Discovery Cluster

Sorry, I don't get it... Twitter: @elderjava Blog: http://eldermoraes.com 2017-07-05 15:38 GMT-03:00 Romain Manni-Bucau : > (disclaimer: read quickly on phone so can be wrong) > > seems you use membership discovery, can't it be simply that? > > 2017-07-05 20:07

Re: Building a Static Discovery Cluster

(disclaimer: read quickly on phone so can be wrong) seems you use membership discovery, can't it be simply that? 2017-07-05 20:07 GMT+02:00 Elder Moraes : > Sure! Here they are: > > Name: Catalina:type=Cluster,component=Member,name="tcp://{172, 17, 0, > 3}:4000" > modelerType: org.apache.tomcat.

Re: Building a Static Discovery Cluster

Sure! Here they are: Name: Catalina:type=Cluster,component=Member,name="tcp://{172, 17, 0, 3}:4000" modelerType: org.apache.tomcat.util.modeler.BaseModelMBean memberAliveTime: 59124 suspect: false udpPort: -1 local: false securePort: -1 hostname: {172, 17, 0, 3} port: 4000 serviceStartTime: 0 read

Re: [Discuss] Review-than-commit 3 month trial

As far as I recall the original issue was initially caused by applying a PR. That means we had this very issue with a commit which had RTC in place. Draw your own conclusions... LieGrue, strub > Am 05.07.2017 um 14:26 schrieb Romain Manni-Bucau : > > Hmm, let put it in a raw way: can we skip

Re: Building a Static Discovery Cluster

Hmm, can you have a look into JMX on some tomee instances to check the tomcat cluster config please? Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: Building a Static Discovery Cluster

Hi Romain, Actually my problem is right the opposite (I forget to mention - sorry!): I'm trying to use a static discovery, but it is working as a dynamic one. In other words, when I run another container (say, host4) it joins into the cluster. Cheers, Twitter: @elderjava

Re: Building a Static Discovery Cluster

Hi Elder, are all the binding address (host)/ports opened between your containers? (can you telnet between them) do you use docker-compose to create the cluster (it helps a bit)? did you activate the debug log of tomcat clustering? it generally helps Romain Manni-Bucau @rmannibucau

Building a Static Discovery Cluster

Hi everyone! Could you help me? I've been struggling to build a cluster using Docker and Tomee based on the static discovery membership. Docker image: tomee:8-jre-7.0.3-plume Please refer to the "Cluster" node described bellow. Could you point me what is wrong?

Re: [Discuss] Review-than-commit 3 month trial

Hmm, let put it in a raw way: can we skip the asf list on these discussions? Literally means can be use the way everybody uses for RTC, ie github PRs *only*. If not I don't see the point to use it since contributors we got are mainly github/jira and I think it is natural as a contributor to use the

Re: TOMEE-1974 - lost commits

2017-07-05 12:56 GMT+02:00 Jonathan Gallimore : > I'll recheck whether passing a specific basic authorization header works, > if it does, I'll close the PR and follow up here. If it doesn't, I'll > follow up with more specific details. > > The code change wasn't made for no reason though, which w

Re: [Discuss] Review-than-commit 3 month trial

As I see it, while the recent issue with the documentation was probably the trigger for discussing RTC on dev@, I think the general idea is actually to get more discussion going on around features and fixes, and to encourage more interaction in the review process. We are struggling as a community i

Re: TOMEE-1974 - lost commits

I'll recheck whether passing a specific basic authorization header works, if it does, I'll close the PR and follow up here. If it doesn't, I'll follow up with more specific details. The code change wasn't made for no reason though, which would suggest that it doesn't work in the desired way. There

Re: TOMEE-1974 - lost commits

Hi Jon, did you consider making it working without any code change? it does AFAIK. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn <

TOMEE-1974 - lost commits

Hi A few months back we introduced some functionality to allow the client to authenticate using a basic auth header. https://issues.apache.org/jira/browse/TOMEE-1974. This was merged, but subsequently lost when a script was accidentally executed against the wrong branch, and a git reset --hard HEA

Re: [Discuss] Review-than-commit 3 month trial

2017-07-05 10:00 GMT+02:00 Gurkan Erdogdu : > Romain@Gurkan: concretely nothing changed factually since we discussed > it and concluded we can't pay the overhead at the moment so why pushing > it?I looked at the commit history from github (https://github.com/apache/ > tomee/graphs/contributors

Re: [Discuss] Review-than-commit 3 month trial

Romain@Gurkan: concretely nothing changed factually since we discussed it and concluded we can't pay the overhead at the moment so why pushing it?I looked at the commit history from github (https://github.com/apache/tomee/graphs/contributors). Only some couple of members provide contributio

Re: [Discuss] Review-than-commit 3 month trial

@Gurkan: concretely nothing changed factually since we discussed it and concluded we can't pay the overhead at the moment so why pushing it? Concretely the issue was very particular in term of process cause affecting almost directly our "prod" versus our project source doesn't and we can therefore