Re: [DISCUSS] Extract examples into own git repo

Hi Mark ++1 for this. Examples must not be a test suite, and it is a great idea to separate them from the main source code. It must be independently build and execute from main TomEE codebase. Best Gurkan On Wed, Jun 27, 2018 at 9:48 AM, Mark Struberg wrote: > Hi folks! > > While trying to relea

Re: [DISCUSS] Extract examples into own git repo

Le mer. 27 juin 2018 à 11:59, Mark Struberg a écrit : > The multiple test run makes perfect sense. > The second round of test is performed against a clean checkout from the > tag. > That makes sure that the build is really reproducible. That's actually a > HUGE win and we introduced this in maven

Re: [DISCUSS] Extract examples into own git repo

The multiple test run makes perfect sense. The second round of test is performed against a clean checkout from the tag. That makes sure that the build is really reproducible. That's actually a HUGE win and we introduced this in maven for good reasons! > What do you propose? Assume we split in 2

Re: [DISCUSS] Extract examples into own git repo

Le mer. 27 juin 2018 à 11:22, Mark Struberg a écrit : > Thanks for the feedback! > > > >> * they break the maven-release-plugin, because they don't use the same > >> version > >> > > > > Moving it to another repo will not solve it since they must be > independent > > and not have a common parent

Fwd: [DISCUSS] Extract examples into own git repo

Thanks for the feedback! >> * they break the maven-release-plugin, because they don't use the same >> version >> > > Moving it to another repo will not solve it since they must be independent > and not have a common parent to be copiable and runnable without > dependencies. Exactly that missin

Re: [DISCUSS] Extract examples into own git repo

Hi Mark, think we already discuss it somewhere else but wrote again the points inline if it has been missed Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

[DISCUSS] Extract examples into own git repo

Hi folks! While trying to release TomEE-7.0.5 I figured that the Examples as part of the TomEE core project are really counter productive. * they break the maven-release-plugin, because they don't use the same version * They pollute the build (samples alone take 15 minutes of our build), which