Re: TomEE 7.1 with MP

2018-08-02 Thread David Blevins
> On Jul 26, 2018, at 3:18 AM, Mark Struberg wrote: > > Yes, the following steps are now up to get done: > > 1.) Move the current master to a tomee-7.0.x branch > 2.) Create a new tomee-7.1.x branch, upgrade to Java8 and add MicroProfile > 2.) Move the tomee-8.x branch to master and get stuff ro

Re: TomEE 7.1 with MP

2018-08-02 Thread David Blevins
> On Jul 29, 2018, at 8:14 AM, Gurkan Erdogdu wrote: > > From my perspective, this is not realistic. You are releasing the first > version for JDK 8, MP 1 after getting 8.0 branch to master, and at the > first release you are saying that this is production ready. At least, we > will need to let u

Re: TomEE 8 Jsonb Provider

2018-08-02 Thread Romain Manni-Bucau
if we want to provide a flag yes but since we'll break as much not providing the lib (it is as hard to set the flag than to add a lib) and since staying small and minimalistic always has been something very core of TomEE I start to think we should just drop it and well document that. Romain Manni-

Re: TomEE 8 Jsonb Provider

2018-08-02 Thread Roberto Cortez
If we want to have a flag that allows the user to return to the old provider, don't we need to keep johnson-jaxrs? I'm in favour of adding a simple flag that switches between old / new. Something like openejb.jaxrs.legacy.providers = true / false. On Thursday, August 2, 2018, 4:42:13 PM GMT+

Re: TomEE 8 Jsonb Provider

2018-08-02 Thread Romain Manni-Bucau
Sure, the target is quite clear I think, but we should mitigate the side effect for our users, this is why a flag can be worth it. That said we can drop johnzon-jaxrs going to johnzon-jsonb so not sure it will be better than when we dropped jettison. Only positive thing is the default serialization

Re: TomEE 8 Jsonb Provider

2018-08-02 Thread Roberto Cortez
Maybe we need some more opinions. I don't know how strong is the integration between json-b and jax-rs in EE8, but I would expect for response objects annotated with jsonb annotations to be respected and have this working OOTB in the standard server without additional configuration. I wonder i

Re: TomEE 8 Jsonb Provider

2018-08-02 Thread Romain Manni-Bucau
Yep, or we just do it OOTB for the MP distro in a first step. I don't have any strong opinion since in all cases we'll break some users :(. Romain Manni-Bucau @rmannibucau | Blog | Old Blog |

Re: TomEE 8 Jsonb Provider

2018-08-02 Thread Roberto Cortez
I understand. I think we need to do it, since I've found a couple of issues with the MP TCK using models with Jsonb annotations that were not being applied due to the missing provider. And Jsonb is also part of EE 8, so I believe this should be the default behaviour. To return to the old behavi

Re: TomEE 8 Jsonb Provider

2018-08-02 Thread Romain Manni-Bucau
Hi Roberto, You can't get this one and the old johnzon mapper at the same time (both will conflict). I'm all for migrating to jsonb but note it will break end users of TomEE 7 so we should IMHO ensure the way to configure back to the old behavior globally (without modifying the app) is well docume

TomEE 8 Jsonb Provider

2018-08-02 Thread Roberto Cortez
Hi, I was wondering if it will be ok to add the Johnzon Jsonb Provider to the default providers list? The dependency is already in the project, it was just commented out with a "java 8 only". I guess this was pre TomEE 8. If this is ok, here is a PR that uncomments the dependency and add the org