Re: MicroProfile JWT 1.1

Hi Jon, yes and no, idea is to be fast and for all producers it works except the principal which is broken anyway in CDI 1.x so guess this was not fixed in CDI 2 (tomee 8) we can impl it this way:

Re: MicroProfile JWT 1.1

Here's a question, probably for Mark or Romain. If I turn the proxy *off* in org.apache.webbeans.component.PrincipalBean, I'm finding that I get the wrong principal injected sometimes. Specifically, I get the whatever is on the proxyInstance field here:

Re: Shutdown issues with ManagedScheduledExecutorService

Did you try a semaphore waiting all tasks are done? It likely also needs a boolean to prevent new submissions before starting waiting for completion. Side note: @Schedule sounds not bad for your use case ;) Le lun. 29 oct. 2018 20:55, ChrisOwens a écrit : > This is with TomEE plus 7.0.5 > >

Shutdown issues with ManagedScheduledExecutorService

This is with TomEE plus 7.0.5 I'm getting /Bean ... has been undeployed/ exception on shutdown, which is preventing orderly cleanup. The issue appears to be that a POJO implementing Runnable is scheduled for periodic execution; that POJO was created with a reference to a @Stateless bean; and the

Shutdown issues with ManagedScheduledExecutorService

This is with TomEE plus 7.0.5 I'm getting /Bean ... has been undeployed/ exception on shutdown, which is preventing orderly cleanup. The issue appears to be that a POJO implementing Runnable is scheduled for periodic execution; that POJO was created with a reference to a @Stateless bean; and the

Shutdown issues with ManagedScheduledExecutorService

This is with TomEE plus 7.0.5 I'm getting /Bean ... has been undeployed/ exception on shutdown, which is preventing orderly cleanup. The issue appears to be that a POJO implementing Runnable is scheduled for periodic execution; that POJO was created with a reference to a @Stateless bean; and the

Re: TOMEE-2253 - tomee.sh -version not working properly with Java 11

We should write a test case for both of these, and agree on them. I'd like to be able to merge this in with confidence, and without the tests I don't see how we can do that. Jon On Mon, Oct 29, 2018 at 3:35 PM Romain Manni-Bucau wrote: > Hi Daniel, > > the point is that this code is reused in

Re: TOMEE-2253 - tomee.sh -version not working properly with Java 11

Hi Daniel, the point is that this code is reused in several places so we must be as clean as we can, here the cases I had in mind: 1. reused main in another main (so an app calls the main): here the pitfall is that the property openejb.classloader.first.disallow-system-load is not resetted and

Re: TOMEE-2253 - tomee.sh -version not working properly with Java 11

Hi, I updated the PR with tests! Em seg, 29 de out de 2018 às 08:27, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > I saw your note on the PR regarding Romain's feedback. > > For visibility here, Romain is querying whether this patch will cause an > issue with folks calling the

2 JIRAs submitted when using Java 11 (TomEE 7.1.0 Plus and TomEE 8.0.0-M1 microprofile)

Hello, Issue TOMEE-2263 - Copy a war in the webapps folder is not taken into account using Java 11 Issue TOMEE-2264 - Unable to deploy this war on TomEE Plus using Java 11 Could you please look

[GitHub] tomee pull request #176: TOMEE-2253 - tomee.sh -version not working properly...

Github user jgallimore commented on a diff in the pull request: https://github.com/apache/tomee/pull/176#discussion_r228923707 --- Diff: tomee/apache-tomee/src/test/java/org/apache/tomee/TomEECliIT.java --- @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee pull request #176: TOMEE-2253 - tomee.sh -version not working properly...

Github user jgallimore commented on a diff in the pull request: https://github.com/apache/tomee/pull/176#discussion_r228923550 --- Diff: tomee/apache-tomee/src/test/java/org/apache/tomee/TomEECliIT.java --- @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee pull request #176: TOMEE-2253 - tomee.sh -version not working properly...

Github user jgallimore commented on a diff in the pull request: https://github.com/apache/tomee/pull/176#discussion_r228922983 --- Diff: tomee/apache-tomee/src/test/java/org/apache/tomee/TomEECliIT.java --- @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/176 I think adding the test anyway is a good call. ---

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 btw, it is what we already doing on tomee.sh: `"$_RUNJAVA" $DEBUG $LOGGING_MANAGER -Dopenejb.base="$CATALINA_BASE" -cp "$CLASSPATH" org.apache.openejb.cli.Bootstrap "$@"`

Re: TOMEE-2253 - tomee.sh -version not working properly with Java 11

I saw your note on the PR regarding Romain's feedback. For visibility here, Romain is querying whether this patch will cause an issue with folks calling the CLI with a custom classpath using `java -cp ...` under Java 8. I'd suggest we add a test for it, which looks to be what Daniel is doing.

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 Well.. it is calling inside a try-statement, I believe which the close will be called in the end of the program or when some exception occur: