Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

Thanks all. Hope clear all conflicts. Jon, can you now merge the PR? Regards. Gurkan On Mon, Jan 7, 2019 at 5:21 PM Jean-Louis Monteiro wrote: > Yes I agree and take it as you describe so it's all good. It's definitely a > step forward > > Le lun. 7 janv. 2019 à 12:21, Gurkan Erdogdu a > écrit

Re: Ejemplos en Español

Hi, I rebase the PR with the latest master and did code clean up. The PR for https://issues.apache.org/jira/browse/TOMEE-2444 is ready for review. I included in the PR the instructions to check the feature: https://github.com/apache/tomee-site-generator/pull/16 To review this PR you need: 1. bui

[GitHub] cesarhernandezgt commented on issue #16: TOMEE-2444 Enable language support for examples

cesarhernandezgt commented on issue #16: TOMEE-2444 Enable language support for examples URL: https://github.com/apache/tomee-site-generator/pull/16#issuecomment-452160452 To review this PR you need: 1. build the project: `tomee-site-generator$ mvn clean install` 2. Choose any ex

Re: Performance issue with JMS on Tomee 7.0.5

Thanks Jonathan for such a quick reaction and the openness to provide a MWE for that issue to the community. Best Martin — https://twitter.com/mawiesne smime.p7s Description: S/MIME cryptographic signature

Re: Investigating TOMEE-2403 AutoConnectionTrackerTest fails randomly

Thanks. I'll set the rig up again and run some volume through with these changes. Jon On Mon, Jan 7, 2019 at 8:46 PM Doychin Bondzhev wrote: > Hi Jon, > > Please check this PR: > https://github.com/apache/tomee/pull/360 > > We can discuss the details there. > > I also found this bug report whic

Re: Investigating TOMEE-2403 AutoConnectionTrackerTest fails randomly

Hi Jon, Please check this PR: https://github.com/apache/tomee/pull/360 We can discuss the details there. I also found this bug report which is still open: https://issues.apache.org/jira/browse/TOMEE-2257 Is that the problem you describe? On 7.1.2019 г. 18:51, jgallimore [via TomEE & OpenEJB]

Re: Investigating TOMEE-2403 AutoConnectionTrackerTest fails randomly

This test was a pain to write, and I am grateful for the feedback. Please do send a PR and I'll take a look. Some background to the problem here is that the the AutoConnectionTracker failed in some circumstances when servers were under heavy load with lots of GC happening - there appeared to be a

Re: Investigating https://issues.apache.org/jira/browse/TOMEE-2403

Hi César, I found the CI pages but looks like logs are not kept for long enough. Any way I managed to reproduce the problem and I already implemented some changes in the test code and in the code that is tested. You can check them here in case you are interested and let me know if you have c

Re: Javadoc is online / How deployment works

nice improvement to the website. I'm getting more familiar with the site-generator, today I'll rebase my PR and try to finish the languages pr. One question, why do you mean by "referenced classes"? El sáb., 5 ene. 2019 a las 13:59, David Blevins () escribió: > Javadoc is now online! I still ha

Re: Stabilize TomEE Build

> > one suggestion was for committers to be able to kick off builds using a > specific commit hash, rather than automatically for each PR. My only observation about it is that this will require a non commiter to send an email to the dev list to request kick builds before actually sending the "Plea

Re: Investigating https://issues.apache.org/jira/browse/TOMEE-2403

Hi Doychin, By looking at TomEE-2403, it seems the issue was occurring only on TomEE CI [1]. If you click on a specific build you can have access to the entire log, see for instance: https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/987/steps/test/logs/stdio As a side note, I think thi

Re: Performance issue with JMS on Tomee 7.0.5

Thanks, Issue opened here: https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2449 We'll try and create a project that demonstrates the issue. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: MicroProfile Fault Tolerance 1.1?

I see now two issues. I will try to report the the problem I found with jitter now. On 7.1.2019 г. 15:05, Roberto Cortez [via TomEE & OpenEJB] wrote: Hum… weird. Apparently you need to be logged in. Do you have an Apache JIRA account? If not, just create one and try again, please. > On 7 Jan

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

Yes I agree and take it as you describe so it's all good. It's definitely a step forward Le lun. 7 janv. 2019 à 12:21, Gurkan Erdogdu a écrit : > Hello Jean-Louis and team, > I want to emphasize again that this PR will not change anything regarding > system properties. Its sole aim is to central

Re: Metrics question

Is just added as a library. Any glue code is going to: https://github.com/apache/tomee/tree/master/tomee/tomee-microprofile/mp-common > On 7 Jan 2019, at 12:51, Jonathan Gallimore > wrote: > > Thanks Roberto. > >

Re: MicroProfile Fault Tolerance 1.1?

Hum… weird. Apparently you need to be logged in. Do you have an Apache JIRA account? If not, just create one and try again, please. > On 7 Jan 2019, at 12:42, Doychin Bondzhev wrote: > > Thanks Roberto, > > Strange thing is that when I click the link that should display unresolved > issues o

Re: Metrics question

Thanks Roberto. One more question - metrics-wise, is there any gluecode, or is the implementation jar just added to lib/ and picked up through scanning? Jon On Mon, Jan 7, 2019 at 12:34 PM Roberto Cortez wrote: > The spec does not seem to be clear in that regard, maybe on purpose. > > It if wa

Re: MicroProfile Fault Tolerance 1.1?

Thanks Roberto, Strange thing is that when I click the link that should display unresolved issues of safeguard I don't see any issues. I also don't see any issues at all when I remove the filter for status. On 7.1.2019 г. 14:10, Roberto Cortez [via TomEE & OpenEJB] wrote: Hi Doychin, Safegu

Re: Metrics question

The spec does not seem to be clear in that regard, maybe on purpose. It if was supposed to work that way, that should be included in the TCK. I find it hard to believe that it was not included, because someone forgot to add it… On the other hand, I can see the possible conflicts that it would ca

Re: MicroProfile Fault Tolerance 1.1?

Hi Doychin, Safeguard is implemented under the Geronimo project umbrella, so if you need to report any issue, you need to report them in Geronimo JIRA: https://jira.apache.org/jira/projects/GERONIMO Here you can find some issues: https://jira.apa

Re: Stabilize TomEE Build

A couple of updates on this. I have a Jenkins install at home, which now runs master with 5 test failures that we don't see on buildbot, so I don't think there is technically much that holds us back from using Jenkins over something else. In terms of PR building, there's an interesting discussion

Re: Metrics question

This: `curl -v http://localhost:8080/mp-metrics-counted-8.0.0-SNAPSHOT/metrics` - does work and includes both the base and application metrics. Looking through the tests in microprofile-metrics-api-tck and microprofile-metrics-rest-tck, it looks like only accessing metrics via a CDI enabled applic

Re: MicroProfile Fault Tolerance 1.1?

Actually this version of safegurad is not behaving properly with some tests which fail for different reasons. For example there is a bug in the implementation for jitter where if you provide 0 as value it will fail. Another problem I've noticed is when you run the tests for fault tolerance the

Re: Stabilize TomEE Build

On Fri, Jan 4, 2019 at 7:24 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > On Fri, Jan 4, 2019 at 6:39 PM Ivan Junckes Filho > wrote: > > > Hey guys, can someone provide me the way to check if my PR is green? > > > > Yep, run the build on your branch :-). I run builds on PRs when

Re: Metrics question

Even with one of the metrics samples deployed, I still get a 404 from http://localhost:8080/metrics. Jon On Mon, Jan 7, 2019 at 11:24 AM Roberto Cortez wrote: > I believe it never worked that way. It always required to have an app > deployed. > > > On 7 Jan 2019, at 11:12, Jean-Louis Monteiro

Re: Metrics question

I believe it never worked that way. It always required to have an app deployed. > On 7 Jan 2019, at 11:12, Jean-Louis Monteiro wrote: > > I'll have a look after lunch > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Mon, Jan 7, 2019 at 12:10 PM

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

Hello Jean-Louis and team, I want to emphasize again that this PR will not change anything regarding system properties. Its sole aim is to centralize all literal system properties into its own module. Maybe, for the future, if needed, we can update this module to add more configuration related func

Re: Metrics question

Thanks, I appreciate it. I'll run the tests and post my output. Jon On Mon, Jan 7, 2019 at 11:12 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > I'll have a look after lunch > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Mon, Jan 7,

Re: MicroProfile Fault Tolerance 1.1?

Yes, There is already a 1.1 Geronimo implementation compliant version (Safeguard). JL added it, but it was failing the TCK. We think we need to do some integration code to be able to use it properly. Bruno was going to do that, so we reverted back to 1.0 version so we can have a green build unt

Re: Metrics question

I'll have a look after lunch -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Jan 7, 2019 at 12:10 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Ah right. It isn't working for me on a build of master. All I've done is > build it, extract

Re: Metrics question

I used it and demoed it at Devoxx MA. So something might have changed if it does not work now. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Jan 7, 2019 at 12:10 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Ah right. It isn't working

Re: Metrics question

Ah right. It isn't working for me on a build of master. All I've done is build it, extract the tar.gz for MicroProfile, run catalina.sh run, and try the curl command I mentioned. No other customization, no additional apps deployed. I'm not sure if I have missed a step, or a switch. Looking at the

Re: Metrics question

Yes you should get vendor, system and app name space Le lun. 7 janv. 2019 à 12:03, Jonathan Gallimore < jonathan.gallim...@gmail.com> a écrit : > Apologies if this is a stupid question... but if I extract the MicroProfile > flavor of TomEE, and try and do `curl http://localhost:8080/metrics` >

Metrics question

Apologies if this is a stupid question... but if I extract the MicroProfile flavor of TomEE, and try and do `curl http://localhost:8080/metrics` - should I get some built in basic metric data back? Thanks Jon

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

Just want to make sure we don't forget System Properties were meant to be used to override configuration and not to be the main configuration system for TomEE. We can discuss it and decide to change our mind and TomEE, but as per now, I'm not really keen to relying on system properties to configur

Re: Performance issue with JMS on Tomee 7.0.5

Hi Jonathan, could you open a JIRA for the below topic, please? It makes it a lot easier to track the weird behaviour and it is so important to document your observations. Thereby, we’ll be able to reference this issue in upcoming discussions. Please put additional material into the JIRA, as lo