Re: Another 8.0.0 milestone release

2019-01-23 Thread David Blevins
Thank you for volunteering, Cesar. Roberto, you did the last 8.0.0-M1 release. Do you want to take the lead and pull in Cesar (on the list of course) and get some binaries we can vote on tomorrow? We can yank the MP support in Plus and Plume and hold that for 8.0.0-next. I'd say skip the

Re: Ejemplos en Español

2019-01-23 Thread David Blevins
> On Jan 23, 2019, at 1:19 PM, César Hernández Mendoza > wrote: >> ... an upper case variable name :) > > I really sorry about that horrible typo, somehow it passes under the > commits and reviews. There's nothing to be sorry for -- I thought it was funny :) Besides, here is the nature of

Re: How can i help?

2019-01-23 Thread Fausto Arredondo
Thank you. I'll work on it then. El mié., 23 de ene. de 2019 a la(s) 15:56, César Hernández Mendoza ( cesargu...@gmail.com) escribió: > We don't have a deadline for it, but for rules to follow I recommend you to > check the recommended workflow we the contributors and committers use: >

Re: How can i help?

2019-01-23 Thread César Hernández Mendoza
We don't have a deadline for it, but for rules to follow I recommend you to check the recommended workflow we the contributors and committers use: http://tomee.apache.org/community/contributing/workflow.html El mié., 23 ene. 2019 a las 15:33, Fausto Arredondo (< fausto.arr...@gmail.com>)

Re: Ejemplos en Español

2019-01-23 Thread Richard Monson-Haefel
That's not OCD. That's like Sherlock Holmes level of observation! On Wed, Jan 23, 2019 at 2:23 PM David Blevins wrote: > Working on it now! > > Off topic: My OCD is scaring even myself. You've got 7 commits, 9 changed > files, 700 new lines of code and in under 20 seconds of pulling everything

Re: How can i help?

2019-01-23 Thread Fausto Arredondo
Hi Cesar, Thank you. Ok, my JIRA username is "ivandev" Do we have a deadline for this issues or some rules to follow ? El mié., 23 de ene. de 2019 a la(s) 15:11, César Hernández Mendoza ( cesargu...@gmail.com) escribió: > @Fausto: > > Excellent!, I created

Re: Ejemplos en Español

2019-01-23 Thread César Hernández Mendoza
> > Working on it now! Thank you. > ... an upper case variable name :) I really sorry about that horrible typo, somehow it passes under the commits and reviews. I kinda felt bad for giving you too much feedback already. I think the approach of incremental improvements is been a good

Re: How can i help?

2019-01-23 Thread César Hernández Mendoza
@Fausto: Excellent!, I created https://issues.apache.org/jira/browse/TOMEE-2459. Notice that since the ticket is a clone from another ticket, it preserves the Assignee. Can you please provide your JIRA username so an admin can update the Assignee. If you haven't created an account on JIRA you

Re: Ejemplos en Español

2019-01-23 Thread David Blevins
Working on it now! Off topic: My OCD is scaring even myself. You've got 7 commits, 9 changed files, 700 new lines of code and in under 20 seconds of pulling everything into my IDE my eyes lock in on and cannot stop staring at the one place you used an upper case variable name :) -

Re: How can i help?

2019-01-23 Thread Fausto Arredondo
Hi Cesar, Ok , no problem I'll just work on the translation and ask for a PR for translating into Spanish , this one is ok ? https://github.com/apache/tomee/tree/master/examples/access-timeout-meta Thanks. El mié., 23 de ene. de 2019 a la(s) 13:22, César Hernández Mendoza (

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Roberto Cortez
I’ll try to have a look into the issue. Are you positive that the apps are being deployed correctly? I think there are a few cases where there is a silent error and the app fails to deploy hence, you see the 404. If you have REST endpoints going deployed, it is easy to see if these are ok,

Re: How can i help?

2019-01-23 Thread César Hernández Mendoza
Hola Fausto, I have a PR with the instruction for translating into Spanish (or any language) the examples Readme files, check the following link: https://github.com/apache/tomee/blob/1a2bc55df2070d6dc27d8a46a506f287071c19e4/examples/README.adoc#translation Yes, I can create a JIRA for you, for

Re: How can i help?

2019-01-23 Thread Fausto Arredondo
Hi Cesar, How can i start translating in Spanish? You will assign one JIRA to me ? Thanks . El lun., 21 de ene. de 2019 a la(s) 10:56, César Hernández Mendoza ( cesargu...@gmail.com) escribió: > Hi Fausto! > We currently have a couple of Epics targeted for new contributors, > please check for

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
So progress is good, I feel like it's close to working with MP. Took the SystemInstance parent failover line out and now it's dependent on this issue being resolved https://issues.apache.org/jira/browse/TOMEE-2458 which was why it was put in the first place. I've worked around by adding all the

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Roberto Cortez
Yes, OpenAPI made the fix: https://github.com/apache/geronimo-openapi/commit/7ceee65e0b489f4847f4015aa71a3d7b6958b402 We still need to wait for a release or bump to use the SNAPSHOT version. > On 23

Re: Another 8.0.0 milestone release

2019-01-23 Thread Wiesner, Martin
Hi all, +1 Pls, also keep the release of 7.1.x (x=1) in mind, as the Java 11 out-of-the-box experience is crucial for many users in the community. Best Martin — https://twitter.com/mawiesne smime.p7s Description: S/MIME cryptographic signature

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
On this specific service, there is the following: @Path("/") @GET public Response doGetRoot() { … } Followed by paths with actual values just like you said. It would be good for OpenAPI to provide a fix, I will see if I can test changing it in source directly tonight by just changing "/", to

Re: Ejemplos en Español

2019-01-23 Thread César Hernández Mendoza
Hi, Can some of the committers please redeploy TomEE website, http://tomee.apache.org/docs.html still doesn't show the translation language available and https://issues.apache.org/jira/browse/TOMEE-2444 is still marked as Open. El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<

Re: Another 8.0.0 milestone release

2019-01-23 Thread Ivan Junckes Filho
+1 On Wed, Jan 23, 2019 at 11:56 AM Frankie wrote: > I like the idea. > +1 > > Frankie > > > > -- > Sent from: > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html >

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Roberto Cortez
I believe this is caused when you have a @Path parent element with just a "/" value and then methods with @Path and and actual value.I think the fix needs to be done on the OpenAPI side, or just remove the "/“ from the @Path parent element, but that involves changing app code. I’ve created

Re: JakartaEE TCK

2019-01-23 Thread César Hernández Mendoza
> Where do we say to run the tests against a specific version of TomEE? I'm blocked at this point too. Once the UI is open I don't know what to open or how to properly create the javaee_web_profile filter. El mié., 23 ene. 2019 a las 8:32, Bruno Baptista () escribió: > Hi César, > > Thanks for

Re: JakartaEE TCK

2019-01-23 Thread Bruno Baptista
Hi César, Thanks for this email. I was not aware of this UI. I managed to make it work but I think I'm missing something Where do we say to run the tests against a specific version of TomEE? This seems to ignore the TomEE-TCK project. Cheers Bruno Baptista https://twitter.com/brunobat_

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
FYI, as you mentioned, I also see OpenAPI annotation index out of bounds. If you would like me to test out any fix for it, I can do that immediately... /Caused by: java.lang.StringIndexOutOfBoundsException: begin 1, end 0, length 1 at

Re: Another 8.0.0 milestone release

2019-01-23 Thread Frankie
I like the idea. +1 Frankie -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Another 8.0.0 milestone release

2019-01-23 Thread Bruno Baptista
+1 Bruno Baptista https://twitter.com/brunobat_ On 23/01/19 01:59, David Blevins wrote: There are plans to launch start.microprofile.io on January 29th. We have a lot more MicroProfile support in master than we do in 8.0.0-M1. What do we think about shooting out an 8.0.0-M2 asap and

Re: OpenTracing - nullpointer OpenTracingFilter

2019-01-23 Thread Ivan Junckes Filho
Good news, this is not happening in the master. I will close the ticket and wait for the release. On Wed, Jan 23, 2019 at 11:16 AM Ivan Junckes Filho wrote: > This is the ticket: > https://issues.apache.org/jira/browse/TOMEE-2457 > > This looks like a release blocker in my opinion. I will check

Re: OpenTracing - nullpointer OpenTracingFilter

2019-01-23 Thread Ivan Junckes Filho
This is the ticket: https://issues.apache.org/jira/browse/TOMEE-2457 This looks like a release blocker in my opinion. I will check the master and see how it behaves. On Tue, Jan 22, 2019 at 3:53 PM Roberto Cortez wrote: > Hi Ivan, > > Can you please provide a test case that reproduces the

Re: Another 8.0.0 milestone release

2019-01-23 Thread Otávio Gonçalves de Santana
+1 On Wed, Jan 23, 2019 at 8:48 AM Roberto Cortez wrote: > There are a few MP issues that we need to sort out regarding plume and > plus (if we want to push MP into plus and plume). I’ll explain those in the > other thread. We need to fix them or drop plus and plume support for this > release.

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Bruno Baptista
Hi Roberto, I'll take a look at the PR. Cheers. Bruno Baptista https://twitter.com/brunobat_ On 23/01/19 11:30, Roberto Cortez wrote: Hi folks, Let me try to give a full overview on what I have been working on in the last couple of days. Progress has been a bit slow unfortunately, due to

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Roberto Cortez
Hi folks, Let me try to give a full overview on what I have been working on in the last couple of days. Progress has been a bit slow unfortunately, due to the amount of combinations and tests that I have to run every time I do a change. On the other hand, I know understand way better how TomEE

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Roberto Cortez
We introduced a couple of new properties to allows additional jars to be added in the DeploymentLoader, so they can be scanned. This was done here: https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
Okay, so digging into this loader, there is this line: SystemInstance.get().setComponent(ParentClassLoaderFinder.class, fallback -> MyClassLoader._getOrCreateInstance(parent)); Commenting it out seems to make it play nicely with MP but brakes the class loading of the webapps when openejb's

Re: Another 8.0.0 milestone release

2019-01-23 Thread Roberto Cortez
There are a few MP issues that we need to sort out regarding plume and plus (if we want to push MP into plus and plume). I’ll explain those in the other thread. We need to fix them or drop plus and plume support for this release. > On 23 Jan 2019, at 10:14, Daniel Cunha wrote: > > Sounds good

Re: Another 8.0.0 milestone release

2019-01-23 Thread Daniel Cunha
Sounds good to me as well. +1 Em qua, 23 de jan de 2019 às 05:46, Gurkan Erdogdu escreveu: > +1 > Gurkan > > On Wed, Jan 23, 2019 at 10:17 AM Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > > > Sounds good to me. > > > > Le mer. 23 janv. 2019 à 04:23, César Hernández Mendoza < > >

Re: Looking for review on PR

2019-01-23 Thread Bruno Baptista
Hi Doychin, The test passes but I don't know if the changes are subverting the original purpose of the test. Let's wait for some more feedback on that. Cheers Bruno Baptista https://twitter.com/brunobat_ On 23/01/19 09:34, Doychin Bondzhev wrote: I've added new commit to PR

PR review and merge

2019-01-23 Thread Bruno Baptista
Hi, Can one of the committers please take a look at these PRs? https://github.com/apache/tomee/pull/377 https://github.com/apache/tomee/pull/376 https://github.com/apache/tomee/pull/375 https://github.com/apache/tomee/pull/370 https://github.com/apache/tomee/pull/366

Re: Looking for review on PR

2019-01-23 Thread Doychin Bondzhev
I've added new commit to PR https://github.com/apache/tomee/pull/360 On 21.1.2019 г. 18:14, brunobat [via TomEE & OpenEJB] wrote: Sure Doychin, Looking forward for that update. Cheers Bruno Baptista https://twitter.com/brunobat_ On 21/01/19 15:10, Doychin Bondzhev wrote: > Hi Bruno, > >

Re: Another 8.0.0 milestone release

2019-01-23 Thread Gurkan Erdogdu
+1 Gurkan On Wed, Jan 23, 2019 at 10:17 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Sounds good to me. > > Le mer. 23 janv. 2019 à 04:23, César Hernández Mendoza < > cesargu...@gmail.com> > a écrit : > > > I have never done a TomEE release but I'm willing to learn during >