Re: XA examples

2019-06-18 Thread César Hernández Mendoza
Thanks for the PR's and context provided. I provided feedback on the PR #488 and I'm also proposing an alternative to declare the Derby XA data source as part of the comments. What I currently understand: - examples/xa-datasource is currently serving

[GitHub] [tomee] cesarhernandezgt commented on a change in pull request #488: Performance tests for XA example

2019-06-18 Thread GitBox
cesarhernandezgt commented on a change in pull request #488: Performance tests for XA example URL: https://github.com/apache/tomee/pull/488#discussion_r295012658 ## File path: examples/xa-datasource/src/main/webapp/WEB-INF/resources.xml ## @@ -0,0 +1,46 @@ + + + +Jdb

[GitHub] [tomee] cesarhernandezgt commented on a change in pull request #488: Performance tests for XA example

2019-06-18 Thread GitBox
cesarhernandezgt commented on a change in pull request #488: Performance tests for XA example URL: https://github.com/apache/tomee/pull/488#discussion_r295012499 ## File path: examples/xa-datasource/src/main/webapp/WEB-INF/resources.xml ## @@ -0,0 +1,46 @@ + + + +Jdb

[GitHub] [tomee] cesarhernandezgt commented on a change in pull request #488: Performance tests for XA example

2019-06-18 Thread GitBox
cesarhernandezgt commented on a change in pull request #488: Performance tests for XA example URL: https://github.com/apache/tomee/pull/488#discussion_r295028997 ## File path: examples/xa-datasource/src/main/webapp/WEB-INF/resources.xml ## @@ -0,0 +1,46 @@ + + + Revie

[GitHub] [tomee] cesarhernandezgt commented on a change in pull request #488: Performance tests for XA example

2019-06-18 Thread GitBox
cesarhernandezgt commented on a change in pull request #488: Performance tests for XA example URL: https://github.com/apache/tomee/pull/488#discussion_r295000246 ## File path: examples/xa-datasource/src/main/webapp/WEB-INF/resources.xml ## @@ -0,0 +1,46 @@ + + + +Jdb

[GitHub] [tomee] dineshkumarg commented on issue #479: Create java-compatibility.adoc

2019-06-18 Thread GitBox
dineshkumarg commented on issue #479: Create java-compatibility.adoc URL: https://github.com/apache/tomee/pull/479#issuecomment-503186124 > Hi, > Dinesh. Do you have any more contact information? Like an email address? yes it's dinesh.gad...@gmail.com -

[GitHub] [tomee] rmonson commented on issue #479: Create java-compatibility.adoc

2019-06-18 Thread GitBox
rmonson commented on issue #479: Create java-compatibility.adoc URL: https://github.com/apache/tomee/pull/479#issuecomment-503172411 Hi, Dinesh. Do you have any more contact information? Like an email address? This is an

Re: XA examples

2019-06-18 Thread Jonathan Gallimore
Cesar I backported this to 1.7.x: https://github.com/apache/tomee/pull/489 I think this and https://github.com/apache/tomee/pull/488 should be ready for merge now. Can you review? If you're happy, I'll merge. We should start collecting some configs for different databases: Oracle SQL Server Pos

[GitHub] [tomee] jgallimore opened a new pull request #489: Backport of #488 from master

2019-06-18 Thread GitBox
jgallimore opened a new pull request #489: Backport of #488 from master URL: https://github.com/apache/tomee/pull/489 Add performance test to xa-datasource example This is an automated message from the Apache Git Service. To r

Re: [VOTE] Release Apache TomEE 7.0.6

2019-06-18 Thread Jonathan Gallimore
JIRA details for TomEE 7.0.6: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12342069 Note that there are a lot of JIRAs not complete with a fix version of 7.0.6, which I have moved on to 7.0.7. Clean up help is welcome. Thanks Jon On Thu, Jun 6, 2019 at 12:08

Re: [VOTE] Release Apache TomEE 7.1.1

2019-06-18 Thread Jonathan Gallimore
JIRA details for TomEE 7.1.1: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12344119 Thanks Jon On Thu, Jun 6, 2019 at 12:08 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Maven Repo: > > https://repository.apache.org/content/repositories/orga

[GitHub] [tomee] jgallimore commented on issue #482: Code to add support for TOMEE-542

2019-06-18 Thread GitBox
jgallimore commented on issue #482: Code to add support for TOMEE-542 URL: https://github.com/apache/tomee/pull/482#issuecomment-503043423 This looks great, and thank you for the PR! I'm just going to run a build with this on a Windows box and get it merged in for you.

[GitHub] [tomee] jgallimore commented on issue #487: Added Grinder setup for XA performance test.

2019-06-18 Thread GitBox
jgallimore commented on issue #487: Added Grinder setup for XA performance test. URL: https://github.com/apache/tomee/pull/487#issuecomment-503041832 I expanded on this in https://github.com/apache/tomee/pull/488 This is an au

XA examples

2019-06-18 Thread Jonathan Gallimore
Hi Cesar I had a go with your XA sample PR. I've picked it up and expanded on it: https://github.com/apache/tomee/pull/488 Can you take a look and see what you think? I've removed any references to ojdbc jar, and tweaked so the jars for the Grinder framework aren't committed to the repository. Ou

[GitHub] [tomee] jgallimore opened a new pull request #488: Performance tests for XA example

2019-06-18 Thread GitBox
jgallimore opened a new pull request #488: Performance tests for XA example URL: https://github.com/apache/tomee/pull/488 Follow on from #487. Strips out all jars from the project/repository, and creates a Grinder directory when running the Maven build. Uses Apache Derby out of the box. So

Re: [VOTE] Release Apache TomEE 7.1.1

2019-06-18 Thread Jonathan Gallimore
Hi Alexandre I really appreciate the level of testing you have carried out on both releases - thank you! I'll sort out the list of closed issues for both releases and add them to these threads. Jon On Tue, Jun 18, 2019 at 9:39 AM Alex The Rocker wrote: > Hello, > > +1 (non-binding) > Verified

Re: [VOTE] Release Apache TomEE 7.1.1

2019-06-18 Thread Alex The Rocker
Hello, +1 (non-binding) Verified TomEE 7.1.1 plus binaries with the following combinations: * CentOS 7.5 / SLES 12 / Windows Server 2016 * AdoptOpenJDK 8 update 212 with OpenJ9 / AdoptOpenJDK 11.0.3 with OpenJ9 and with HotSpot * Our many web apps relying on Servlets, JSP, JAX-RS, JAX-WS, JMS (wit

Re: [VOTE] Release Apache TomEE 7.0.6

2019-06-18 Thread Jonathan Gallimore
Here's my +1. Jon On Thu, Jun 6, 2019 at 12:08 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Maven Repo: > > https://repository.apache.org/content/repositories/orgapachetomee-1139/ > > Binaries & Source: > > https://dist.apache.org/repos/dist/dev/tomee/staging-1139/tomee-7.0.6/

Re: [VOTE] Release Apache TomEE 7.1.1

2019-06-18 Thread Jonathan Gallimore
Here's my +1. Jon On Thu, Jun 6, 2019 at 12:08 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Maven Repo: > > https://repository.apache.org/content/repositories/orgapachetomee-1138/ > > Binaries & Source: > > https://dist.apache.org/repos/dist/dev/tomee/staging-1138/tomee-7.1.1/