Re: [GitHub] [tomee v9] pull request #928: Dependency properties cleanup

2022-09-28 Thread David Blevins
> On Sep 28, 2022, at 1:26 PM, Swell wrote: > > about the prefixes, there could be ambiguities or collisions when using > short names, > * group: 'org.apache.tomee', name: 'jakartaee-api', version: '9.1-M2' > * group: 'jakarta.platform', name: 'jakarta.jakartaee-api', version: '9.1.0' > the prop

Re: [GitHub] [tomee v9] pull request #928: Dependency properties cleanup

2022-09-28 Thread Swell
Thanks for the CI job Richard ! while it builds i'll clean some props on my own branch using David suggestions : removing api, tck, and impl prefixes and have separate props for microprofile api and smallrye impl -- Swell On Wed, 28 Sept 2022 at 20:21, Zowalla, Richard < richard.zowa...@hs-heil

Re: [GitHub] [tomee v9] pull request #928: Dependency properties cleanup

2022-09-28 Thread Swell
about the prefixes, there could be ambiguities or collisions when using short names, * group: 'org.apache.tomee', name: 'jakartaee-api', version: '9.1-M2' * group: 'jakarta.platform', name: 'jakarta.jakartaee-api', version: '9.1.0' the property would be ambiguous. but i agree we should keep thing

Re: [GitHub] [tomee v9] pull request #928: Dependency properties cleanup

2022-09-28 Thread Zowalla, Richard
Regarding CI: I just pushed Swell's branch as a branch named TOMEE-4053 to the TomEE main repo and we will get some CI results via https://ci-builds.apache.org/job/Tomee/job/TOMEE-4053/ soon (6-8h) ;-) I have no hard opinion regarding version.foo vs version.groupid.foo as long as we are consisten

Re: [GitHub] [tomee v9] pull request #928: Dependency properties cleanup

2022-09-28 Thread David Blevins
Thanks for the proposal and the email! I think it's fantastic to get the version strings normalized to `version.foo`. We started with `foo.version` and gradually changed to `version.foo` as that kind of thing became more favored by Maven in general, but we never went back and fixed the old pro

[GitHub] [tomee-site-generator] rzo1 merged pull request #43: TOMEE-3981 update javadoc to reflect updates on Jakarta EE

2022-09-28 Thread GitBox
rzo1 merged PR #43: URL: https://github.com/apache/tomee-site-generator/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.ap

[GitHub] [tomee-site-generator] rzo1 commented on pull request #43: TOMEE-3981 update javadoc to reflect updates on Jakarta EE

2022-09-28 Thread GitBox
rzo1 commented on PR #43: URL: https://github.com/apache/tomee-site-generator/pull/43#issuecomment-1261255634 Thanks @sultan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [tomee-site-generator] rzo1 merged pull request #48: TOMEE-4023 Comparison pages with wrong specs per profile

2022-09-28 Thread GitBox
rzo1 merged PR #48: URL: https://github.com/apache/tomee-site-generator/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.ap

Re: Cut a 8.0.13?

2022-09-28 Thread Alex The Rocker
Hi there, +1 for a TomEE 8.013 ASAP provided it includes fix for: CVE-2021-43980 Apache Tomcat - Information Disclosure Kind regards, Alex Le mer. 28 sept. 2022 à 18:45, Zowalla, Richard a écrit : > > Hi all, > > our last 8.x release was in June and we have 22 pending updates/issues > for 8.0.

Re: [GitHub] [tomee v9] pull request #928: Dependency properties cleanup

2022-09-28 Thread Zowalla, Richard
Hi, yeah, such PRs are difficult to review by nature :) Thanks for the effort to make it consistent and more clear! Personally, I am fine with the proposal.  If we don't want to do the "big bang integration" approach, we can easily setup a CI job on jenkins (similar to our full build by simply c

[GitHub] [tomee] dblevins commented on pull request #928: [TOMEE-4053] Dependency properties cleanup

2022-09-28 Thread GitBox
dblevins commented on PR #928: URL: https://github.com/apache/tomee/pull/928#issuecomment-1261242285 I think it's fantastic to get the version strings normalized to `version.foo`. We started with `foo.version` and gradually changed to `version.foo` as that kind of thing became more favored

Re: Logging, uff-da

2022-09-28 Thread David Blevins
> On Sep 28, 2022, at 11:45 AM, Zowalla, Richard > wrote: > > However, I agree with JL, that we are really close to passing the TCK again, > which would allow to cut a sweet & nice 9.0.0 Final before moving on to EE10 > work :) Agreed. > On Sep 23, 2022, at 4:01 PM, David Blevins wrote: >

Re: Logging, uff-da

2022-09-28 Thread Zowalla, Richard
I think, that we are an app server first and not a logging framework (;-)), so I am fine with "I have no idea what all that code does and I'm happy when I don't have to look at it". However, I agree with JL, that we are really close to passing the TCK again, which would allow to cut a sweet &

Re: TomEE Jakarta and CXF

2022-09-28 Thread Zowalla, Richard
Hi JL, really great news! Thanks a lot. Richard Am Mittwoch, dem 21.09.2022 um 17:01 +0200 schrieb Jean-Louis Monteiro: > Hi all, > > After working quite hard moving TomEE to jakarta namespace (TomEE 9 > for EE > 9.1), we started implementing MicroProfile 5.0 using SmallRye. > > Looks like we

Cut a 8.0.13?

2022-09-28 Thread Zowalla, Richard
Hi all, our last 8.x release was in June and we have 22 pending updates/issues for 8.0.13. Mostly dependency updates (johnzon, dbcp2, myfaces, hsqldb, tomcat, jakarta faces), and some minor bugs (windows, jdk17+ related backports), see below. We might need to go through the 3rd party libs again

[GitHub] [tomee] sultan commented on pull request #914: TOMEE-4023 Comparison pages with wrong specs per profile

2022-09-28 Thread GitBox
sultan commented on PR #914: URL: https://github.com/apache/tomee/pull/914#issuecomment-1261150285 Thanks @jeanouii ! https://github.com/apache/tomee-site-generator/pull/43 is still pending (same improvements) and https://github.com/apache/tomee-site-generator/pull/48 also pending

[GitHub] [tomee v9] pull request #928: Dependency properties cleanup

2022-09-28 Thread Swell
Hi everyone, The pom.xml of the project uses several properties to configure dependencies. some of which not used anymore since switching from geronimo to smallrye. i've been working on removing orphan properties, renaming versions props on the same format whenever i was able. reorganizing a bit.

[GitHub] [tomee] github-actions[bot] closed pull request #929: Regenerated BOMs after dependency upgrades

2022-09-28 Thread GitBox
github-actions[bot] closed pull request #929: Regenerated BOMs after dependency upgrades URL: https://github.com/apache/tomee/pull/929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [tomee] github-actions[bot] opened a new pull request, #929: Regenerated BOMs after dependency upgrades

2022-09-28 Thread GitBox
github-actions[bot] opened a new pull request, #929: URL: https://github.com/apache/tomee/pull/929 Found some uncommited changes (from BOM regeneration) after running build on TomEE main -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [tomee] jeanouii commented on pull request #928: [TOMEE-] Dependency properties cleanup

2022-09-28 Thread GitBox
jeanouii commented on PR #928: URL: https://github.com/apache/tomee/pull/928#issuecomment-1260961413 Hi, Yes by nature the big PRs are difficult to review. That being said, I appreciate the effort to bring clarity and consistency. I'm ok to merge it and see if it breaks and possibl

[GitHub] [tomee] jeanouii merged pull request #927: [TOMEE-4035] Jakarta 9.1.0 and MicroProfile 5.0

2022-09-28 Thread GitBox
jeanouii merged PR #927: URL: https://github.com/apache/tomee/pull/927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

[GitHub] [tomee] jeanouii merged pull request #917: TOMEE-4023 Comparison pages with wrong specs per profile

2022-09-28 Thread GitBox
jeanouii merged PR #917: URL: https://github.com/apache/tomee/pull/917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

[GitHub] [tomee] jeanouii merged pull request #916: TOMEE-4023 Comparison pages with wrong specs per profile

2022-09-28 Thread GitBox
jeanouii merged PR #916: URL: https://github.com/apache/tomee/pull/916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

[GitHub] [tomee] jeanouii merged pull request #915: TOMEE-4023 Comparison pages with wrong specs per profile

2022-09-28 Thread GitBox
jeanouii merged PR #915: URL: https://github.com/apache/tomee/pull/915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

[GitHub] [tomee] jeanouii merged pull request #914: TOMEE-4023 Comparison pages with wrong specs per profile

2022-09-28 Thread GitBox
jeanouii merged PR #914: URL: https://github.com/apache/tomee/pull/914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

[GitHub] [tomee] sultan commented on pull request #928: [TOMEE-] Dependency properties cleanup

2022-09-28 Thread GitBox
sultan commented on PR #928: URL: https://github.com/apache/tomee/pull/928#issuecomment-1260853179 This is a proposal, (i did not expect this quality PR to impact almost 100 poms) open to discussion -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [tomee] sultan commented on pull request #927: [TOMEE-4035] Jakarta 9.1.0 and MicroProfile 5.0

2022-09-28 Thread GitBox
sultan commented on PR #927: URL: https://github.com/apache/tomee/pull/927#issuecomment-1260851720 This is a proposal, open to discussion. I am available on demand to create one Jira ticket per artifact. -- This is an automated message from the Apache Git Service. To respond to the messag