[GitHub] [tomee] rzo1 commented on pull request #975: [TOMEE-4115] Tomcat update to 10.1.x (may be outdated, please look changes and consider merge or close)

2023-02-06 Thread via GitHub
rzo1 commented on PR #975: URL: https://github.com/apache/tomee/pull/975#issuecomment-1420295312 I think, that this content is already contained in https://github.com/apache/tomee/pull/1005 - if not, we should change the merge target for it. -- This is an automated message from the

[GitHub] [tomee] rzo1 commented on pull request #1009: [TOMEE-4140] Update Micro Profile to 6.0 except SmallRye Metrics

2023-02-06 Thread via GitHub
rzo1 commented on PR #1009: URL: https://github.com/apache/tomee/pull/1009#issuecomment-1420294400 I think, that the target should be https://github.com/apache/tomee/pull/1005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomee] rzo1 commented on pull request #997: [TOMEE-4053] Dependency properties cleanup, step 3 : Micro Profile properties on branch main/10.x

2023-02-06 Thread via GitHub
rzo1 commented on PR #997: URL: https://github.com/apache/tomee/pull/997#issuecomment-1420294062 I think, that the target should be https://github.com/apache/tomee/pull/1005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomee] rzo1 commented on pull request #940: [TOMEE-4061] TomEE 9.x + Derby 10.15.2.0, upon other dependencies update

2023-02-06 Thread via GitHub
rzo1 commented on PR #940: URL: https://github.com/apache/tomee/pull/940#issuecomment-1420292041 I think, that we need to port these changes targeting https://github.com/apache/tomee/pull/1005 as well. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomee] rzo1 commented on pull request #1013: [TOMEE-4053] Dependency properties cleanup, branch 9.x

2023-02-06 Thread via GitHub
rzo1 commented on PR #1013: URL: https://github.com/apache/tomee/pull/1013#issuecomment-1420291090 I triggered a CI run for it: https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/3/ -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomee] rzo1 commented on pull request #1020: [TOMEE-4053] Dependency properties cleanup, branch 8.x

2023-02-06 Thread via GitHub
rzo1 commented on PR #1020: URL: https://github.com/apache/tomee/pull/1020#issuecomment-1420290273 I triggered a CI build for it: https://ci-builds.apache.org/job/Tomee/job/pull-request-8.x-manual/10/ -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomee] tandraschko commented on a diff in pull request #1005: WIP Update Jakarta EE API to 10.1-M1

2023-02-06 Thread via GitHub
tandraschko commented on code in PR #1005: URL: https://github.com/apache/tomee/pull/1005#discussion_r1097584771 ## boms/tomee-microprofile-api/pom.xml: ## @@ -76,7 +76,7 @@ org.apache.myfaces.core myfaces-api - 3.0.2 + 4.0.0-RC3 Review Comment:

[GitHub] [tomee] rzo1 commented on pull request #1019: Faces 4.0

2023-02-06 Thread via GitHub
rzo1 commented on PR #1019: URL: https://github.com/apache/tomee/pull/1019#issuecomment-1419316833 https://github.com/apache/tomee/pull/1005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomee] rzo1 commented on pull request #1019: Faces 4.0

2023-02-06 Thread via GitHub
rzo1 commented on PR #1019: URL: https://github.com/apache/tomee/pull/1019#issuecomment-1419315978 There is a PR in which the while EE10 ist happening -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tomee] tandraschko commented on pull request #1019: Faces 4.0

2023-02-06 Thread via GitHub
tandraschko commented on PR #1019: URL: https://github.com/apache/tomee/pull/1019#issuecomment-1419298521 which branch is it? isnt master 10.0 the correct one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tomee] jeanouii commented on pull request #1019: Faces 4.0

2023-02-06 Thread via GitHub
jeanouii commented on PR #1019: URL: https://github.com/apache/tomee/pull/1019#issuecomment-1419289424 Let's close this one so we mess up with master. It's been successfully merged into the Jakarta branch -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomee] jeanouii closed pull request #1019: Faces 4.0

2023-02-06 Thread via GitHub
jeanouii closed pull request #1019: Faces 4.0 URL: https://github.com/apache/tomee/pull/1019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: Jakarta EE 10 status

2023-02-06 Thread Jean-Louis Monteiro
Jon did the merge into our Jakarta branch, so we can close the PR now -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Feb 6, 2023 at 4:33 PM Jean-Louis Monteiro wrote: > let's merge it into the branch > awesome, I'll get that in for you. Thank you > >

Re: Jakarta EE 10 status

2023-02-06 Thread Jean-Louis Monteiro
let's merge it into the branch awesome, I'll get that in for you. Thank you -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Feb 6, 2023 at 4:32 PM Thomas Andraschko < andraschko.tho...@gmail.com> wrote: > Already created a PR:

Re: Jakarta EE 10 status

2023-02-06 Thread Thomas Andraschko
Already created a PR: https://github.com/apache/tomee/pull/1019 just the samples are using the old JSF managed beans, tomee-myfaces and other modules compiles fine Am Mo., 6. Feb. 2023 um 16:19 Uhr schrieb Jean-Louis Monteiro < jlmonte...@tomitribe.com>: > I looked at the new RC4 and it looks

Re: Jakarta EE 10 status

2023-02-06 Thread Jean-Louis Monteiro
I looked at the new RC4 and it looks like a big refactoring? So moving to RC4 requires some thoughts. For instance, the APIs changed and therefore tomee-myfaces does not compile anymore after upgrading. I'm wondering if this is even required now. I think Romain did most of the integration at that

Re: Jakarta EE 10 status

2023-02-06 Thread Thomas Andraschko
Mojarra is final, in MyFaces we have already RC4 which is close to final. Am Mo., 6. Feb. 2023 um 13:56 Uhr schrieb Jean-Louis Monteiro < jlmonte...@tomitribe.com>: > That's awesome. Is there any snapshot already? > I believe this is not final yet? > > -- > Jean-Louis Monteiro >

Re: Jakarta EE 10 status

2023-02-06 Thread Jean-Louis Monteiro
That's awesome. Is there any snapshot already? I believe this is not final yet? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Feb 6, 2023 at 1:07 PM Thomas Andraschko < andraschko.tho...@gmail.com> wrote: > JFYI: I also created a PR for Faces4.0;

Re: Jakarta EE 10 status

2023-02-06 Thread Thomas Andraschko
JFYI: I also created a PR for Faces4.0; both Mojarra and MyFaces are ready actually Am Mo., 6. Feb. 2023 um 13:00 Uhr schrieb Jean-Louis Monteiro < jlmonte...@tomitribe.com>: > Hi all, > > As you know, TomEE 9.0.0 reached final and we immediately switched to TomEE > 10 actively. > > For TomEE,

Jakarta EE 10 status

2023-02-06 Thread Jean-Louis Monteiro
Hi all, As you know, TomEE 9.0.0 reached final and we immediately switched to TomEE 10 actively. For TomEE, here is the branch https://github.com/apache/tomee/pull/1005--> it's fairly big now because it has also some additional standalone TCKs added. Jakarta EE API has been updated

[GitHub] [tomee] tandraschko commented on pull request #1019: Faces 4.0

2023-02-06 Thread via GitHub
tandraschko commented on PR #1019: URL: https://github.com/apache/tomee/pull/1019#issuecomment-1418700147 that would be great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific