Re: Github pull requests?

2014-10-08 Thread Tommy Tynjä
patch for the change set which I've then attached to the associated JIRA issue for any of the committers to evaluate and to commit. Best regards, Tommy Tynjä On Mon, Sep 29, 2014 at 1:46 PM, Chris Christo _...@mail.com wrote: Can anyone confirm please? Chris Christo { github.com/christchristo

Re: TomEE 2.0.0 Milestone 1

2014-09-01 Thread Tommy Tynjä
+1. Sounds good! Best regards, Tommy Tynjä Med vänliga hälsningar Best regards Tommy Tynjä Systems Development Consultant Phone: +46 (0)70 720 95 05 Fax: +46 (8) 667 57 11 Address: Riddargatan 23, SE-114 57 Stockholm www.diabol.se Twitter: @tommysdk http://twitter.com/tommysdk On Thu, Aug

Re: [DISCUSS] Change default JNDI binding to remove old (legacy) naming

2014-04-22 Thread Tommy Tynjä
Sounds like a good thing to change for the next major version. From a user point of view I think deploying the same EJB jar in two different web applications should just work. Best regards, Tommy Tynjä On Fri, Apr 18, 2014 at 11:27 AM, Jean-Louis Monteiro jlmonte...@tomitribe.com wrote

Re: svn commit: r1581465 - in /tomee/tomee/trunk/tomee/tomee-deb/src/main: groovy/org/apache/tomee/deb/ resources/ resources/control/ resources/init/

2014-03-26 Thread Tommy Tynjä
I'm in favor of having the option to specify version for sudo service tomee if desired. Best regards, Tommy Tynjä On Tue, Mar 25, 2014 at 10:10 PM, Romain Manni-Bucau rmannibu...@gmail.comwrote: Both works but for java in practice alternative doesnt work cause of lifecycles so versioning

Re: OPENEJB-1836 - @Local validation

2014-03-26 Thread Tommy Tynjä
When can one expect this patch to be evaluated? Best regards, Tommy Tynjä On Wed, Mar 19, 2014 at 7:12 AM, Tommy Tynjä to...@diabol.se wrote: I've sent a pull request containing the test case and a spelling fix which the ASF GitHub bot successfully picked up and attached to the issue in JIRA

Re: OPENEJB-1836 - @Local validation

2014-03-26 Thread Tommy Tynjä
://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-03-26 8:42 GMT+01:00 Tommy Tynjä to...@diabol.se: When can one expect this patch to be evaluated? Best regards, Tommy Tynjä On Wed, Mar 19, 2014 at 7:12 AM, Tommy Tynjä to...@diabol.se wrote: I've sent

Re: OPENEJB-1836 - @Local validation

2014-03-19 Thread Tommy Tynjä
I've sent a pull request containing the test case and a spelling fix which the ASF GitHub bot successfully picked up and attached to the issue in JIRA. Best regards, Tommy Tynjä On Mon, Mar 17, 2014 at 8:46 PM, Tommy Tynjä to...@diabol.se wrote: Seems like this case is already covered

OPENEJB-1836 - @Local validation

2014-03-14 Thread Tommy Tynjä
checks in AnnotationDeployer as well, around row 3064. What would be the most preferrable place to insert this validation? Best regards, Tommy Tynjä

Re: Preferred way of submitting code

2014-02-26 Thread Tommy Tynjä
Tommy Tynjä to...@diabol.se: Hi. What is the preferred way to submit code to TomEE? I opened a GitHub pull request for OPENEJB-2071 over two weeks ago after having it reviewed on the dev list but it has still not been merged or even commented on. I noticed there are other pull requests

Re: Preferred way of submitting code

2014-02-26 Thread Tommy Tynjä
: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-02-26 12:57 GMT+01:00 Tommy Tynjä to...@diabol.se: Is reset not sufficent as in https://github.com/tommysdk/tomee/commit

Re: Starting contributing - Validation

2014-02-07 Thread Tommy Tynjä
/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-02-07 Tommy Tynjä to...@diabol.se: Hi. I've now implemented a test case for CheckAsynchronous. Feedback on implementation, code style etc is appreciated before I make a pull request. https

Setting up TomEE in IntelliJ IDEA

2014-02-06 Thread Tommy Tynjä
this? It would be nice to get the project to build and test properly from within the IDE. I'm running IntelliJ IDEA Ultimate 12.1.6 Build #IU-129.1359 with JRE: 1.6.0_37 Best regards, Tommy Tynjä