Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-04 Thread Richard Monson-Haefel
Just to clarify. apache/TomEE is the open source project. It was stared by David Blevins and others in order to provide a lightweight alternative to Java EE servers. Tomitribe is a commercial company that was created to provide support services to companies using TomEE and a couple of other open

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Michael Redlich
Thanks, Ivan! As you may have already seen, Richard explained everything to me! Mike. On Mon, Dec 3, 2018 at 8:20 AM Ivan Junckes Filho wrote: > Hi Michael, I am not sure I understand you question. > > If I get it right, the instructions were in my previous email. > > Can you elaborate? > >

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Ivan Junckes Filho
yw! You should not work on anything related to "tomitribe", the correct repository is apache/tomee. Apache is the owner of the project. https://github.com/apache/tomee On Mon, Dec 3, 2018 at 3:40 PM Michael Redlich wrote: > Thanks, Ivan! > > As you may have already seen, Richard explained

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Michael Redlich
Hi Richard: Thanks for taking the time to outline the process. I certainly appreciate it! My use of git has been somewhat limited to working on my own repositories. Now it makes sense. I originally cloned the *tomitribe\tomee* repository and started making my changes to add the Histogram

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Richard Monson-Haefel
Hi Michael, I might be able to shed some light on this. The process I've used is as follows: 1. I go to the apache/TomEE git hub page and click on "Fork" (its a button on the top right) 2. Select your own account and it will clone the entire TomEE repo to your own account. On my its

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Ivan Junckes Filho
Hi Michael, I am not sure I understand you question. If I get it right, the instructions were in my previous email. Can you elaborate? On Mon, Dec 3, 2018 at 11:07 AM Michael Redlich wrote: > Hi Ivan: > > Ah, OK, cool. I will indeed do that. > > Since I’m new to the open-source community, I

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Michael Redlich
Hi Ivan: Ah, OK, cool. I will indeed do that. Since I’m new to the open-source community, I would appreciate knowing how I would use the forked TomEE repository on my own Github account relative to the repository I cloned on my local machine. I appreciate everyone’s patience as I get myself

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Ivan Junckes Filho
You need to have your own fork. If you don't have it, just go to the apache/tomee address and click "Fork". After that you need to add another remote branch. git remote add For example: git remote add ivan https://github.com/ivanjunckes/tomee.git Or if you use a ssh key: git remote add ivan

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-02 Thread Michael Redlich
Hi Ivan: I just tried to push a new branch to the tomee git repository. When I executed *git push *, I used my own GitHub account for authentication, but knowing that it might fail anyway, I received the following message: *Username for 'https://github.com ': mpredli01*

Re: [TOMEE-2287] Histogram Prometheus Output

2018-11-29 Thread Michael Redlich
Thanks, Richard! Mike. On Thu, Nov 29, 2018 at 1:39 PM Richard Monson-Haefel < monsonhae...@gmail.com> wrote: > Cool to see you getting involved, Mike! Keep it up! > > On Thu, Nov 29, 2018 at 11:14 AM Michael Redlich > wrote: > >> Thanks, Ivan! >> >> Mike. >> >> >> On Thu, Nov 29, 2018 at

Re: [TOMEE-2287] Histogram Prometheus Output

2018-11-29 Thread Richard Monson-Haefel
Cool to see you getting involved, Mike! Keep it up! On Thu, Nov 29, 2018 at 11:14 AM Michael Redlich wrote: > Thanks, Ivan! > > Mike. > > > On Thu, Nov 29, 2018 at 6:41 AM Ivan Junckes Filho > wrote: > > > Hi Michael, > > > > These are some commands that may help you. > > > > #Create a branch

Re: [TOMEE-2287] Histogram Prometheus Output

2018-11-29 Thread Michael Redlich
Thanks, Ivan! Mike. On Thu, Nov 29, 2018 at 6:41 AM Ivan Junckes Filho wrote: > Hi Michael, > > These are some commands that may help you. > > #Create a branch from master > git checkout -b > > #List the remotes you have > git remote -v > > #Create a new remote > git remote add > > #Push

Re: [TOMEE-2287] Histogram Prometheus Output

2018-11-29 Thread Ivan Junckes Filho
Hi Michael, These are some commands that may help you. #Create a branch from master git checkout -b #List the remotes you have git remote -v #Create a new remote git remote add #Push to the remote branch git push On Thu, Nov 29, 2018 at 8:25 AM Michael Redlich wrote: > Hi Romain: >

Re: [TOMEE-2287] Histogram Prometheus Output

2018-11-29 Thread Michael Redlich
Hi Romain: Thanks for all the background information on this! I certainly appreciate it. Mike. On Wed, Nov 28, 2018 at 10:47 AM Romain Manni-Bucau wrote: > Hello Michael, > > in prometheus, histograms are not represented directly like their class > and the prometheus representation is done

Re: [TOMEE-2287] Histogram Prometheus Output

2018-11-29 Thread Michael Redlich
Hi Ivan: Yes, I will clean things up a bit and do that soon. I would also like to try Romain's suggestion. I'm not all that experienced in pushing to a remote branch, so if you could complete the command below, it would be much appreciated. Thanks! *git push* Mike. On Wed, Nov 28, 2018 at

Re: [TOMEE-2287] Histogram Prometheus Output

2018-11-28 Thread Romain Manni-Bucau
Hello Michael, in prometheus, histograms are not represented directly like their class and the prometheus representation is done through an endpoint and not a body writer as per microprofile spec - can likely be enhanced but it is not needed today since you rarely want a single metrics in the

Re: [TOMEE-2287] Histogram Prometheus Output

2018-11-28 Thread Ivan Junckes Filho
Hi Michael, could you please push it to a remote branch so I can take a look? On Wed, Nov 28, 2018 at 1:26 PM Michael Redlich wrote: > Hello everyone: > > I am making progress implementing a Metrics Histogram example. Please see > the following code: > > @Path("/histogram") > @GET >

[TOMEE-2287] Histogram Prometheus Output

2018-11-28 Thread Michael Redlich
Hello everyone: I am making progress implementing a Metrics Histogram example. Please see the following code: @Path("/histogram") @GET @Produces(MediaType.TEXT_PLAIN) // @Produces(MediaType.APPLICATION_JSON) public Histogram histogramStatus() { Metadata metadata = new Metadata("items",