Re: Metrics timer example - PR #218

Right, thanks Jon :) On Wed, Nov 28, 2018 at 8:58 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Maybe the fix is in this PR: https://github.com/apache/tomee/pull/221, and > I need to read all my email first? ;) > > On Wed, Nov 28, 2018 at 10:56 PM Jonathan Gallimore < > jonathan.

Re: Metrics timer example - PR #218

Maybe the fix is in this PR: https://github.com/apache/tomee/pull/221, and I need to read all my email first? ;) On Wed, Nov 28, 2018 at 10:56 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Merged. > > I'll run a build locally. On a slightly different topic, I get a test > failure

Re: Metrics timer example - PR #218

Merged. I'll run a build locally. On a slightly different topic, I get a test failure in mp-metrics-counted - could someone take a look? Here's the error - it looks like a map ordering, so maybe we need to compare the individual JSON elements here: https://github.com/apache/tomee/blob/master/examp

Re: Metrics timer example - PR #218

Hey guys, any commiter could help merging this? It is already appoved. On Tue, Nov 27, 2018 at 2:07 PM Ivan Junckes Filho wrote: > Hey guys, this PR has the goal to provide a @Timed example using > Microprofile Metrics in TomEE8, could you please review and merge? > > https://github.com/apache/

Metrics timer example - PR #218

Hey guys, this PR has the goal to provide a @Timed example using Microprofile Metrics in TomEE8, could you please review and merge? https://github.com/apache/tomee/pull/218 Btw, Romain and Bruno already did a review and I addressed their suggestions.