Re: OpenTracing Zipkin

2019-05-02 Thread Jonathan Gallimore
Here's where zipkin drops this: https://github.com/apache/incubator-zipkin/blob/2.12.9/zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java#L191-L202 - this check isn't included in ZipkinRule: https://github.com/apache/incubator-zipkin/blob/2.12.9/zipkin-junit/src/main/java/

Re: OpenTracing Zipkin

2019-05-02 Thread Jonathan Gallimore
Chasing this one down. Stripping out the binary annotations from the payload to Zipkin looks like it works. I did wire up a test with a ZipkinRule which creates an in-memory instance of Zipkin for the test with a mock web server. That works, but the exact same payload sent to the Zipkin server fail

Re: OpenTracing Zipkin

2019-04-24 Thread Jonathan Gallimore
Thanks Ivan! Applying that now. Jon On Wed, Apr 24, 2019 at 2:45 PM Ivan Junckes Filho wrote: > Hi Jon, config was the one below. But couldn't make it work. Also changing > collector for http://localhost:9411/api/v1/spans does not work as well. > > geronimo.opentracing.span.converter.zipkin.sen

Re: OpenTracing Zipkin

2019-04-24 Thread Ivan Junckes Filho
Hi Jon, config was the one below. But couldn't make it work. Also changing collector for http://localhost:9411/api/v1/spans does not work as well. geronimo.opentracing.span.converter.zipkin.sender=http geronimo.opentracing.span.converter.zipkin.http.collector= http://localhost:9411/api/v2/spans ge

Re: OpenTracing Zipkin

2019-04-24 Thread Jonathan Gallimore
Hey Ivan, What config are you using? I have this setup here with the following properties, and absolutely nothing goes over the wire to ZipKin. I put a debugger on the server and the CDI event for FinishedSpan never gets fired, so nothing gets collected to be sent to ZipKin. I can probably help wi

Re: OpenTracing Zipkin

2019-04-15 Thread Ivan Junckes Filho
Cool, these are good tips I will try both. I didn't try v1 yet. On Mon, Apr 15, 2019 at 5:00 PM Romain Manni-Bucau wrote: > Hmm, missed that but did you try using v1 instead of v2 endpoint? > > Side note: if it helps you to test move the delay to -1 to not wait the > interval. > > Le lun. 15 avr

Re: OpenTracing Zipkin

2019-04-15 Thread Romain Manni-Bucau
Hmm, missed that but did you try using v1 instead of v2 endpoint? Side note: if it helps you to test move the delay to -1 to not wait the interval. Le lun. 15 avr. 2019 à 20:36, Ivan Junckes Filho a écrit : > Romain I was actually using this docker-compose from JL as reference, but > wasn't abl

Re: OpenTracing Zipkin

2019-04-15 Thread Ivan Junckes Filho
Romain I was actually using this docker-compose from JL as reference, but wasn't able to make it work. I will have a look at it again this week, if I have improvement I will let you know. If you have any other tips let me know. Thanks for the reply! On Fri, Apr 12, 2019 at 6:25 PM Romain Manni-

Re: OpenTracing Zipkin

2019-04-12 Thread Romain Manni-Bucau
Hi Ivan Did you debug ZipkinHttp? Depending your server/app config you can need some config like providers etc. This class is a good start to check what is happening. A good config start is https://github.com/jeanouii/microprofile-samples/blob/master/docker-compose.yaml - you can need to inline

OpenTracing Zipkin

2019-04-12 Thread Ivan Junckes Filho
Hey guys I am having a hard time to setup TomEE with OpenTracing 1.0.2 + Zipkin. When I send the payload to the zipkin API http://localhost:9411/api/v2/spans, I keep getting back: 400 - "Expected a JSON_V2 encoded list, but received: JSON_V1" My payload is: [ { "annotations": [ {