Re: Property declarations

2014-10-15 Thread Romain Manni-Bucau
Le 15 oct. 2014 23:04, "Daniel Kasmeroglu" a écrit : > > Hi, > > > > > http://tomee.apache.org/properties-listing.html was created for it and it > > also allow to document dynamic properties > > > How is that list compiled ? Or is it just edited by the corresponding > developers. If so is there a

Re: Property declarations

2014-10-15 Thread Daniel Kasmeroglu
Hi, > > http://tomee.apache.org/properties-listing.html was created for it and it > also allow to document dynamic properties > How is that list compiled ? Or is it just edited by the corresponding developers. If so is there a task ahead of a release which assures that this documentation is stil

Re: Property declarations

2014-10-15 Thread Romain Manni-Bucau
Le 15 oct. 2014 22:47, "Daniel Kasmeroglu" a écrit : > > Hi, > > > > > Dont put it in a Constant.java or Maven.java > > > Okay, there we're having a disagreement as I would create something like > "OpenEJBProperties". > > > Perso i try to create constants only when reusable. The m2 one for instanc

Re: Property declarations

2014-10-15 Thread Daniel Kasmeroglu
Hi, > > Dont put it in a Constant.java or Maven.java > Okay, there we're having a disagreement as I would create something like "OpenEJBProperties". > Perso i try to create constants only when reusable. The m2 one for instance > is almost internal and not that used at runtime so -+0 to have a c

Re: Property declarations

2014-10-15 Thread Romain Manni-Bucau
Too late since it is here since months to not say more...plus you say it cause you think to mvn home but it is really the home for artifacts so name is not shocking for me in openejb context. Le 15 oct. 2014 22:33, "Daniel Kasmeroglu" a écrit : > Just an addendum: The property 'openejb.m2.home'

Re: Property declarations

2014-10-15 Thread Daniel Kasmeroglu
Just an addendum: The property 'openejb.m2.home' is basically misnamed as the home directory is the parent of the 'repository' (the default values are correct). So a better name would be 'openejb.m2.repository'. Best regards Daniel Kasmeroglu

Re: Property declarations

2014-10-15 Thread Romain Manni-Bucau
Le 15 oct. 2014 22:24, "Daniel Kasmeroglu" a écrit : > > Am 15.10.2014 um 22:10 schrieb Romain Manni-Bucau: > > Hmm > > > > Should be in openejb-loader not core. > > > Right. > > > That said ok if it stays localized where used ie maven resolver other -1. > > > I'm not sure what you're meaning with

Re: Property declarations

2014-10-15 Thread Daniel Kasmeroglu
Am 15.10.2014 um 22:10 schrieb Romain Manni-Bucau: > Hmm > > Should be in openejb-loader not core. > Right. > That said ok if it stays localized where used ie maven resolver other -1. > I'm not sure what you're meaning with that. I certainly don't intend to touch the dependencies for these const

Re: Property declarations

2014-10-15 Thread Romain Manni-Bucau
Hmm Should be in openejb-loader not core. That said ok if it stays localized where used ie maven resolver other -1. About the test we should pass it as system prop in surefire, was it your idea? Issue about this test is we dont use maven where the plugin does. It was cause maven harness was brok

Property declarations

2014-10-15 Thread Daniel Kasmeroglu
Hi, While investigating the test runs on my local system I figured that there are some inconsistencies (I'm always customizing my local maven repo). MavenResolver derives the local repository like this: * "openejb.m2.home" fallback to ${user.home}/.m2/repository whereas the TomEEMavenPluginRu