Re: TOMEE-1974 - lost commits

2017-07-05 Thread Romain Manni-Bucau
2017-07-05 12:56 GMT+02:00 Jonathan Gallimore : > I'll recheck whether passing a specific basic authorization header works, > if it does, I'll close the PR and follow up here. If it doesn't, I'll > follow up with more specific details. > > The code change wasn't

Re: TOMEE-1974 - lost commits

2017-07-05 Thread Jonathan Gallimore
I'll recheck whether passing a specific basic authorization header works, if it does, I'll close the PR and follow up here. If it doesn't, I'll follow up with more specific details. The code change wasn't made for no reason though, which would suggest that it doesn't work in the desired way.

Re: TOMEE-1974 - lost commits

2017-07-05 Thread Romain Manni-Bucau
Hi Jon, did you consider making it working without any code change? it does AFAIK. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

TOMEE-1974 - lost commits

2017-07-05 Thread Jonathan Gallimore
Hi A few months back we introduced some functionality to allow the client to authenticate using a basic auth header. https://issues.apache.org/jira/browse/TOMEE-1974. This was merged, but subsequently lost when a script was accidentally executed against the wrong branch, and a git reset --hard