GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/780
TS-4629: Fix use of invalid iterator in ServerSessionPool::purge.
Add postfix increment to IPHashTable::iterator.
You can merge this pull request into a Git repository by running
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/740
I think this should be OK. I was concerned about its interaction with
transparency but the `os_addr_style` values are set up to avoid that (e.g. that
can be moved to values that
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/721#discussion_r67730748
--- Diff: proxy/http/HttpSM.cc ---
@@ -6890,7 +6890,8 @@ HttpSM::update_stats()
int offset = 0;
int skip = 0
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/704
Overall it seems fine to get rid of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/704
Right, the interval is presumed to be seconds, which is why
`HOST_DB_TIMEOUT_INTERVAL` is scaled by `HRTIME_SECOND` when updating the
interval.
---
If your project is set up for it
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/704#discussion_r66988505
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2224,13 +2227,14 @@ put_hostinfo_ClusterFunction(ClusterHandler *ch,
void *data, int /* len ATS_UNUS
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/704
I looked at the code and I am not of the opinion the code assumes
`HOST_DB_TIMEOUT_INTERVAL` is one second. For instance, in
`HostDBContinuation::backgroundEvent` it is explicitly
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66975681
--- Diff: iocore/hostdb/P_RefCountCache.h ---
@@ -0,0 +1,955 @@
+/** @file
+
+ A cache (with map-esque interface) for RefCountObjs
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66975130
--- Diff: iocore/hostdb/P_RefCountCache.h ---
@@ -0,0 +1,955 @@
+/** @file
+
+ A cache (with map-esque interface) for RefCountObjs
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/631#discussion_r65959288
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -1998,6 +1988,19 @@ HostDBContinuation::do_dns()
hostdb_cont_free(this);
return
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r65899492
--- Diff: lib/ts/ink_res_init.cc ---
@@ -503,7 +503,20 @@ ink_res_init(ink_res_state statp, ///< State
object to upd
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r65767037
--- Diff: iocore/hostdb/I_HostDBProcessor.h ---
@@ -139,10 +138,49 @@ struct SRVInfo {
unsigned int key;
};
-struct
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r65764116
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -1593,29 +1437,21 @@ HostDBContinuation::dnsEvent(int event, HostEnt *e
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r65763754
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -1593,29 +1435,22 @@ HostDBContinuation::dnsEvent(int event, HostEnt *e
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/653
The IPv4 and IPv6 addresses are stored in the same hash table because that
was easiest at the time. There's certainly no fundamental reason to do that,
although maybe it helps
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r65651918
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -583,7 +468,7 @@ reply_to_cont(Continuation *cont, HostDBInfo *r, bool
is_srv = false
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r65651692
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -439,37 +327,24 @@ HostDBCache::start(int flags)
Warning("Pleas
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/679
After some discussion with Jason and looking at other parts of the build
tree, I went with "_aux" because that's the convention the doc subtree uses.
Lacking any better
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/686
Seems reasonable to me. I checked the history and both of these seem to
have been put in at the same time, although I can't imagine why both were
needed.
---
If your project i
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/688
The code is very cut and paste - could this not be made a method on
ProxyClientSession to unify and avoid direct access to the VC?
---
If your project is set up for it, you can reply
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/683
Ship it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/679
I'll squash it when I commit it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/673#discussion_r64913857
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -545,57 +545,61 @@ write_to_net_io(NetHandler *nh, UnixNetVConnection
*vc, EThread *thread
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/673#discussion_r64913617
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -545,57 +545,61 @@ write_to_net_io(NetHandler *nh, UnixNetVConnection
*vc, EThread *thread
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/672
TS-4486: Add release to MutexLock.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4486
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/670#issuecomment-221939799
Ship it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/669#issuecomment-221935663
I went through all the changes with Susan and I will +1 these changes.
---
If your project is set up for it, you can reply to this email and have your
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/669#discussion_r64783870
--- Diff: proxy/http/Http1ClientSession.cc ---
@@ -427,9 +427,12 @@ Http1ClientSession::release(ProxyClientTransaction
*trans)
ka_vio
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/663#issuecomment-221594161
Unfortunately `event_` is actually used in `Transaction::initCachedRequest`
to do handle initialization differently for `TS_EVENT_HTTP_TXN_CLOSE`. I don&#
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/663
TS-4481: CPP API - clear handles and reload on demand.
The changes are
* The handles are cleared, not re-initialized, per hook.
* Handles are loaded from the transaction
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/658#issuecomment-221296297
This looks like a good change, because `server_request_hdr_bytes` gets set
on scheduling the initial write and not when the bytes are actually written, so
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/649
TS-4462: Clean up pending_action for TSHttpSchedule.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219788326
After doing more reading here and on the net, I now agree with @pbchou in
his original approach. Core should use `optind = 1` and all the plugins should
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/642#issuecomment-219751045
My point would be the need to carefully explain what the methods do in
different contexts is the problem. "Local" and "remote" are al
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/642#issuecomment-219447229
I would like to avoid "client_addr" and "server_addr" as methods because
those terms are frequently ambiguous. I would much prefer
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/628#discussion_r63227912
--- Diff: mgmt/api/CoreAPI.h ---
@@ -45,10 +45,11 @@ TSProxyStateT ProxyStateGet();
TSMgmtError ProxyStateSet(TSProxyStateT state
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219113313
I spent some time looking at this. I think the change is correct and I
think it must be the plugin responsibility because we don't require plugins to
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/634#issuecomment-219107725
The recipe in `docs/developer/config-vars.en.rst` needs to be updated for
this new structure.
---
If your project is set up for it, you can reply to
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/634#discussion_r63216314
--- Diff: proxy/InkAPI.cc ---
@@ -8175,471 +8177,163 @@ TSHttpTxnConfigStringGet(TSHttpTxn txnp,
TSOverridableConfigKey conf, const char
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/628
TS-4032: Enable command line based message passing to plugins.
This is the second round after PR-343. I made the RPC unpacking changes HRP
recommended. Why they didn't compile b
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-218612497
I changed the RPC unpacking to use the standard mechanism. I don't know why
it didn't compile before and I don't the energy to figure i
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214429372
Yeah. We could look at something similar to the milestone work, a generic
tag that lets you pull out a metric.
---
If your project is set up for it, you
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/577
TS-4046: Prevent memory leak of HTTP heap for server intercept case.
In the case of an intercept plugin the `client_response` can be leaked. I
changed the method used to be `destroy
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r59890598
--- Diff: lib/ts/Diags.cc ---
@@ -716,14 +722,12 @@ Diags::should_roll_outputlog()
bool ret_val = false;
bool
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-210488274
While I think unit tests are in general a good idea, I'm not sure how that
could be done in this case and not in the time frame for committing th
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r5964
--- Diff: lib/ts/Diags.cc ---
@@ -716,14 +722,12 @@ Diags::should_roll_outputlog()
bool ret_val = false;
bool
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-209664725
Yes. We looked at various approaches and decided on this one because there
was already a lock around access to the file descriptor. Locking the update to
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-209628730
Looks good to me. Dan, Jason, and I discussed this at length prior to the
work and this looks in line with our concensus.
---
If your project is set up
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/565#issuecomment-209056115
I'm not sure we need to prevent the implicit conversion to a pointer.
What's important is the inability to touch the member variable in `Ptr` t
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/553#issuecomment-206993375
This seems reasonable. I'm not sure about the 120 for host name size but I
am unable to offer a number with a better pedigree.
---
If your proje
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/272
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/527
TS-4282: Check for _do_read returning undef in AdminClient.pm
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/511#issuecomment-198744974
I added a virtual destructor to `HtmlParser` to get rid of compiler
warnings.
---
If your project is set up for it, you can reply to this email and have
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/527#issuecomment-197579454
Nope, it's wrong - let me fix it (should use `undefined` rather than `==
undef`). Too long since I really worked in Perl.
---
If your project is s
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/527#issuecomment-197578795
I took out {{max_read_attempts}} as well because it was never used. Perhaps
it was originally intended to call {{_do_read}} that many times.
---
If your
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/518#issuecomment-193384712
Ship it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/514#issuecomment-193281511
Quite possible. As usual we had crashes at Y! due to this which I patched
there. Do noteTS-3359 though which caused this problem by fixing other tunnel
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/516
TS-4261: Split stats API from process API.
This splits out the stats update logic from process management so the
former can be compiled/linked separately, avoiding dependency loops
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/515
TS-1775: General hrtime cleanup.
This removes as much as possible references to TS lib hr time functions and
replaces them with calls to {{Thread}}. There are some other minor clean
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/501#issuecomment-192800781
I'm going to -1 this patch because I think it treats the symptoms, not the
problem. The latter seems to be TS-4256.
---
If your project is set up f
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/510#issuecomment-192800683
I presume this is a fix related to the VC migration patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/514
TS-4258: Only null out ua_session if it was in the tunnel when the tunnel
collapsed
You can merge this pull request into a Git repository by running:
$ git pull https
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/513#issuecomment-192758560
Meh. It only happens with certain obscure plugin shenanigans involving
transforms. Unfortunately those are permitted (essentially delaying at certain
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/513
TS-4258: NULL out server_session when it is destroyed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/512
TS-4257: Using original scheme and check for not set in log field cqus
This is two fixes used inside Yahoo!, both to the same method.
{{orig_scheme}} is used to prevent the log field
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/493#issuecomment-192681308
I commented on the bug report but I'll repeat here - having looked at the
code, I think the original is correct and this is not correct. failove
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/507#issuecomment-190986107
+1 from me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/491#issuecomment-186934916
Looks reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/456#issuecomment-181463542
As far as I know, we can't depend on `std::unique_ptr` being available. If
that's changed then yes, we could replace `ats_scoped_str` with `
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/456#issuecomment-181417642
Too late but this is the kind of thing {{ats_scoped_str}} is for.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/446#discussion_r51428533
--- Diff: proxy/logging/LogObject.cc ---
@@ -1043,6 +1044,15 @@
LogObjectManager::_solve_filename_conflicts(LogObject *log_object, int
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/440#issuecomment-176484446
Ultimately I think you'd just want the values in file, one per line. But
that's a bigger fix.
---
If your project is set up for it, you ca
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/433
TS-4137: Stripe inspector enhancements.
Having done more testing with the stripe inspector in production, there are
some minor issues and other data enhancements that proved to be
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/430#discussion_r50420560
--- Diff: proxy/hdrs/URL.cc ---
@@ -1264,7 +1287,7 @@ url_parse_internet(HdrHeap *heap, URLImpl *url, char
const **start, char const
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/425
TS-4134: Fix privilege elevation issues.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4134
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/397
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/397#issuecomment-166929171
Hmmm. I did use it at one point during development of this patch but it
appears that code was removed. I'd prefer to leave it in for future use,
alt
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/397#issuecomment-166794993
It lets the C++ API lock a mutex that is contained in a continuation in a
scoped fashion. The already existing mutex locking mechanisms handle mutexes
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/397
TS-3235: fix crash problem caused by sync problem in PluginVC.
This is an updated version of PR 164 that has been tested in production. It
attempts to fix the related issue in the C
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/396
TS-4094: Clean up RD data in RequestData.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4094
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/387#issuecomment-166020763
I discussed this with Daniel and it seems the correct fix to me.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/385#discussion_r47974057
--- Diff:
doc/developer-guide/plugins/hooks-and-transactions/http-transactions.en.rst ---
@@ -179,6 +179,8 @@ The HTTP transaction functions
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/385
TS-3944: Add documentation for TSHttpTxnServerAddrSet to clarify when it
can be called.
I cannot find any current documentation on this function and so the use is
unclear
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/384
TS-4028: Set TrackerContinuation to clean up.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/381
TS-4056: Remove cached netVC from NetAccept
This is an updated, rebased version of PR 366[1].
[1] https://github.com/apache/trafficserver/pull/366
You can merge this pull
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/272#issuecomment-165182928
See https://issues.apache.org/jira/browse/TS-2375
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/366#issuecomment-162560602
A few questions -
1. Why is it the destruction of a `NetAccept` a concern - I thought that
only happened during process shutdown. Is there a case
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/366#discussion_r46833574
--- Diff: iocore/net/UnixNetAccept.cc ---
@@ -112,9 +106,17 @@ net_accept(NetAccept *na, void *ep, bool blockable)
count = res
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/365
TS-4052: Remove use of deprecated std::auto_ptr.
Rather than figuring out how to integrate `std::unique_ptr` I just tweaked
the CPP API and used that.
You can merge this pull
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/363#issuecomment-162034159
So, something like
```
if (blf != NULL) {
if (blf->open_file() != BaseLogFile::LOG_FILE_NO_ERROR) {
// ...
}
diags_
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/363#issuecomment-162033850
Is `setup_diagslog` marked `private`? If not, it should be if it's called
only from the constructor. Otherwise dropping the assert seems reaso
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/363#issuecomment-162033316
Yes. Looking at the code it seems the better choice would be to keep the
assert and move it after the `NULL` check on `blf`. I would be tempted to
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/350#issuecomment-161358854
Uri - it is not the case that header_rewrite can support the required use
case. There is no hook that is sufficiently early to enable pre-SSL accept
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/350#issuecomment-161026974
James - a `uintptr_t` instead of `ContFlags` would require the assumption a
continuation always runs on the same thread, which is not the case. `ContFlags
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-160998970
I need to work on the documentation a bit more before I send it out for
formal API review. I would also like to build better example / use case code.
It
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-160998361
I hand marshall the message from `traffic_manager` to `traffic_server`
because the technique you suggest did not work for me. What I did was pass the
raw
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/356#issuecomment-160768214
James - so split out `validate_hdr_field` which takes a `char const*` and
make a regression test for that?
The use of `ats_ip_parse` is correct
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/356#discussion_r46189499
--- Diff: proxy/hdrs/HTTP.cc ---
@@ -161,6 +161,14 @@ is_digit(char c)
return ((c <= '9') && (c >= '0
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/337#issuecomment-160731514
Seems reasonable, except we should look at unifying the SSL error reporting
logic - that looks very cut and pasted.
---
If your project is set up for it
1 - 100 of 238 matches
Mail list logo
