[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872895#comment-15872895
]
ASF GitHub Bot commented on TWILL-216:
--
Github user hsaputra commented on the issue:
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872892#comment-15872892
]
Henry Saputra commented on TWILL-216:
-
[~yufeldman] Gah, yeah you are right. I thought
Github user hsaputra commented on the issue:
https://github.com/apache/twill/pull/33
Ah, Yulia just replied on JIRA that we HAD ALREADY used double for the
ratio (not sure why) but this PR just continuing the existing data format.
+1 then
---
If your project is set up for it
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872884#comment-15872884
]
Yuliya Feldman commented on TWILL-216:
--
[~hsaputra] What is your concern regarding dou
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872882#comment-15872882
]
ASF GitHub Bot commented on TWILL-216:
--
Github user hsaputra commented on the issue:
Github user hsaputra commented on the issue:
https://github.com/apache/twill/pull/33
@chtyim I was asking concern about the selection of double vs float
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terence Yim updated TWILL-216:
--
Fix Version/s: 0.10.0
> Make ratio between total memory and on-heap memory configurable
> ---
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872876#comment-15872876
]
ASF GitHub Bot commented on TWILL-216:
--
Github user chtyim commented on the issue:
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/33
LGTM. Will merge it when build pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872281#comment-15872281
]
Yuliya Feldman commented on TWILL-216:
--
Sorry, missed one style change. Will update PR
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872275#comment-15872275
]
Yuliya Feldman commented on TWILL-216:
--
[~chtyim] Thank you for the reviews, I have up
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872256#comment-15872256
]
ASF GitHub Bot commented on TWILL-216:
--
Github user yufeldman commented on a diff in t
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101817212
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/json/TwillRuntimeSpecificationCodec.java
---
@@ -94,6 +96,8 @@ public TwillRuntimeSpecification
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872042#comment-15872042
]
ASF GitHub Bot commented on TWILL-216:
--
Github user chtyim commented on a diff in the
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872043#comment-15872043
]
ASF GitHub Bot commented on TWILL-216:
--
Github user chtyim commented on a diff in the
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872041#comment-15872041
]
ASF GitHub Bot commented on TWILL-216:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101789099
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/json/TwillRuntimeSpecificationCodec.java
---
@@ -94,6 +96,8 @@ public TwillRuntimeSpecification de
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101789313
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -17,6 +17,8 @@
*/
package org.apache.twill.yarn;
+im
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101789920
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -38,7 +38,6 @@
import com.google.common.util.c
[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871441#comment-15871441
]
ASF GitHub Bot commented on TWILL-216:
--
Github user hsaputra commented on a diff in th
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101708864
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -59,19 +59,21 @@
private final int instanceCount;
21 matches
Mail list logo
