Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101708864
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -59,19 +59,21 @@
private final int instanceCount;
private final JvmOptions jvmOpts;
private final int reservedMemory;
+ private final Double heapToReservedRatio;
private final Location secureStoreLocation;
public TwillContainerLauncher(RuntimeSpecification runtimeSpec,
ContainerInfo containerInfo,
ProcessLauncher.PrepareLaunchContext
launchContext,
ZKClient zkClient, int instanceCount,
JvmOptions jvmOpts, int reservedMemory,
- Location secureStoreLocation) {
+ Location secureStoreLocation, Double
heapToReservedRatio) {
--- End diff --
do we need double here? Would float be ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
