[GitHub] incubator-weex pull request #228: + [ios] add feature timer

2017-04-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: reply:How to improve the animation in weex

2017-04-07 Thread jerry.s
Hi,Adam: Because new method add one parameter .vue and rax also use old setimeout and setInterval. These jsfm methods are not modified. If these methods are changed . we can use new methods to replace old methods. Best Regards Jerry > 在 2017年4月7日,下午10:45,jerry.s 写道: > > Hi,Wenhong: > > If

Re: reply:How to improve the animation in weex

2017-04-07 Thread jerry.s
Hi,Wenhong: If developer want to realize continuous animation in Weex. The usual way is trough call settimeout. when spirit move to assigned address in setting time. then call settimeout. the timer performance is the key point to improve animation performance with the spirit move frequently a

[GitHub] incubator-weex pull request #191: * [android] prevent the NullPointerExcepti...

2017-04-07 Thread sospartan
Github user sospartan commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/191#discussion_r110369848 --- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKManager.java --- @@ -218,7 +218,11 @@ public static WXSDKManager getInstance() { }

[GitHub] incubator-weex pull request #217: [android] disable click event when gesture...

2017-04-07 Thread sospartan
Github user sospartan commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/217#discussion_r110367811 --- Diff: android/sdk/src/main/java/com/taobao/weex/ui/view/gesture/WXGesture.java --- @@ -309,12 +320,14 @@ public boolean onTouch(View v, MotionE

[GitHub] incubator-weex issue #234: * [android] single picker improvement

2017-04-07 Thread weex-bot
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/234 Warnings :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/

[GitHub] incubator-weex pull request #234: * [android] single picker improvement

2017-04-07 Thread misakuo
GitHub user misakuo opened a pull request: https://github.com/apache/incubator-weex/pull/234 * [android] single picker improvement more option for single picker: - title - titleColor - titleBackgroundColor - confirmTitle - confirmTitleColor - cancelTitle

[GitHub] incubator-weex pull request #233: + [ios] picker support custom title title ...

2017-04-07 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/233 + [ios] picker support custom title title color background color and etc + [ios] picker support custom title titleColor cancelTitle confirmTitle cancelTitleColor

How elegant weex support component without view

2017-04-07 Thread 杨胜涛
Dear all, Because there are a lot of business using virtual node which is a component without view. Based on the current implementation on iOS, it can be implemented by the following way. override this method - (void)insertSubview:(WXComponent *)subcomponent atIndex:(NSInteger)index But this wa

Re: [GitHub] incubator-weex pull request #210: * [ios] the new slider component which is ...

2017-04-07 Thread 刘洪峰(孤剑)
I agree with your opinion. So, I add a component named cycleslider, and keep the original slider component. >From now on we only maintain cycleslider, no longer maintain slider. All new >features are only added to cycleslider. I added an attribute of setting pages to cycle, which is named “infin

Re: reply:How to improve the animation in weex

2017-04-07 Thread Wenhong Wu
since the obvious overhead to change to weex module, it seems direct JS-Binding make sense to any C operations to improve performance :) RequestAnimationFrame was used to coordinate multiple operation/animation in the same page, while setTimeout focusing on specific one, looks they are two dimensio

Re: reply:How to improve the animation in weex

2017-04-07 Thread 刘洋(凯冯)
Hi adam, Thank you for yourappreciation. I noticed that there are severalimplementations of setTimeout. the first: setTimeoutNativeas aglobal function It's used in the virtual-DOM diff flush agorithm. the second: Timer module (aka.WXTimerModule) as a Weex Module written in Java It’s used by JS