Re: [jira] Assigned: (WICKET-975) Update ImageButton to handle ResourceReferenc

2007-11-02 Thread Gerolf Seitz
unfortunately i won't have time either. i got a rather difficult exam lined up for the coming wednesday. maybe someone else can deal with this for rc1? Gerolf On Nov 3, 2007 7:49 AM, Igor Vaynberg (JIRA) <[EMAIL PROTECTED]> wrote: > > [ > https://issues.apache.org/jira/browse/WICKET-975?page

passed the 600 unit tests....!!

2007-11-02 Thread Johan Compagner
700 here we come! johan

Re: Replacing with

2007-11-02 Thread Matej Knopp
It is. Unfortunately we have to serve xhtml document with html mime type, which is something firefox can not seem to digest, even with valid doctype. -Matej On 11/3/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > umm, so? that stuff is legal under xhtml which is what most apps are > built with now

Re: Replacing with

2007-11-02 Thread Matej Knopp
See reply below: On 11/3/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > I think this change is controversial: several people have voiced their > concerns regarding this change. It is something we have been opposed > to until very recently (label with ). You propose to change > markup that is ou

Re: Replacing with

2007-11-02 Thread Igor Vaynberg
umm, so? that stuff is legal under xhtml which is what most apps are built with now, correct? -igor On 11/2/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > From the firefox bugzilla [1]: > > Resolving INVALID. To cut a long story short, remember that if you're serving > this kind of markup as

Re: Replacing with

2007-11-02 Thread Matej Knopp
How is this relevant? You can't serve anything as text/xml or application/xml, unless you treat ie specially. I never said It's a bug in firefox, I now the behavior is intentional. But it doesn't matter for wicket, as we require that the markup is well formed (to a certain degree, e.g. not closed

Re: Replacing with

2007-11-02 Thread Martijn Dashorst
I think this change is controversial: several people have voiced their concerns regarding this change. It is something we have been opposed to until very recently (label with ). You propose to change markup that is outside Wicket's control, I think that is a slippery slope and I advise against it,

Re: Replacing with

2007-11-02 Thread Martijn Dashorst
>From the firefox bugzilla [1]: Resolving INVALID. To cut a long story short, remember that if you're serving this kind of markup as text/html, it will be accepted by older user-agents and probably throw a monkey wrench into their parsing. If you don't care about these user-agents, you should ju

Re: Replacing with

2007-11-02 Thread Igor Vaynberg
i am +1 to fix this. a) we already support which expands to - give that is a wicket component, but still b) and are semantically equivalent and thats how browsers represent tags internally anyways c) it solves a class of problems that is hard as hell to debug/find d) it makes our ajax support

Re: Replacing with

2007-11-02 Thread Matej Knopp
See reply below On 11/2/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > -0.9 on 'fixing' something that is b0rken in an external browser. I > don't mind having fixes in javascript libraries to wrinkle out > inconsistencies or work around bugs: these are local to the > functionality in the js lib

Re: Replacing with

2007-11-02 Thread Martijn Dashorst
-0.9 on 'fixing' something that is b0rken in an external browser. I don't mind having fixes in javascript libraries to wrinkle out inconsistencies or work around bugs: these are local to the functionality in the js libraries. 'Fixing' HTML feels like fixing Java code for our users. If for some rea

Re: Replacing with

2007-11-02 Thread Matej Knopp
But we already do that. Part of Wicket as framework is to shield you from browser inconsistencies and this is one of them. -Matej On 11/2/07, Philip A. Chapman <[EMAIL PROTECTED]> wrote: > Agreed. I understood from previous threads that it was not a developer > error, but a firefox error. If we

Re: Replacing with

2007-11-02 Thread Matej Knopp
This doesn't really lead anywhere. I haven't heard a single argument against replacing with except people being anxious of wicket touching the markup. But you should realize that without this, you can't even put inside markup because it breaks the DOM in firefox. So what's the point? I really

Re: Replacing with

2007-11-02 Thread Philip A. Chapman
Agreed. I understood from previous threads that it was not a developer error, but a firefox error. If we start going down this path, it is likely to get slippery indeed. I'd rather not see wicket modify markup any more than absolutely required. Are we going to "fix" code that breaks on all brow

Re: Replacing with

2007-11-02 Thread Juergen Donnerstag
A Html error finder (IMarkupFilter) already exists but is disabled by default. We could extend it or create a new one. Actually anybody can create it and provide it to us. Juergen

Re: Replacing with

2007-11-02 Thread Erik van Oosten
It does not matter who is making the error, John is still right imho. Regards, Erik. Matej Knopp wrote: Okay. Again. This is not about developer making error! Code like this: Something Is perfectly legal. However, firefox interprets it as Something ... Which is completely wron

Re: Replacing with

2007-11-02 Thread David Bernard
I fight against this/similar problem in 2 cases: * for wicketstuff-jquery, some component use a handler (D&D) create an hanlder in html is a simple => create css/dom problem, spare some time to find that I must replace it by with a space (iirc but I may did a mistake, wicket convert the with

Re: Replacing with

2007-11-02 Thread Matej Knopp
Okay. Again. This is not about developer making error! Code like this: Something Is perfectly legal. However, firefox interprets it as Something ... Which is completely wrong. This is not correcting developer error! This is correcting browser error. And such thing is very difficult to

Re: Wicket User Group Stockholm on Monday!

2007-11-02 Thread Eelco Hillenius
On 11/2/07, Björn Fant <[EMAIL PROTECTED]> wrote: > Hi, anyone of you Swedish wicket developers interested in getting > together on Monday for an evening session? http://wicket.jalbum.net/ > > We are having our first meeting on Monday November 5 where we will > discuss Wicket and our applications.

Re: svn commit: r591368 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/n avigation/paging/IPageable.java

2007-11-02 Thread Martin Grigorov
Let it be IClusterable. please. On Fri, 2 Nov 2007, [EMAIL PROTECTED] wrote: Author: ivaynberg Date: Fri Nov 2 08:37:31 2007 New Revision: 591368 URL: http://svn.apache.org/viewvc?rev=591368&view=rev Log: make ipageable serializable because we keep direct references to it Modified: wick

Re: Replacing with

2007-11-02 Thread Philip A. Chapman
I agree with this stance. On Fri, 2007-11-02 at 09:19 -0600, John Ray wrote: > I got bit by this problem yesterday. Although I was just previewing the > page in the browser by loading the HTML file directly. Since Wicket > wasn't running it wouldn't have mattered if it fixed my div tag for me >

Re: Replacing with

2007-11-02 Thread John Ray
I got bit by this problem yesterday. Although I was just previewing the page in the browser by loading the HTML file directly. Since Wicket wasn't running it wouldn't have mattered if it fixed my div tag for me or not. I'd rather see Wicket not modify the HTML as it's then starting down the s

Wicket User Group Stockholm on Monday!

2007-11-02 Thread Björn Fant
Hi, anyone of you Swedish wicket developers interested in getting together on Monday for an evening session? http://wicket.jalbum.net/ We are having our first meeting on Monday November 5 where we will discuss Wicket and our applications. Per Ejeklint will present his latest project, using