Re: 1.4-rc3 - need help testing

2009-04-28 Thread Igor Vaynberg
i believe he meant to roll another release from trunk and call it rc4 :) i think if we are going to do that we might as well call it rc3. the idea is that if there are no problems with an rc release we promote that release to final, so it should be as bug free as possible. -igor On Tue, Apr 28,

Re: 1.4-rc3 - need help testing

2009-04-28 Thread Jeremy Thomerson
Martijn, I'm sorry - not entirely sure I understand what you meant when you were talking about rc4... Did you mean that we should rebuild rc3 from trunk so that it could hopefully be the final? -- Jeremy Thomerson http://www.wickettraining.com On Wed, Apr 29, 2009 at 1:04 AM, Martijn Dash

Re: 1.4-rc3 - need help testing

2009-04-28 Thread Martijn Dashorst
I'd suggest rolling rc4 from here. And promote that one to 1.4 final if no npe or other trouble appears. It is a *release* candidate so we should aim for bug free. Martijn On Tuesday, April 28, 2009, Jeremy Thomerson wrote: > Was it something that you feel is important enough to force a rebuild

Re: 1.4-rc3 - need help testing

2009-04-28 Thread Juergen Donnerstag
Since it is a rc release and not a final one, I agree with you. Juergen

Re: 1.4-rc3 - need help testing

2009-04-28 Thread Jeremy Thomerson
Was it something that you feel is important enough to force a rebuild of rc3? (my money is on no - since it was previously unreported for however long it has been in trunk and based on the time it will take to rebuild the release) -- Jeremy Thomerson http://www.wickettraining.com On Tue, Apr

Re: 1.4-rc3 - need help testing

2009-04-28 Thread Juergen Donnerstag
fixed Juergen

Re: 1.4-rc3 - need help testing

2009-04-28 Thread Juergen Donnerstag
current 1.4 trunk fails with ERROR - RequestCycle - Error attaching this container for renderin g: [MarkupContainer [Component id = panels]] org.apache.wicket.WicketRuntimeException: Error attaching this container for ren dering: [MarkupContainer [Component id = panels]] at

Re: 1.4-rc3 - need help testing

2009-04-28 Thread bckfnn
Jeremy Thomerson-5 wrote: > > I built the 1.4-rc3 release, but have not had time to test it > extensively. > I've tried your m2 repo using ivy in my project. Both 1.4-rc3 and your build works without a flaw. -- View this message in context: http://www.nabble.com/1.4-rc3---need-help-testin

Re: [vote] release wicket 1.3.6

2009-04-28 Thread Igor Vaynberg
http://people.apache.org/~ivaynberg/wicket-1.3.6/dist/KEYS -igor On Tue, Apr 28, 2009 at 12:46 AM, Martijn Dashorst wrote: > On Mon, Apr 27, 2009 at 5:10 PM, Igor Vaynberg > wrote: >>>  - validation of the archive works, but there is no public key in KEYS >>> [1] to verify that the fingerprint

Re: [vote] release wicket 1.3.6

2009-04-28 Thread Igor Vaynberg
set the fix version to 1.3.7 unless you want to do the rebuild. -igor On Tue, Apr 28, 2009 at 6:28 AM, Johan Compagner wrote: > this one: > > https://issues.apache.org/jira/browse/WICKET-2215 > > says it is fixed for 1.3.6 > > but that isnt true, that one wasnt backported. I just did that > So w

Re: Have some ideas--how to discuss?

2009-04-28 Thread Igor Vaynberg
actually it wouldnt be stored in the data field, thats the great advantage of it. you are forced to declare it with the correct type and provide correct getters and setters eg class edituserpanel extends panel { private imodel model; // getter setter } -igor On Tue, Apr 28, 2009 at 3:19 AM,

Re: 1.4-rc3 - need help testing

2009-04-28 Thread Jeremy Thomerson
Anyone have a chance to look at this? Are we just focusing on the 1.3.6 release right now? -- Jeremy Thomerson http://www.wickettraining.com On Sun, Apr 26, 2009 at 10:14 PM, Jeremy Thomerson wrote: > I built the 1.4-rc3 release, but have not had time to test it > extensively.  I did test th

Re: [vote] release wicket 1.3.6

2009-04-28 Thread Johan Compagner
this one: https://issues.apache.org/jira/browse/WICKET-2215 says it is fixed for 1.3.6 but that isnt true, that one wasnt backported. I just did that So we do a rebuild or have to set the fixed version to 1.3.7 On Tue, Apr 28, 2009 at 09:52, Martijn Dashorst wrote: > +1 release it > > On Mon

[WICKET-2215] - WebClientInfo does not set browerMajorVersion for IE8

2009-04-28 Thread Mat Johns
Hi, I submitted a bug and small patch to JIRA, earlier in the month to fix WebClientInfo to correctly pick and set the browserMajorVersion correctly for IE8 (currently falls through to default -1). Juergen as already tweaked and applied the patch to trunk, however I think that it probably ne

Re: Have some ideas--how to discuss?

2009-04-28 Thread Willis Blackburn
Igor, I'm glad to hear that! I hadn't thought of removing the IModel reference from Component, but that's a good idea. I think that you'd want to keep the model reference itself inside Component, using the data field as it exists now, but make the access methods protected. My original t

Re: [vote] release wicket 1.3.6

2009-04-28 Thread Martijn Dashorst
+1 release it On Mon, Apr 27, 2009 at 7:47 PM, Igor Vaynberg wrote: > [X] Yes release 1.3.6 > > -igor > > > On Sun, Apr 26, 2009 at 10:59 PM, Igor Vaynberg > wrote: >> I've created a release for Wicket 1.3.6. You can download the release >> from the usual location: >> >> dist: http://people.apa

Re: [vote] release wicket 1.3.6

2009-04-28 Thread Martijn Dashorst
On Mon, Apr 27, 2009 at 5:10 PM, Igor Vaynberg wrote: >>  - validation of the archive works, but there is no public key in KEYS >> [1] to verify that the fingerprint matches our Igor. > i was wondering where the keys were stored... added Can you also put the KEYS file in the root folder where the