Re: Add onAddToPage() to Component

2014-08-18 Thread Carl-Eric Menzel
On Mon, 18 Aug 2014 13:30:03 +0200 Martin Grigorov wrote: > I don't like the whole idea of re-adding component. > Wizard is the only component in Wicket distro which fails > the > org.apache.wicket.core.util.objects.checker.OrphanComponentChecker. I > think only the data (i.e. the models) should

Re: Add onAddToPage() to Component

2014-08-18 Thread Martin Grigorov
I don't like the whole idea of re-adding component. Wizard is the only component in Wicket distro which fails the org.apache.wicket.core.util.objects.checker.OrphanComponentChecker. I think only the data (i.e. the models) should be kept around and the components should be re-created for every view

Re: ETA for 6.17.0 ?

2014-08-18 Thread Martijn Dashorst
I can't promise a specific date/time, but I intent to do so this week (tonight, tomorrow, ...) The issue is project deadline and having to figure out user right management on my NAS and a shared iPhoto library (not a good idea with named users and a wrong default umask). Martijn On Mon, Aug 18,

Re: Add onAddToPage() to Component

2014-08-18 Thread Carl-Eric Menzel
One difficulty I am finding: If I do not simply fire onAdd for everything that gets added, then I have to differentiate. What do I do if I re-add a container that is already initialized, so its onReAdd should be called, but which has a new child that is not initialized? Which event should happen i

Re: Add onAddToPage() to Component

2014-08-18 Thread Martin Grigorov
Wait for some more opinions. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Aug 18, 2014 at 12:38 PM, Carl-Eric Menzel wrote: > On Mon, 18 Aug 2014 11:49:51 +0200 > Martin Grigorov wrote: > > > Hi, > > > > I still find it confusing :-/ > > > > 1) with th

Re: Add onAddToPage() to Component

2014-08-18 Thread Carl-Eric Menzel
On Mon, 18 Aug 2014 11:49:51 +0200 Martin Grigorov wrote: > Hi, > > I still find it confusing :-/ > > 1) with this we will have: the constructor, onInitialize() and > onAddToPage() being called as component initializers. Way too much > IMO. onInitialize() and onAddToPage() are exactly the same

Re: git commit: re-create fence mark after remove and re-add

2014-08-18 Thread Carl-Eric Menzel
Will do, just forgot it here. Carl-Eric On Mon, 18 Aug 2014 12:20:49 +0200 Martin Grigorov wrote: > On Mon, Aug 18, 2014 at 11:50 AM, wrote: > > > Repository: wicket > > Updated Branches: > > refs/heads/WICKET-5265 [created] 9c60d34e3 > > > > > > > Please use WICKET-5265 in the commit messa

Re: git commit: re-create fence mark after remove and re-add

2014-08-18 Thread Martin Grigorov
On Mon, Aug 18, 2014 at 11:50 AM, wrote: > Repository: wicket > Updated Branches: > refs/heads/WICKET-5265 [created] 9c60d34e3 > > > Please use WICKET-5265 in the commit message It is used to link the commit with the ticket (the auto comments in the tickets) and for debugging later (e.g. 3 year

Re: Add onAddToPage() to Component

2014-08-18 Thread Martin Grigorov
Hi, I still find it confusing :-/ 1) with this we will have: the constructor, onInitialize() and onAddToPage() being called as component initializers. Way too much IMO. onInitialize() and onAddToPage() are exactly the same thing at this stage. 2) onRemove() is not named onRemoveFromPage(). (I do

Add onAddToPage() to Component

2014-08-18 Thread Carl-Eric Menzel
Hi everybody, I am currently dealing with https://issues.apache.org/jira/browse/WICKET-5265: A FencedFeedbackPanel marks the component it uses as a fence with a metadata entry, so that outer FencedFeedbackPanels do not traverse beyond that component to "steal" feedback messages. When an FFP is re

ETA for 6.17.0 ?

2014-08-18 Thread Martin Grigorov
Hi Martijn, Any idea when you can cut Wicket 6.17.0/7.0.0-M3 ? Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov

[GitHub] wicket pull request: make CI build faster

2014-08-18 Thread PeterDaveHello
Github user PeterDaveHello commented on the pull request: https://github.com/apache/wicket/pull/75#issuecomment-52460972 You're welcome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] wicket pull request: make CI build faster

2014-08-18 Thread martin-g
Github user martin-g commented on the pull request: https://github.com/apache/wicket/pull/75#issuecomment-52459442 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] wicket pull request: make CI build faster

2014-08-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl