[GitHub] wicket pull request: Make DateLabel implement IGenericComponentDa...

2015-02-25 Thread klopfdreh
Github user klopfdreh commented on the pull request: https://github.com/apache/wicket/pull/101#issuecomment-76130209 This PR can be closed due to https://github.com/apache/wicket/commit/ad11f1277684165e64759b10d3c14c40cbe2e79d Thank you @tkruse --- If your project is set up

Re: [DISCUSSION] WICKET-5823 IAuthenticationStrategy methods

2015-02-25 Thread Maxim Solodovnik
In the patch for Wicket 7.x in WICKET-5823 you added a new method to the API, instead of replacing the old one. Having several #save() methods didn't look OK to me. sorry for that, I was afraid to break all existing code (wasn't aware varargs param will not be API break) #save(String,

Re: [DISCUSSION] WICKET-5823 IAuthenticationStrategy methods

2015-02-25 Thread Martin Grigorov
Hi Maxim, On Tue, Feb 24, 2015 at 6:09 PM, Maxim Solodovnik solomax...@gmail.com wrote: Hello All, recently I have proposed the patch to reduce copy/paste while implementing custom IAuthenticationStrategy. https://issues.apache.org/jira/browse/WICKET-5823 Actually this interface have 2