Re: [DISCUSSION] Remove .settings of projects in github

2015-03-05 Thread Tobias Soloschenko
Ah, now I see. Thank you for the explanation! :-) @Emond: Would you be so kind and have a look if the way I configured it in the branch https://github.com/klopfdreh/wicket/tree/WICKET-5848 is like intended? @Martin: Is somewhere a still existing preference (org.eclipse.jdt.ui.prefs) which sh

Re: [DISCUSSION] Remove .settings of projects in github

2015-03-05 Thread Martin Grigorov
https://github.com/apache/wicket/commit/9852fc794d7e961ce408ee46641ded2699d22dbe Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Mar 5, 2015 at 10:19 AM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > Ah, now I see. Thank you for the explana

Re: [DISCUSSION] Remove .settings of projects in github

2015-03-05 Thread Emond Papegaaij
Hi Tobias, It seems you are missing the additionalConfig section in the maven-eclipse- plugin configuration. You need to list .prefs files from which settings need to be copied: .settings/org.eclipse.core.resources.prefs /org.eclipse.core.resources.prefs ... location is

Re: [DISCUSSION] Remove .settings of projects in github

2015-03-05 Thread Tobias Soloschenko
Hi, I removed the parent of wicket-eclipse-settings, because otherwise the plugin tries to apply the wicket-eclipse-settings to itself, which is simply not working. :-) I added the additionalConfig section and put in the org.eclipse.jdt.core.prefs and checked the location in the jar which is

Re: [DISCUSSION] Remove .settings of projects in github

2015-03-05 Thread Emond Papegaaij
m2e cannot resolve plugin dependencies from your workspace, so your observation is correct. I don't think this is a big deal, because settings don't change very often. Perhaps it's best to keep this settings artifact completely separate from the wicket modules itself, in a subdirectory, with it

Re: [DISCUSSION] Remove .settings of projects in github

2015-03-05 Thread Tobias Soloschenko
Ok, I changed the parent pom and removed wicket-eclipse-settings from the list of modules and changed the version number to 1. Someone has to upload version 1 into the central repository, before the commit is applied to wicket-master - otherwise there would be a lot of errors while importing th

Re: [DISCUSSION] Remove .settings of projects in github

2015-03-05 Thread Tobias Soloschenko
One last thing. We have to adjust the servlet-api version in the web.xml of wicket-example and other web modules (examples version is changed with the media tags branch) - otherwise the project is created as dynamic web module with version 2.5 through the m2e wtp integration. kind regards Tob

[GitHub] wicket pull request: Wicket 5848

2015-03-05 Thread klopfdreh
GitHub user klopfdreh opened a pull request: https://github.com/apache/wicket/pull/104 Wicket 5848 For more information see: Ticket: https://issues.apache.org/jira/browse/WICKET-5848 Discussion: http://apache-wicket.1842946.n4.nabble.com/DISCUSSION-Remove-settings-of-projec

[GitHub] wicket pull request: WICKET-5850 Fix class loading issue in LazyIn...

2015-03-05 Thread shuraa
GitHub user shuraa opened a pull request: https://github.com/apache/wicket/pull/105 WICKET-5850 Fix class loading issue in LazyInitProxyFactory You can merge this pull request into a Git repository by running: $ git pull https://github.com/shuraa/wicket wicket-6.x Alternative

[GitHub] wicket pull request: WICKET-5850 Fix class loading issue in LazyIn...

2015-03-05 Thread shuraa
GitHub user shuraa opened a pull request: https://github.com/apache/wicket/pull/106 WICKET-5850 Fix class loading issue in LazyInitProxyFactory You can merge this pull request into a Git repository by running: $ git pull https://github.com/shuraa/wicket master Alternatively y

[GitHub] wicket pull request: WICKET-5850 Fix class loading issue in LazyIn...

2015-03-05 Thread klopfdreh
Github user klopfdreh commented on the pull request: https://github.com/apache/wicket/pull/105#issuecomment-77519903 It's integrated: https://github.com/apache/wicket/commit/c0f187b57cb55151db775306a70c57cb3d1d3f4e Can be closed. --- If your project is set up for it, you can

[GitHub] wicket pull request: WICKET-5850 Fix class loading issue in LazyIn...

2015-03-05 Thread klopfdreh
Github user klopfdreh commented on the pull request: https://github.com/apache/wicket/pull/106#issuecomment-77519983 It's integrated: https://github.com/apache/wicket/commit/73b8ebf87d6d21a72bfd9cd21a961e2b260f6591 Can be closed. --- If your project is set up for it, you can