m2e cannot resolve plugin dependencies from your workspace, so your observation is correct. I don't think this is a big deal, because settings don't change very often. Perhaps it's best to keep this settings artifact completely separate from the wicket modules itself, in a subdirectory, with its own version and parent. We can release 1.0 (simply 1?) and keep it that way until a change is needed.
Best regards, Emond On Thursday 05 March 2015 10:15:47 Tobias Soloschenko wrote: > Hi, > > I removed the parent of wicket-eclipse-settings, because otherwise the > plugin tries to apply the wicket-eclipse-settings to itself, which is > simply not working. :-) > > I added the additionalConfig section and put in the > org.eclipse.jdt.core.prefs and checked the location in the jar which is > "/org.eclipse.jdt.core.prefs" > > I installed the eclipse plugin from the markedplace. > > The only issue left is that you can't add a dependency only located in > your workspace. If I install wicket-eclipse-settings with "clean > install" and give it a right number like 1.0 and change the dependencies > like the following block - everything is fine (but with SNAPSHOT it is > not working): > > <dependencies> > ... > <dependency> > <groupId>org.apache.wicket</groupId> > <artifactId>wicket-eclipse-settings</artifactId> > <version>1.0</version> > </dependency> > ... > </dependencies> > ... > <plugin> > <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-eclipse-plugin</artifactId> > <version>2.9</version> > <configuration> > <downloadSources>true</downloadSources> > <additionalConfig> > <file> > <name>.settings/org.eclipse.jdt.core.prefs</name> > <location>/org.eclipse.jdt.core.prefs</location> > </file> > </additionalConfig> > </configuration> > <dependencies> > <dependency> > <groupId>org.apache.wicket</groupId> > <artifactId>wicket-eclipse-settings</artifactId> > <version>1.0</version> > </dependency> > </dependencies> > </plugin> > > kind regards > > Tobias > > Am 05.03.15 um 09:52 schrieb Emond Papegaaij: > > Hi Tobias, > > > > It seems you are missing the additionalConfig section in the > > maven-eclipse- > > plugin configuration. You need to list .prefs files from which settings > > need to be copied: > > <additionalConfig> > > > > <file> > > > > <name>.settings/org.eclipse.core.resources.prefs</name> > > <location>/org.eclipse.core.resources.prefs</location> > > > > </file> > > ... > > > > </additionalConfig> > > > > location is the location of the .prefs file in the jar, name is the > > location of the .prefs file relative to the project (so always starts > > with .settings/). > > > > Note that the m2e-settings plugin only uses the maven-eclipse-plugin > > configuration as a container for its configuration. You should not run mvn > > eclipse:eclipse. > > > > Best regards, > > Emond > > > > On Thursday 05 March 2015 09:19:07 Tobias Soloschenko wrote: > >> Ah, now I see. Thank you for the explanation! :-) > >> > >> @Emond: Would you be so kind and have a look if the way I configured it > >> in the branch https://github.com/klopfdreh/wicket/tree/WICKET-5848 is > >> like intended? > >> > >> @Martin: Is somewhere a still existing preference > >> (org.eclipse.jdt.ui.prefs) which shows how the code style formatting has > >> been applied before it has been removed from version control? I would > >> simply copy the file into the "files" folder of wicket-eclipse-settings > >> and as I understood eclipse then takes the setting for each project > >> which has the wicket/pom.xml with the maven-eclipse-plugin as parent. > >> > >> kind regards > >> > >> Tobias > >> > >> Am 05.03.15 um 08:16 schrieb Emond Papegaaij: > >>> Hi Tobias, > >>> > >>> This is a limitation (and feature) of the plugin. It does not simply > >>> copy > >>> files, but transfers settings. You can only use it with actual > >>> properties- > >>> files and existing settings. Eclipse does not like it when plugins > >>> overwrite settings files, so the plugin uses the actual eclipse > >>> preference API. > >>> > >>> Best regards, > >>> Emond > >>> > >>> On Wednesday 04 March 2015 23:45:21 Tobias Soloschenko wrote: > >>>> Hi Emond, > >>>> > >>>> I tried to get the plugin working for me but I failed. Maybe I missed > >>>> something. > >>>> > >>>> https://github.com/klopfdreh/wicket/commit/1f3ca3ffe2ba7633339719824fb5 > >>>> e1 > >>>> 219 7bcb243#diff-600376dffeb79835ede4a0b285078036R247 > >>>> > >>>> Here is the root pom.xml > >>>> > >>>> https://github.com/klopfdreh/wicket/blob/1f3ca3ffe2ba7633339719824fb5e1 > >>>> 21 > >>>> 97b cb243/pom.xml > >>>> > >>>> 1. I added a submodule wicket-eclipse-settings with a folder called > >>>> files and put in an empty file "test" > >>>> 2. I added the module to the list of modules > >>>> <modules><module>wicket-eclipse-settings</module>........</modules> > >>>> 3. Then I added the dependency of wicket-eclipse-settings to the > >>>> project > >>>> dependencies and the maven-eclipse-plugin dependencies and placed in > >>>> additionalConfig to copy the "test"-file at the right position > >>>> > >>>> What I expected is that the test file is copied to > >>>> <working-dir>/wicket-core/.settings/test when I run a "clean package" > >>>> at > >>>> wicket-core. > >>>> > >>>> It seems that package doesn't run the maven-eclipse-plugin at all > >>>> > >>>> kind regards > >>>> > >>>> Tobias > >>>> > >>>> P.S.: Sorry for some missing spaces - if it is fixed I will commit the > >>>> pom well formatted - the commits can be squashed then. > >>>> > >>>> Am 04.03.15 um 10:28 schrieb Emond Papegaaij: > >>>>> The maven-eclipse-plugin is not maintained at all. Everyone should use > >>>>> m2e. We have developed an eclipse plugin to apply these settings > >>>>> automatically when using m2e: > >>>>> https://github.com/topicusonderwijs/m2e-settings > >>>>> > >>>>> I think we should create a wicket-eclipse-settings maven artifact and > >>>>> use > >>>>> that. > >>>>> > >>>>> Best regards, > >>>>> Emond > >>>>> > >>>>> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote: > >>>>>> Hi Martin, > >>>>>> > >>>>>> maybe we can use the maven-eclipse-plugin to apply formatting rules: > >>>>>> > >>>>>> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-co > >>>>>> de > >>>>>> -s > >>>>>> tyl es.html > >>>>>> > >>>>>> The plugin itself is not well maintained, but we only need to apply > >>>>>> the > >>>>>> formatting rules to the IDE - I think on IDEA it is ignored, but we > >>>>>> have > >>>>>> to > >>>>>> check it. > >>>>>> > >>>>>> Does this address your feature? > >>>>>> > >>>>>> kind regards > >>>>>> > >>>>>> Tobias > >>>>>> > >>>>>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mgrigo...@apache.org>: > >>>>>>> Hi Tobias, > >>>>>>> > >>>>>>> I personally use Intellij IDEA and these files are in not in use by > >>>>>>> me. > >>>>>>> But AFAIR the most useful feature in them is the code formatting > >>>>>>> rules. > >>>>>>> We > >>>>>>> try to keep Wicket code formatted the same style. IMO this helps a > >>>>>>> lot > >>>>>>> in > >>>>>>> maintenance. I personally get distracted when debugging something > >>>>>>> and > >>>>>>> see > >>>>>>> code snippet that is wrongly formatted, or doesn't use braces, or > >>>>>>> something > >>>>>>> similar. > >>>>>>> > >>>>>>> I think I am the only user of IDEA in the team (except Peter Ertl, > >>>>>>> but > >>>>>>> he > >>>>>>> is not very active lately) so I'm sure others will give their > >>>>>>> feedback > >>>>>>> on > >>>>>>> this soon. > >>>>>>> > >>>>>>> Martin Grigorov > >>>>>>> Wicket Training and Consulting > >>>>>>> https://twitter.com/mtgrigorov > >>>>>>> > >>>>>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko < > >>>>>>> > >>>>>>> tobiassolosche...@googlemail.com> wrote: > >>>>>>>> Hi everyone, > >>>>>>>> > >>>>>>>> I saw that there were several commits to .settings the last time > >>>>>>>> and > >>>>>>>> I > >>>>>>>> wondered why this folder is required in the repository anymore. > >>>>>>>> Here > >>>>>>>> is > >>>>>>>> a > >>>>>>>> list of the files in a .settings folder (wicket/.settings) > >>>>>>> > >>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.c > >>>>>>> or > >>>>>>> e. > >>>>>>> re > >>>>>>> sources.prefs > >>>>>>> > >>>>>>> > >>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m > >>>>>>> 2e > >>>>>>> .c > >>>>>>> or > >>>>>>> e.prefs > >>>>>>> > >>>>>>> > >>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.p > >>>>>>> de > >>>>>>> .c > >>>>>>> or > >>>>>>> e.prefs > >>>>>>> > >>>>>>> > >>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.w > >>>>>>> st > >>>>>>> .c > >>>>>>> om > >>>>>>> mon.component > >>>>>>> > >>>>>>> > >>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.w > >>>>>>> st > >>>>>>> .c > >>>>>>> om > >>>>>>> mon.project.facet.core.xml> > >>>>>>> > >>>>>>>> I think because maven is used to configure the projects we can > >>>>>>>> remove > >>>>>>> > >>>>>>> those > >>>>>>> > >>>>>>>> files from the repository and configure it all in maven. > >>>>>>>> > >>>>>>>> Encoding can be configured by (see > >>>>>>>> http://maven.apache.org/general.html#encoding-warning): > >>>>>>>> > >>>>>>>> <properties> > >>>>>>>> > >>>>>>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEnc > >>>>>>>> odi > >>>>>>>> ng> > >>>>>>> > >>>>>>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEnc > >>>>>>> od > >>>>>>> in > >>>>>>> g> > >>>>>>> > >>>>>>>> </properties> > >>>>>>>> > >>>>>>>> Java Compile-Level can be configured with the compiler-plugin: > >>>>>>>> <plugins> > >>>>>>>> > >>>>>>>> <plugin> > >>>>>>>> > >>>>>>>> <groupId>org.apache.maven.plugins</groupId> > >>>>>>>> <artifactId>maven-compiler-plugin</artifactId> > >>>>>>>> <version>3.2</version> > >>>>>>>> <configuration> > >>>>>>>> > >>>>>>>> <source>1.7</source> > >>>>>>>> <target>1.7</target> > >>>>>>>> > >>>>>>>> </configuration> > >>>>>>>> > >>>>>>>> </plugin> > >>>>>>>> > >>>>>>>> </plugins> > >>>>>>>> > >>>>>>>> The project facets are configured by "Maven Integration for Eclipse > >>>>>>>> WTP" > >>>>>>>> and it receives the information of the web.xml and the packaging > >>>>>>> > >>>>>>> configured > >>>>>>> > >>>>>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see > >>>>>>>> http://marketplace.eclipse.org/node/96737) > >>>>>>>> > >>>>>>>> The only entries to be custom configured are in > >>>>>>>> org.eclipse.core.resources.prefs containing .deprecations and I > >>>>>>>> wonder > >>>>>>>> if > >>>>>>>> they are required anymore. > >>>>>>>> > >>>>>>>> The only thing to be done after importing the project into > >>>>>>>> workspace > >>>>>>>> is > >>>>>>> > >>>>>>> to > >>>>>>> > >>>>>>>> configure it as maven project. The .settings folder is created > >>>>>>>> through > >>>>>>> > >>>>>>> the > >>>>>>> > >>>>>>>> m2e plugin based on the pom.xml, web.xml. > >>>>>>>> > >>>>>>>> Did I overlook something? > >>>>>>>> > >>>>>>>> What do you think? > >>>>>>>> > >>>>>>>> kind regards > >>>>>>>> > >>>>>>>> Tobias
