Re: What else do we want to do before 8.0.0 final ?

2017-01-31 Thread Pedro Santos
Hi Martin, Wicket-4201 IPageProvider improvement: will work on the ticket during the week Expression language change [1]: it's a big change and I think it needs the team approval Wicket-4008 expression language parser: the parser is functional and there isn't much work pending on it. I can finis

Re: What else do we want to do before 8.0.0 final ?

2017-01-31 Thread Martin Grigorov
Hi Pedro, On Tue, Jan 31, 2017 at 10:25 AM, Pedro Santos wrote: > Hi Martin, > > Wicket-4201 IPageProvider improvement: will work on the ticket during the > week > > Expression language change [1]: it's a big change and I think it needs > the team approval > Here is the diff: https://github.com

Re: wicket git commit: Archetype version updated to 7.7.0-SNAPSHOT

2017-01-31 Thread Martin Grigorov
Hi Andrea, I think the release script that you have used should be improved to do this automatically. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Jan 31, 2017 at 2:48 PM, wrote: > Repository: wicket > Updated Branches: > refs/heads/wicket-7.x 5a2ce7b

Re: What else do we want to do before 8.0.0 final ?

2017-01-31 Thread Pedro Santos
Hi Martin, you missed the point of the proposal at [1], it's a syntax change that would move Wicket's expression language closer to Unified Expression Language. This change would better welcome developers used to work with expressions like: bean.map["key"] and move Wicket closer to JSR 341 (we can

Re: wicket git commit: Archetype version updated to 7.7.0-SNAPSHOT

2017-01-31 Thread Andrea Del Bene
Hi The script release.sh it's already meant to do so, but apparently we have a problem with sed command at line 474. This doesn't work, at least under linux: sed -e "s/\.*\<\/wicket\.version\>/\$version\<\/wicket.version\>/g" -i "" archetypes/quickstart/src/main/resources/archetype-resource

Re: What else do we want to do before 8.0.0 final ?

2017-01-31 Thread Martin Grigorov
Hi Pedro, On Tue, Jan 31, 2017 at 3:14 PM, Pedro Santos wrote: > Hi Martin, > > you missed the point of the proposal at [1], it's a syntax change that > would move Wicket's expression language closer to Unified Expression > Language. This change would better welcome developers used to work > wit

Re: wicket git commit: Archetype version updated to 7.7.0-SNAPSHOT

2017-01-31 Thread Martin Grigorov
What about using plain Maven means: diff --git i/archetypes/quickstart/pom.xml w/archetypes/quickstart/pom.xml index 88d858f..831aff5 100644 --- i/archetypes/quickstart/pom.xml +++ w/archetypes/quickstart/pom.xml @@ -29,8 +29,8 @@ -

Re: wicket git commit: Archetype version updated to 7.7.0-SNAPSHOT

2017-01-31 Thread Andrea Del Bene
The more we move to maven, the happier I am :). I will remove from the release script the code that generates the archetype pom. On 31/01/2017 20:37, Martin Grigorov wrote: What about using plain Maven means: diff --git i/archetypes/quickstart/pom.xml w/archetypes/quickstart/pom.xml index 88d

Re: wicket git commit: Archetype version updated to 7.7.0-SNAPSHOT

2017-01-31 Thread Martin Grigorov
OK. I'll make the changes in the poms Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Jan 31, 2017 at 9:13 PM, Andrea Del Bene wrote: > The more we move to maven, the happier I am :). I will remove from the > release script the code that generates the arche

Re: wicket git commit: Archetype version updated to 7.7.0-SNAPSHOT

2017-01-31 Thread Tobias Soloschenko
Really great! I like those changes! :-) kind regards Tobias > Am 31.01.2017 um 21:24 schrieb Martin Grigorov : > > OK. I'll make the changes in the poms > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Tue, Jan 31, 2017 at 9:13 PM, Andrea Del Bene

Re: What else do we want to do before 8.0.0 final ?

2017-01-31 Thread Sven Meier
Hi Pedro, PropertyResolver is very lenient currently, defining the dot (.) as a separator of properties only - there's not much more about it. With a custom IPropertyLocator (WICKET-5623) the following is supported too: PropertyResolver.getValue("foo.bar.path/to/node", document);

[GitHub] wicket issue #103: Added the new KeyReplacingLocalizer

2017-01-31 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/103 @robsonke Ping! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] wicket issue #199: WICKET-6289 fix autolinker so it does not generate an onc...

2017-01-31 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/199 @duesenklipper Please close this PR! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] wicket issue #190: AjaxDownload is implemented using hidden iframe

2017-01-31 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/190 @solomax Please close this PR! We will use the solution in https://issues.apache.org/jira/browse/WICKET-6286. Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] wicket issue #191: AjaxDownload is implemented using hidden iframe

2017-01-31 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/191 @solomax Please close this PR! We will use the solution in https://issues.apache.org/jira/browse/WICKET-6286. Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] wicket issue #131: Conversion of Gdoc to Asciidoctor

2017-01-31 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/131 @thijs1108 @dashorst Please close this PR! It has been merged to 8.x and 7.x. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] wicket issue #160: Upgrade to Atmosphere 2.4.2

2017-01-31 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/160 @payou Please close this PR! Wicket team decided to discontinue the support for Wicket-Atmosphere (see https://issues.apache.org/jira/browse/WICKET-6305). Thanks! --- If your project is set up for

[GitHub] wicket issue #203: Wicket 7.x please correction doc about CDI

2017-01-31 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/203 @jac-czerwinski Please close this PR. It cannot be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

Re: What else do we want to do before 8.0.0 final ?

2017-01-31 Thread Pedro Santos
Hi Sven, > PropertyResolver is very lenient currently, defining the dot (.) as a > separator of properties only - there's not much more about it. There is. Take the expression "a.b.c", there's no guarantee Wicket's tokenizer will break it only by dots. A custom IPropertyLocator currently has to

Re: What else do we want to do before 8.0.0 final ?

2017-01-31 Thread Pedro Santos
Hi Martin, > The comparison with the component queueing is because again we are going to > introduce a change that no one ever asked for I asked for, and think I did a good job analyzing the current PropertyResolver and concluding that it's getting too complex and should be improved for better m

[GitHub] wicket pull request #191: AjaxDownload is implemented using hidden iframe

2017-01-31 Thread solomax
Github user solomax closed the pull request at: https://github.com/apache/wicket/pull/191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] wicket pull request #190: AjaxDownload is implemented using hidden iframe

2017-01-31 Thread solomax
Github user solomax closed the pull request at: https://github.com/apache/wicket/pull/190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Re: wicket git commit: Archetype version updated to 7.7.0-SNAPSHOT

2017-01-31 Thread Maxim Solodovnik
Hello All, I just have noticed In case wicket 7.6.0 is selected on this page: http://wicket.apache.org/start/quickstart.html quickstart generated has wicket version 7.5.0-SNAPSHOT Is it reproducible by others? On Wed, Feb 1, 2017 at 3:41 AM, Tobias Soloschenko wrote: > Really great! I like those

Re: wicket git commit: Archetype version updated to 7.7.0-SNAPSHOT

2017-01-31 Thread Martin Grigorov
Hi Maxim, This is the reason why we started this mail thread ;) On Feb 1, 2017 6:54 AM, "Maxim Solodovnik" wrote: > Hello All, > > I just have noticed > In case wicket 7.6.0 is selected on this page: > http://wicket.apache.org/start/quickstart.html quickstart generated > has wicket version 7.5.

Re: wicket git commit: Archetype version updated to 7.7.0-SNAPSHOT

2017-01-31 Thread Maxim Solodovnik
My bad, look through comments and haven't noticed this :(( On Wed, Feb 1, 2017 at 12:33 PM, Martin Grigorov wrote: > Hi Maxim, > > This is the reason why we started this mail thread ;) > > On Feb 1, 2017 6:54 AM, "Maxim Solodovnik" wrote: > >> Hello All, >> >> I just have noticed >> In case wick

[GitHub] wicket pull request #131: Conversion of Gdoc to Asciidoctor

2017-01-31 Thread thijs1108
Github user thijs1108 closed the pull request at: https://github.com/apache/wicket/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e