+1 to release
tested local build from sources
various examples
On Mon, Nov 26, 2018 at 10:30 PM Andrea Del Bene
wrote:
> This is a vote to release Apache Wicket 7.11.0
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for b
Something interesting:
with JDK 7 I get the following errors:
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 3.079 s
[INFO] Finished at: 2018-11-27T09:03:09+02:00
[INFO]
-
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/340
I would not change `tab` with 2 spaces for whole project
Even this markup can have `tab` and will be readable if CSS will be in
separate file
my 2c
---
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/340
@paulbors Any improvements are very welcome!
---
Github user paulbors commented on the issue:
https://github.com/apache/wicket/pull/340
Should we not consider a code style machine cleanup for the entire project?
---
This is a vote to release Apache Wicket 7.11.0
Please download the source distributions found in our staging area
linked below.
I have included the signatures for both the source archives. This vote
lasts for 72 hours minimum.
[ ] Yes, release Apache Wicket 7.11.0
[ ] No, don't release Apache W
I can remove it for you before restarting the release building.
On Mon, Nov 26, 2018 at 1:35 PM Maxim Solodovnik
wrote:
> Shall I remove java8 profile from the pom.xml?
>
> On Mon, 26 Nov 2018 at 18:49, Andrea Del Bene
> wrote:
>
> > +1 Looks fair to me!
> >
> > On Mon, Nov 26, 2018 at 12:23 PM
This vote is cancelled. I will run a new one asap.
On Mon, Nov 26, 2018 at 6:35 PM Andrea Del Bene
wrote:
> I can remove it for you before restarting the release building.
>
> On Mon, Nov 26, 2018 at 1:35 PM Maxim Solodovnik
> wrote:
>
>> Shall I remove java8 profile from the pom.xml?
>>
>> On
Shall I remove java8 profile from the pom.xml?
On Mon, 26 Nov 2018 at 18:49, Andrea Del Bene wrote:
> +1 Looks fair to me!
>
> On Mon, Nov 26, 2018 at 12:23 PM Maxim Solodovnik
> wrote:
>
> > Latest OpenJdk7 available is 7u95
> > I guess it is near to impossible to get update for java7 these da
+1 Looks fair to me!
On Mon, Nov 26, 2018 at 12:23 PM Maxim Solodovnik
wrote:
> Latest OpenJdk7 available is 7u95
> I guess it is near to impossible to get update for java7 these days.
>
> maybe we should add some instructions to documentation and leave the build
> as it is now
> So wicket-7 bui
Latest OpenJdk7 available is 7u95
I guess it is near to impossible to get update for java7 these days.
maybe we should add some instructions to documentation and leave the build
as it is now
So wicket-7 build should work for most of the devs?
On Mon, 26 Nov 2018 at 18:19, Andrea Del Bene wrote:
Ok, I did further tests for this problem, but I think that is even more
complicated than we thought. As I said in previous email (see JDK release
note below) the new policy about JavaDoc has been introduced at a certain
point in all the three JDK available at that time: 6, 7 and 8. So even if
I ha
Actually it is implemented this way in wicket-7.x HEAD right now ...
On Mon, 26 Nov 2018 at 17:36, Emond Papegaaij
wrote:
> As Wicket 7 is supposed to be built with jdk7, why not simply add the
> profile
> but not enable it by default when on jdk8? If you want build with jdk8 (or
> higher), you
As Wicket 7 is supposed to be built with jdk7, why not simply add the profile
but not enable it by default when on jdk8? If you want build with jdk8 (or
higher), you can enable the profile on the command line.
Best regards,
Emond
On maandag 26 november 2018 10:43:55 CET Maxim Solodovnik wrote:
Hello Andrea,
"extend the existing java8 profile activating it by default if our default
JDK is 1.8 or higher" will break toolchains build,
Here are the logs
https://ci.apache.org/builders/wicket-branch-7.x/builds/500/steps/compile/logs/stdio
(I
already tried it)
On Mon, 26 Nov 2018 at 16:40, And
Hi all,
following the discussion about the issues related to the building of 7.11.0
candidate, I suggest to do the following actions:
-cancel this vote
-remove the flag '--allow-script-in-comments' from JavaDoc plugin
configuration
-extend the existing java8 profile activating it by default if ou
The error is something like:
"Invalid parameter --allow-script-in-comments" and javadoc will fail
It looks like java8 profile is activated, I was sure it shouldn't since
java7 was selected using toolchains ...
On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene wrote:
> Hi Maxim
>
> On Mon, Nov 26, 2
Hi Maxim
On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik
wrote:
> Hello Andrea,
>
> according to my tests this is not working if toolchains plugin is being
> used, i.e.:
> 1) java8 is set on the machine as default
> 2) -Pbuildbot is used to activate java7 build
> Result: java8 profile will be a
I have added `java8` profile so it is possible to build wicket7 with java8
Java7 is unavailable on Ubuntu18, so java8 is the only option to test
Somehow I'm unable to build using java7 on both ubuntu16 and ubuntu18
(please see steps and details below)
Same time `mvn clean install -Pbuildbot` work
19 matches
Mail list logo
