Correct! :-)
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Mon, Feb 23, 2015 at 12:36 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
On Sun, Feb 22, 2015 at 9:27 PM, Martin Grigorov mgrigo...@apache.org
wrote:
Martijn,
quick quiz: do you
On Sun, Feb 22, 2015 at 9:27 PM, Martin Grigorov mgrigo...@apache.org wrote:
Martijn,
quick quiz: do you know/remember what IClusterable was created for ? :-)
Yup: for Terracotta integration to make it easier to identify objects
that should be clustered.
Martijn
On Sun, Feb 22, 2015 at
So,
based on further researches there is a very big impact if IPageProvider
is going to be IClusterable in general. I would recommend to keep it the
way it is currently implemented. If users want to build their own
PageProvider and want to use InlineFrame should build their PageProvider
to
What about this construct:
public P extends IPageProvider Serializable InlineFrame(final
String id, P p)
{
super(id);
pageProvider = p;
}
Would that be something (works in Java 8)? It would solve the problem
of InlineFrame, force users to at least use a serializable
Hi,
here is the ticket in which we discussed it.
https://issues.apache.org/jira/browse/WICKET-5828
kind regards
Tobias
Am 22.02.2015 um 17:31 schrieb Martin Grigorov mgrigo...@apache.org:
This has been fixed recently in master. Right after you've cut M5
On Feb 22, 2015 6:29 PM, Martijn
Ok,
But shouldn't IPageProvider rather extend IClusterable? One can
provide a custom IPageProvider implementation without having it be
serializable.
Martijn
On Sun, Feb 22, 2015 at 5:54 PM, Tobias Soloschenko
tobiassolosche...@googlemail.com wrote:
Hi,
here is the ticket in which we
Infact that the InlineFrame uses the Interface of IPageProvider and
users may implement their own PageProvider I would say yes - so that the
InlineFrame also works with other PageProviders we have to move the
ICusterable to IPageProvider. I checked out the other places
IPageProvider is used:
Hi Martijn,
yes! In my opinion this is perfectly ok.
kind regards
Tobias
Am 22.02.15 um 19:13 schrieb Martijn Dashorst:
What about this construct:
public P extends IPageProvider Serializable InlineFrame(final
String id, P p)
{
super(id);
pageProvider = p;
}
While fixing a compilation error due to the removal of IPageLink, I
encountered that InlineFrame now uses IPageProvider and stores it in
an instance field.
Unfortunately, IPageProvider has no requirement to be Serializable and
the default implementation PageProvider is not serializable. This will
This has been fixed recently in master. Right after you've cut M5
On Feb 22, 2015 6:29 PM, Martijn Dashorst martijn.dasho...@gmail.com
wrote:
While fixing a compilation error due to the removal of IPageLink, I
encountered that InlineFrame now uses IPageProvider and stores it in
an instance
+1
Although I don't expect anyone trying to implement custom IPageProvider.
If it was that easy we would simplify our own long time ago:
https://issues.apache.org/jira/browse/WICKET-4201
On Sun, Feb 22, 2015 at 8:13 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
What about this
Martijn,
quick quiz: do you know/remember what IClusterable was created for ? :-)
On Sun, Feb 22, 2015 at 7:07 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
Ok,
But shouldn't IPageProvider rather extend IClusterable? One can
provide a custom IPageProvider implementation without
12 matches
Mail list logo
