[Wicketstuff] Am I allowed to break the API on the 6.x-branch?

2015-04-28 Thread Joachim Rohde
Hi, by coincidence I realized that a few examples in the Wicketstuff project GMap3 are broken (e.g. the marker examples). While I was starting to fix those issues I realized that Google removed quite a lot of properties (like shadows for markers

Re: [Wicketstuff] Am I allowed to break the API on the 6.x-branch?

2015-04-28 Thread Martin Grigorov
Hi Joachim, For 6.x I think it is enough to mark the methods/constructors as deprecated explaining why they don't work as expected anymore. For 7.x just remove the methods/constructors. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Apr 29, 2015 at 12:01

Re: [Wicketstuff] Am I allowed to break the API on the 6.x-branch?

2015-04-28 Thread Dan Haywood
My suggestion would be to deprecate the constructor and update its javadoc to say that the GIcon shadow parameter is now ignored. Dan (Apache Isis committer, user of Wicket) On 28 April 2015 at 22:01, Joachim Rohde mailingl...@joachimrohde.com wrote: Hi, by coincidence I realized that a few

Re: [Wicketstuff] Am I allowed to break the API on the 6.x-branch?

2015-04-28 Thread Joachim Rohde
Hm... haven't thought about that one. Thanks (also to Dan). Joachim On 04/28/2015 11:06 PM, Martin Grigorov wrote: Hi Joachim, For 6.x I think it is enough to mark the methods/constructors as deprecated explaining why they don't work as expected anymore. For 7.x just remove the