Re: [wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

WOW I was able to build wicketstuff using default memory settings! This is absolutely amazing :) On Tue, Sep 1, 2015 at 2:26 AM, Martin Grigorov wrote: > On Mon, Aug 31, 2015 at 10:16 PM, Joachim Rohde < > mailingl...@joachimrohde.com> wrote: > > > I get this error when I

Re: [wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

On Sun, Aug 30, 2015 at 7:57 PM, Joachim Rohde wrote: > Thanks for the effort, Martin. This makes things *really* easier. > > But just two small issues I encountered while compiling > > 1) I hadn't had toolchains configured on my machine so I was not able to >

Re: [wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

I get this error when I simply run mvn install from the command line using the master branch. My toolchains.xml looks like: jdk 1.7 sun /usr/lib/jvm/java-7-openjdk-amd64 jdk 1.8 sun

Re: [wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

On Mon, Aug 31, 2015 at 10:16 PM, Joachim Rohde < mailingl...@joachimrohde.com> wrote: > I get this error when I simply run > > mvn install > > from the command line using the master branch. > > My toolchains.xml looks like: > > > > > > jdk > > 1.7 > sun > >

Re: [wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

Thanks for the effort, Martin. This makes things *really* easier. But just two small issues I encountered while compiling 1) I hadn't had toolchains configured on my machine so I was not able to compile the project at first. I added a short paragraph in the Wiki

Re: [wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

I start working on this. Please do not push to WicketStuff 6.x and master until I'm ready. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Sun, Aug 16, 2015 at 7:23 PM, Martin Grigorov mgrigo...@apache.org wrote: +1 for toolchains! I think we should start by

Re: [wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

Done. It should be easier to port changes now! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Sat, Aug 22, 2015 at 8:47 AM, Martin Grigorov mgrigo...@apache.org wrote: I start working on this. Please do not push to WicketStuff 6.x and master until I'm ready.

Re: [wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

I finally found the time today to make those changes which you can find here: https://github.com/JoachimRohde/core Since the diff is slightly bigger than usually, here a short description of the relevant changes I made: - The animal sniffer plugin was integrated into the parent POM where it

Re: [wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

http://developer-blog.cloudbees.com/2014/12/beware-siren-target-call.html A blog post explaining that animal-sniffer is not perfect ... Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Sun, May 17, 2015 at 3:58 PM, Joachim Rohde

Re: [wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

Hi Joachim, What is your plan? Make the change only in master or also in wicket-6.x too? Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Sun, May 17, 2015 at 12:46 PM, Joachim Rohde mailingl...@joachimrohde.com wrote: Hi Martin, time is a bit scarce for me

Re: [wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

Hi Joachim, The reason to use two separate folders is that at deploy time we use [1]: $ cd jdk-1.6.x; JAVA_HOME=$JAVA_6_HOME mvn deploy $ cd ../jdk-7.x; JAVA_HOME=$JAVA_7_HOME mvn deploy $ cd ../jdk-8.x; JAVA_HOME=$JAVA_8_HOME mvn deploy With your approach we could just use

[wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

Hi, As I already mentioned the other day I was porting some changes from master branch to the wicket-6.x branch (http://apache-wicket.1842946.n4.nabble.com/wicketstuff-Need-help-with-cherry-picking-td4670615.html) and had some trouble doing so, since Git was not able to cherry-pick my changes