Re: HTML5 Output tag API

2015-06-02 Thread Tobias Soloschenko
Done. kind regards Tobias > Am 02.06.2015 um 08:49 schrieb Martin Grigorov : > > Hi, > > Please create a proper Pull Request so it is easier to see the changed code > and to comment on it. > > > On Tue, Jun 2, 2015 at 7:03 AM, Tobias Soloschenko < > tobiassolosche...@googlemail.com> wrote: >

Re: HTML5 Output tag API

2015-06-01 Thread Martin Grigorov
Hi, Please create a proper Pull Request so it is easier to see the changed code and to comment on it. On Tue, Jun 2, 2015 at 7:03 AM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > Thanks for the great hints! I am going to apply your changes, soon! > > kind regards > > Tobias >

Re: HTML5 Output tag API

2015-06-01 Thread Tobias Soloschenko
Done: https://github.com/klopfdreh/wicket/commit/c903161c422b24fb1e74a93b14ac8a22bcbc6ee9 (Have to fix the formatting) I like it much more, now - thank you a lot Sven! kind regards Tobias > Am 01.06.2015 um 23:55 schrieb Sven Meier : > > Hi Tobias, > >> public OutputField(String id, IMode

Re: HTML5 Output tag API

2015-06-01 Thread Tobias Soloschenko
Thanks for the great hints! I am going to apply your changes, soon! kind regards Tobias > Am 01.06.2015 um 23:55 schrieb Sven Meier : > > Hi Tobias, > >> public OutputField(String id, IModel model) > > something else than String could be possibly too, couldn't it? There was a reason why to

Re: HTML5 Output tag API

2015-06-01 Thread Sven Meier
Hi Tobias, public OutputField(String id, IModel model) something else than String could be possibly too, couldn't it? >public String getFormId() I'd prefer #getForm() instead, similar to AjaxButton. > public List getForIds() I'd prefer components instead of ids here too (similar to IFormV

HTML5 Output tag API

2015-06-01 Thread Tobias Soloschenko
Hi everyone, I would like to introduce a new API to make responsive forms available with the HTML5 tag "output". Information and examples can be found here: https://github.com/klopfdreh/wicket-components-playground/wiki/14.-HTML5-OutputField-API Benefits of the OutputField * Easy client sid