Re: Issues with /META-INF/wicket/*.properties

2015-10-19 Thread Martin Grigorov
... and I see it is not in the changelog too :-( @Martijn: did you forget to pull before doing the release ? :-) I'd like to have this change in 7.1.0 because it is a bug that requires big break in minor release to get rid of it. I'd would be better to remove it sooner before some libraries make u

Re: Issues with /META-INF/wicket/*.properties

2015-10-19 Thread Sebastien
Hi Martin, Actually the feature works with 7.1.0-SNAPSHOT but not with 7.1.0... On Mon, Oct 19, 2015 at 10:14 PM, Martin Grigorov wrote: > Hi, > > It must be included. > I haven't checked but Martijn cut the release after my commits. > Please check the -sources.tgz. Or start Wicket-JQuery-UI e

Re: Issues with /META-INF/wicket/*.properties

2015-10-19 Thread Martin Grigorov
Hi, It must be included. I haven't checked but Martijn cut the release after my commits. Please check the -sources.tgz. Or start Wicket-JQuery-UI examples against 7.1.0 and put a breakpoint in any of the IInitializer impls to see whether its #init() method is called during start of the app. Marti

Re: Issues with /META-INF/wicket/*.properties

2015-10-19 Thread Sebastien
Hi, Is this feature included (or supposed to be) in the 7.1.0 staging release of yesterday? Thanks & best regards, Sebastien. On Sun, Oct 18, 2015 at 11:31 AM, Martin Grigorov wrote: > Thanks for the responses! > > I'll work on 1.1 > > Martin Grigorov > Wicket Training and Consulting > https:/

Re: Issues with /META-INF/wicket/*.properties

2015-10-18 Thread Martin Grigorov
Thanks for the responses! I'll work on 1.1 Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Oct 14, 2015 at 1:38 PM, Martijn Dashorst < martijn.dasho...@gmail.com> wrote: > 1.1 for me as well > > Martijn > > On Wed, Oct 14, 2015 at 12:33 PM, Sven Meier wrot

Re: Issues with /META-INF/wicket/*.properties

2015-10-14 Thread Martijn Dashorst
1.1 for me as well Martijn On Wed, Oct 14, 2015 at 12:33 PM, Sven Meier wrote: > Hi Martin, > > I'd prefer solution 1.1: > > - the old solution worked fine, but the properties couldn't be merged for > uberjar (but nothing I ever worried about) > - the current solution is flawed, we should get ri

Re: Issues with /META-INF/wicket/*.properties

2015-10-14 Thread Sven Meier
Hi Martin, I'd prefer solution 1.1: - the old solution worked fine, but the properties couldn't be merged for uberjar (but nothing I ever worried about) - the current solution is flawed, we should get rid of it as soon as possible - ServiceLoader seems to be a simple working standard. Regard

Re: Issues with /META-INF/wicket/*.properties

2015-10-14 Thread Tobias Soloschenko
Hi Martin, maybe it is possible to extract the functionality into a submodule of wicket all libraries can use. kind regards Tobias > Am 14.10.2015 um 09:28 schrieb Martin Grigorov : > > Hi Tobias, > > The problem is that if you use some library (e.g. wicket-extensions, > wicket-jquery-ui, ..

Re: Issues with /META-INF/wicket/*.properties

2015-10-14 Thread Martin Grigorov
Hi Tobias, The problem is that if you use some library (e.g. wicket-extensions, wicket-jquery-ui, ...) then these libraries should implement both/all ways. I.e. if you implement your own way then these libraries most probably won't work. Martin Grigorov Wicket Training and Consulting https://twit

Re: Issues with /META-INF/wicket/*.properties

2015-10-13 Thread Tobias Soloschenko
Hi Martin, maybe there are two other options: 1. Use serviceloader in all NON-OSGi environments and only for OSGi use the old mechanism. 2. Implement a switch to tell the Wicket-Application to use the service loader or the old mechanism. Also I would allow the user to implement another way t

Issues with /META-INF/wicket/*.properties

2015-10-13 Thread Martin Grigorov
Hi devs, There are some issues with the new code for scanning for wicket.properties in 7.0.0: - https://issues.apache.org/jira/browse/WICKET-5997 (also discussed at http://stackoverflow.com/questions/33043321/has-anybody-been-able-to-run-wicket-7-0-0-on-websphere-liberty-profile-8-5-5-7 ) - https: